You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-10] [$250] Expense - "You appear to be offline" message displayed twice in destination list #72833
Version Number: 9.2.33-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#72187 Email or phone of affected tester (no customers):kiatest.78+ck101625@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 16/iOS 18.3.1/Safari, Pixel 15/Android 15/Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace has imported per diem rates
Navigate to staging.new.expensify.com or launch hybrid app
Go Offline
Tap + > Create expense > Per diem
Tap on the search field
Select destination
Go through the flow and proceed to confirm page
On confirm page, tap Destination field
Observe ""You appear to be offline" message displayed twice
Expected Result:
"You appear to be offline" message should be displayed once in destination list
Actual Result:
"You appear to be offline" message displayed twice in destination list
Please re-state the problem that we are trying to solve in this issue.
Expense - "You appear to be offline" message displayed twice in destination list
What is the root cause of that problem?
IOURequestStepDestination component has two nested ScreenWrapper components:
An outer ScreenWrapper that wraps the entire component
An inner ScreenWrapper inside StepScreenWrapper
Both ScreenWrapper components have shouldShowOfflineIndicator defaulting to true, causing duplicate offline messages. When openedFromStartPage is false (which happens when editing from confirmation), the StepScreenWrapper renders its own ScreenWrapper with offline indicator, and the outer ScreenWrapper also shows its offline indicator
As the component is wrapped in two ScreenWrapper 's and when the user goes offline, both of them display the offline message.
What changes do you think we should make in order to solve the problem?
We are using outer ScreenWrapper only for adding these two props: includePaddingTop, keyboardVerticalOffset to the ScreenWrapper.
We need to remove the outer ScreenWrapper here and pass these two props to the StepScreenWrapper instead. We also need to pass the shouldShowWrapper as true always. Also we need to add one more optional prop shouldShowHeader = true which we will use to show or hide the header inside the screenWrapper.
We need to add these three as optional props to our StepScreenWrapper component with default values as keyboardVerticalOffset = 0,
includePaddingTop = true,
shouldShowHeader = true,
And pass them to the ScreenWrapper component here:
This way we will only have one ScreenWrapper wrapping our StepScreenWrapper and it will avoid two offline messages when the user is offline and will also handle the two props that we were using earlier for the ScreenWrapper.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - "You appear to be offline" message displayed twice in destination list[/-][+][$250] Expense - "You appear to be offline" message displayed twice in destination list[/+]on Oct 22, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.42-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jayeshmangwani The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
jayeshmangwani If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
jayeshmangwani If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Workspace has imported per diem rates
Steps:
Open the workspace chat
Go offline
Tap + > Create expense > Per diem
Select destination
Go through the flow and proceed to confirm page
On confirm page, tap Destination field
Verify that the "You appear to be offline" message is displayed once
Activity
melvin-bot commentedon Oct 17, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Oct 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - "You appear to be offline" message displayed twice in destination list
What is the root cause of that problem?
IOURequestStepDestinationcomponent has two nestedScreenWrappercomponents:ScreenWrapperthat wraps the entire componentScreenWrapperinsideStepScreenWrapperBoth
ScreenWrappercomponents haveshouldShowOfflineIndicatordefaulting to true, causing duplicate offline messages. WhenopenedFromStartPageis false (which happens when editing from confirmation), theStepScreenWrapperrenders its ownScreenWrapperwith offline indicator, and the outerScreenWrapperalso shows its offline indicatorApp/src/pages/iou/request/step/IOURequestStepDestination.tsx
Lines 147 to 202 in 78b3db9
What changes do you think we should make in order to solve the problem?
Disable the offline indicator on the outer
ScreenWrappersince the innerStepScreenWrapperalready handles showing the offline indicator when neededApp/src/pages/iou/request/step/IOURequestStepDestination.tsx
Lines 147 to 151 in 78b3db9
Or we can disable the offline indicator on
StepScreenWrapperWhat alternative solutions did you explore? (Optional)
None
Burhan-Rashid commentedon Oct 17, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-10-27 08:22:46 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - "You appear to be offline" message displayed twice in destination list
What is the root cause of that problem?
We are using an additional ScreenWrapper container to wrap the StepScreenWrapper component here:
App/src/pages/iou/request/step/IOURequestStepDestination.tsx
Lines 147 to 152 in 98eeb6c
This wrapper is unnecessary as StepScreenWrapper component already uses the same wrapper itself here:
App/src/pages/iou/request/step/StepScreenWrapper.tsx
Lines 62 to 63 in 98eeb6c
As the component is wrapped in two ScreenWrapper 's and when the user goes offline, both of them display the offline message.
What changes do you think we should make in order to solve the problem?
We are using outer ScreenWrapper only for adding these two props: includePaddingTop, keyboardVerticalOffset to the ScreenWrapper.
We need to remove the outer ScreenWrapper here and pass these two props to the StepScreenWrapper instead. We also need to pass the shouldShowWrapper as true always. Also we need to add one more optional prop shouldShowHeader = true which we will use to show or hide the header inside the screenWrapper.
App/src/pages/iou/request/step/IOURequestStepDestination.tsx
Lines 147 to 152 in 98eeb6c
We need to add these three as optional props to our StepScreenWrapper component with default values as keyboardVerticalOffset = 0,
includePaddingTop = true,
shouldShowHeader = true,
And pass them to the ScreenWrapper component here:
App/src/pages/iou/request/step/StepScreenWrapper.tsx
Lines 62 to 63 in 98eeb6c
add the new prop types here:
App/src/pages/iou/request/step/StepScreenWrapper.tsx
Line 42 in 649daaf
set the default value of props here:
App/src/pages/iou/request/step/StepScreenWrapper.tsx
Line 54 in 649daaf
And Add the header conditional visibility here:
App/src/pages/iou/request/step/StepScreenWrapper.tsx
Line 74 in 2b89b1c
This way we will only have one ScreenWrapper wrapping our StepScreenWrapper and it will avoid two offline messages when the user is offline and will also handle the two props that we were using earlier for the ScreenWrapper.
Note for C+:
Branch for testing the changes fix/72833_new
Local PR for checking the actual diff(changes): https://github.com/Burhan-Rashid/App/pull/2/files
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Oct 20, 2025
@isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Oct 22, 2025
@isabelastisser Eep! 4 days overdue now. Issues have feelings too...
[-]Expense - "You appear to be offline" message displayed twice in destination list[/-][+][$250] Expense - "You appear to be offline" message displayed twice in destination list[/+]melvin-bot commentedon Oct 22, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021981095303733896889
melvin-bot commentedon Oct 22, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)22 remaining items
melvin-bot commentedon Nov 3, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.42-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 3, 2025
@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
isabelastisser commentedon Nov 13, 2025
BugZero Checklist:
jayeshmangwani The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
jayeshmangwani If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
jayeshmangwani If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
isabelastisser commentedon Nov 13, 2025
Payment summary:
@jayeshmangwani requires payment through NewDot Manual Requests $250 for C+ review
@nyomanjyotisa paid $250 in Upwork automatic offer (Contributor)
jayeshmangwani commentedon Nov 13, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Fix/65746 Enable scroll for per diem when keyboard is open #66747
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Steps:
Do we agree 👍 or 👎
trjExpensify commentedon Nov 14, 2025
approved $250 for @jayeshmangwani.
isabelastisser commentedon Nov 14, 2025
All set!