You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-12] [$250] Reports - Empty report created in offline is not shown in reports page but expense is displayed #72837
Please re-state the problem that we are trying to solve in this issue.
Empty report created in offline is not shown in reports page but expense is displayed.
What is the root cause of that problem?
Since snapshot Onyx data only updates keys that already exist in snapshot_, newly created reports won’t be automatically added to the snapshot Onyx data.
What changes do you think we should make in order to solve the problem?
We should manually add the data to the snapshot in buildNewReportOptimisticData, similar to how we do it in buildOptimisticChangePolicyData.
Currently, this addition only happens when the active search matches the report route — but this condition can be discussed and potentially expanded to cover more cases if needed.
Empty report created in offline is not shown in reports page but expense is displayed.
The empty report was showing as expected in the video - then an expense was created. So it's no longer an empty report 🤔 - I'm going to try and test as well
changed the title [-]Reports - Empty report created in offline is not shown in reports page but expense is displayed[/-][+][$250] Reports - Empty report created in offline is not shown in reports page but expense is displayed[/+]on Oct 24, 2025
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Issue is ready for payment but no BZ is assigned. @greg-schroeder you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Oct 17, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dmkt9 commentedon Oct 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Empty report created in offline is not shown in reports page but expense is displayed.
What is the root cause of that problem?
Since snapshot Onyx data only updates keys that already exist in
snapshot_, newly created reports won’t be automatically added to the snapshot Onyx data.What changes do you think we should make in order to solve the problem?
We should manually add the data to the snapshot in
buildNewReportOptimisticData, similar to how we do it inbuildOptimisticChangePolicyData.App/src/libs/actions/Report.ts
Line 2871 in 98eeb6c
Currently, this addition only happens when the active search matches the report route — but this condition can be discussed and potentially expanded to cover more cases if needed.
2025-10-17.17-56-07.mp4
melvin-bot commentedon Oct 20, 2025
@OfstadC Whoops! This issue is 2 days overdue. Let's get this updated quick!
OfstadC commentedon Oct 20, 2025
I'm confused:
The empty report was showing as expected in the video - then an expense was created. So it's no longer an empty report 🤔 - I'm going to try and test as well
OfstadC commentedon Oct 21, 2025
Haven't gotten back to this yet - but will soon
[-]Reports - Empty report created in offline is not shown in reports page but expense is displayed[/-][+][$250] Reports - Empty report created in offline is not shown in reports page but expense is displayed[/+]melvin-bot commentedon Oct 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021981749924227067250
23 remaining items
melvin-bot commentedon Nov 5, 2025
@hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
OfstadC commentedon Nov 11, 2025
Please complete BZ checklist prior to payment date! Thank you!
OfstadC commentedon Nov 12, 2025
@hungvu193 Please complete BZ Checklist
@dmkt9 Offer sent here
melvin-bot commentedon Nov 12, 2025
Issue is ready for payment but no BZ is assigned. @greg-schroeder you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
hungvu193 commentedon Nov 13, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Fix/72837 - Empty report created in offline is not shown in reports page but expense is displayed #73719
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
OfstadC commentedon Nov 13, 2025
https://github.com/Expensify/Expensify/issues/567791
OfstadC commentedon Nov 13, 2025
Payment Summary
garrettmknight commentedon Nov 21, 2025
$250 approved for @hungvu193
m-natarajan commentedon Nov 24, 2025
@hungvu193 Can you please check the Regression Test Proposal step 7 ( Reports are not displayed, Is this a typo?)
OfstadC commentedon Dec 3, 2025
Bump @hungvu193
hungvu193 commentedon Dec 4, 2025
Yeah, it's typo. I updated it