You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-19] [$250] Reports - Create report button opens workspace selector when default workspace is expired #72883
Version Number: 9.2.33-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):sjdonisjonsidjosij@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Admin account is expired and has not been renewed
Admin creates a workspace and invites member to the workspace
The member has the invited workspace as default workspace
The member account does not have any expense
Perform the steps as the invited member
Go to staging.new.expensify.com
Open FAB > Create report
→ Restricted action page opens
Go to Reports > Submit
Click Create report button on the empty state
Expected Result:
Restricted action page will open
Actual Result:
Workspace selector opens, even when the invited (and expired) workspace is the only workspace
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6977852_1760710230897.14.mp4
// If the user's default workspace is personal and the user has more than one group workspace, which is paid and has chat enabled, or a chosen workspace is past the grace period, we need to redirect them to the workspace selection screen
We should check for other create Report buttons and do the same
IF needed we can also implement the case where if the workspaceIDForReportCreation is expired but there are other policies to select we are navigating to workspace selection list here
// If we couldn't guess the workspace to create the report, or a guessed workspace is past it's grace period and we have other workspaces to choose from
Please re-state the problem that we are trying to solve in this issue.
When a member tries to create a report and their only workspace has an expired admin account, the workspace selector screen opens unnecessarily. Since there's only one workspace available, the user has to select it first before being shown the restricted action page. This creates an extra navigation step when the system should directly show the restricted action page.
What is the root cause of that problem?
In FloatingActionButtonAndPopover.tsx (around line 501) and EmptySearchView.tsx (around line 329), the condition for showing the workspace selector is:
This condition navigates to the workspace selector whenever workspaceIDForReportCreation is not initially set, regardless of how many workspaces are available. When a user has only one workspace that isn't their active policy, workspaceIDForReportCreation remains undefined at this point, triggering the workspace selector unnecessarily.
What changes do you think we should make in order to solve the problem?
We should update the logic to handle single-workspace scenarios before showing the selector.
Changes needed in both FloatingActionButtonAndPopover.tsx (~line 501) and EmptySearchView.tsx (~line 329):
// If no workspace determined but multiple available, show selectorif(!workspaceIDForReportCreation&&groupPoliciesWithChatEnabled.length>1){Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());return;}// If no workspace determined but only one available, use itif(!workspaceIDForReportCreation&&groupPoliciesWithChatEnabled.length===1){workspaceIDForReportCreation=groupPoliciesWithChatEnabled.at(0)?.id;}// If workspace is restricted and there are other options, show selectorif(workspaceIDForReportCreation&&shouldRestrictUserBillableActions(workspaceIDForReportCreation)&&groupPoliciesWithChatEnabled.length>1){Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute());return;}
This ensures that when a user has only one workspace available (even if restricted), the system uses that workspace and directly navigates to the appropriate page (either creating a report or showing the restricted action page), without the unnecessary workspace selector step.
What alternative solutions did you explore?
Alternative 1: Modify the workspace selector page to auto-navigate when only one workspace exists
Rejected because: This would add logic in the wrong place and still cause an unnecessary render/navigation cycle
Alternative 2: Set workspaceIDForReportCreation earlier in the flow by changing the conditions at lines 489-494
Rejected because: This would require broader changes to the workspace selection logic and could affect other flows where the active policy check is intentional
Alternative 3: Add the single-workspace check only after both conditions fail
Rejected because: This wouldn't prevent the workspace selector from opening; it would just be a fallback that doesn't solve the navigation issue
changed the title [-]Reports - Create report button opens workspace selector when default workspace is expired[/-][+][$250] Reports - Create report button opens workspace selector when default workspace is expired[/+]on Oct 20, 2025
changed the title [-][$250] Reports - Create report button opens workspace selector when default workspace is expired[/-][+][Due for payment 2025-11-19] [$250] Reports - Create report button opens workspace selector when default workspace is expired[/+]on Nov 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.54-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee / @FitseTLT The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
@jjcoffee did this one have a regression? It looks like on the same day Nov 12 it was deployed to Prod but then also went back to deployed to staging with no other production update?
@abekkala Hmm weird, I'm guessing there must have been some automation issue there as there were no regressions that I'm aware of and there's nothing noted on the deploy issue.
Activity
melvin-bot commentedon Oct 17, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Oct 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - Create report button opens workspace selector when default workspace is expired
What is the root cause of that problem?
We are missing the code that check if
shouldRestrictUserBillableActionslike hereApp/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
Lines 507 to 518 in ea72aea
here
App/src/libs/SearchUIUtils.ts
Lines 1937 to 1946 in ea72aea
What changes do you think we should make in order to solve the problem?
We should check shouldRestrictUserBillableActions and navigate ROUTES.RESTRICTED_ACTION like here
App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
Line 518 in ea72aea
We should check for other create Report buttons and do the same
IF needed we can also implement the case where if the workspaceIDForReportCreation is expired but there are other policies to select we are navigating to workspace selection list here
App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
Lines 501 to 505 in ea72aea
What alternative solutions did you explore? (Optional)
gijoe0295 commentedon Oct 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Create report button opens workspace selector when default workspace is expired
What is the root cause of that problem?
We already check if the policy has
shouldRestrictUserBillableActions, but we don't open the restricted action page:App/src/libs/SearchUIUtils.ts
Lines 1930 to 1936 in 5681000
What changes do you think we should make in order to solve the problem?
Add a check below the above snippet to open restricted action page if user has 1 only group policy and it's restricted:
What alternative solutions did you explore? (Optional)
NA
abbasifaizan70 commentedon Oct 19, 2025
Please re-state the problem that we are trying to solve in this issue.
When a member tries to create a report and their only workspace has an expired admin account, the workspace selector screen opens unnecessarily. Since there's only one workspace available, the user has to select it first before being shown the restricted action page. This creates an extra navigation step when the system should directly show the restricted action page.
What is the root cause of that problem?
In
FloatingActionButtonAndPopover.tsx(around line 501) andEmptySearchView.tsx(around line 329), the condition for showing the workspace selector is:This condition navigates to the workspace selector whenever
workspaceIDForReportCreationis not initially set, regardless of how many workspaces are available. When a user has only one workspace that isn't their active policy,workspaceIDForReportCreationremains undefined at this point, triggering the workspace selector unnecessarily.What changes do you think we should make in order to solve the problem?
We should update the logic to handle single-workspace scenarios before showing the selector.
Changes needed in both
FloatingActionButtonAndPopover.tsx(~line 501) andEmptySearchView.tsx(~line 329):Replace the current condition:
With:
This ensures that when a user has only one workspace available (even if restricted), the system uses that workspace and directly navigates to the appropriate page (either creating a report or showing the restricted action page), without the unnecessary workspace selector step.
What alternative solutions did you explore?
Alternative 1: Modify the workspace selector page to auto-navigate when only one workspace exists
Alternative 2: Set
workspaceIDForReportCreationearlier in the flow by changing the conditions at lines 489-494Alternative 3: Add the single-workspace check only after both conditions fail
melvin-bot commentedon Oct 20, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021980277291655472724
[-]Reports - Create report button opens workspace selector when default workspace is expired[/-][+][$250] Reports - Create report button opens workspace selector when default workspace is expired[/+]melvin-bot commentedon Oct 20, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)25 remaining items
[-][$250] Reports - Create report button opens workspace selector when default workspace is expired[/-][+][Due for payment 2025-11-19] [$250] Reports - Create report button opens workspace selector when default workspace is expired[/+]melvin-bot commentedon Nov 12, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 12, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.54-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 12, 2025
@jjcoffee / @FitseTLT The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Nov 17, 2025
PAYMENT SUMMARY FOR NOV 19
please complete checklist
jjcoffee commentedon Nov 18, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/61170/files#r2536860029
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/569934
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
abekkala commentedon Nov 19, 2025
@jjcoffee did this one have a regression? It looks like on the same day Nov 12 it was deployed to Prod but then also went back to deployed to staging with no other production update?
jjcoffee commentedon Nov 20, 2025
@abekkala Hmm weird, I'm guessing there must have been some automation issue there as there were no regressions that I'm aware of and there's nothing noted on the deploy issue.
trjExpensify commentedon Nov 20, 2025
approved $250 for @jjcoffee.
abekkala commentedon Nov 21, 2025
@FitseTLT payment sent via Upwork and contract ended - thank you! 🎉