You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-20] [Due for payment 2025-11-07] [$250] Receipt gets lost and transaction type returns to cash after editing split. #72975
Version Number: 9.2.34-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@mukhrr Slack conversation (hyperlinked to channel name): #Open Source
Add one more split and make sure to match total of all splits
Click Save
Expected Result:
All transactions in report should have a receipt and card icon/text
Actual Result:
Only some (previously touched: added and subtracted) transactions have receipt and card icon/text. The rest defaults to cash and no receipt
Refreshing page makes it correct
Workaround:
Refreshing page makes it correct
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceedit_split_bug.mp4Recording.1783.mp4
Please re-state the problem that we are trying to solve in this issue.
Receipt gets lost editing split.
What is the root cause of that problem?
When editing or deleting transactions splits we optimistically build with buildOptimisticTransaction.
We lose receipts as we return empty object as receipt when building optimistically here:
Besides, not providing existing transactions card details when building it optimistically which leads to defaulting cash icon/text.
So we return both hasEReceipt and receipt when building optimistically.
What changes do you think we should make in order to solve the problem?
We need to return undefined for receipt and true for hasEReceipt in case it doesn't exist. Besider to get proper card or cash icon/text after editing split, we need to return card details of existing transaction:
changed the title [-]Receipt gets lost and transaction type returns to cash after editing split.[/-][+][$250] Receipt gets lost and transaction type returns to cash after editing split.[/+]on Oct 20, 2025
@ikevin127 pls, make sure I intentionally missed defaulting cash issue as it's already tracked in this issue and being fixed in this PR. Here is related Slack thread. Thanks!
Activity
melvin-bot commentedon Oct 20, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mukhrr commentedon Oct 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Receipt gets lost editing split.
What is the root cause of that problem?
When editing or deleting transactions splits we optimistically build with buildOptimisticTransaction.
We lose receipts as we return empty object as receipt when building optimistically here:
Besides, not providing existing transactions card details when building it optimistically which leads to defaulting cash icon/text.
App/src/libs/TransactionUtils/index.ts
Lines 363 to 365 in 7165a14
And receipt is decided to show only if we don't have receipt object and hasEReceipt is true
App/src/components/TransactionItemRow/DataCells/ReceiptCell.tsx
Line 25 in 7165a14
App/src/libs/TransactionUtils/index.ts
Lines 391 to 393 in 7165a14
So we return both
hasEReceiptandreceiptwhen building optimistically.What changes do you think we should make in order to solve the problem?
We need to return
undefinedfor receipt and true for hasEReceipt in case it doesn't exist. Besider to get proper card or cash icon/text after editing split, we need to return card details of existing transaction:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
[-]Receipt gets lost and transaction type returns to cash after editing split.[/-][+][$250] Receipt gets lost and transaction type returns to cash after editing split.[/+]melvin-bot commentedon Oct 20, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021980242265245066836
melvin-bot commentedon Oct 20, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)lakchote commentedon Oct 20, 2025
@ikevin127 please review @mukhrr's proposal above, thanks!
mukhrr commentedon Oct 20, 2025
@ikevin127 pls, make sure I intentionally missed defaulting cash issue as it's already tracked in this issue and being fixed in this PR. Here is related Slack thread. Thanks!
57 remaining items
Christinadobrzyn commentedon Nov 20, 2025
Thanks so much @ikevin127
@mukhrr, can you please provide your Upwork profile? TY!
mukhrr commentedon Nov 20, 2025
@Christinadobrzyn yes, here it's https://www.upwork.com/freelancers/~0161d24345b1f4556e
Christinadobrzyn commentedon Nov 20, 2025
Awesome! Thanks for the quick action @mukhrr! Can you please accept my offer? https://www.upwork.com/nx/wm/offer/109551057
ikevin127 commentedon Nov 20, 2025
@Christinadobrzyn Mind dropping a payment sumnary for ND request ? Thank you!
Christinadobrzyn commentedon Nov 20, 2025
Oh yep - payment summary - #72975 (comment)
mukhrr commentedon Nov 21, 2025
Accepted
mukhrr commentedon Nov 24, 2025
@Christinadobrzyn kindly bump here)
Christinadobrzyn commentedon Nov 24, 2025
Thanks for the nudge. Payment summary here - #72975 (comment)
Regression test here - #72975 (comment)
Closing this out as complete! Thanks everyone
JmillsExpensify commentedon Nov 25, 2025
$125 approved for @ikevin127