You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Needs Repro] Expense - Inconsistency on tapping Mark as paid for invoice and expenses #72999
Version Number: V9.2.34-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176671/test-cases/51507176 Email or phone of affected tester (no customers): Slottwo1 fgg55@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Money Requests
Action Performed:
Pre-condition : Use 2 non validated gmail accounts
Case 2
Pre-condition: Use non validated gmail account
Create few expenses in workspace chat
Submit and approve the expenses
Tap pay dropdown
Select mark as paid
Note prompt to enter mage code is shown
Expected Result:
Inconsistency must not be shown on tapping Mark as paid for invoice and expenses.
Actual Result:
Tapping Mark as paid prompts to enter magic for workspace expenses and paid automatically for invoice. Inconsistency on tapping Mark as paid for invoice and expenses.
Please re-state the problem that we are trying to solve in this issue.
Expense - Inconsistency on tapping Mark as paid for invoice and expenses
What is the root cause of that problem?
In invoices, the Mark as paid individually is wired with an inline onSelected handler in usePaymentOptions.ts inside usePaymentOptions. This bypasses the SettlementButton/KYCWall flow that performs the validation redirect. For expenses, the selection flows through the parent handler, so the validation redirect is triggered.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
changed the title [-]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-][+][WEDNESDAY] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+]on Nov 5, 2025
changed the title [-][WEDNESDAY] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-][+]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+]on Nov 11, 2025
changed the title [-]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-][+][Needs Repro] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+]on Nov 11, 2025
Activity
melvin-bot commentedon Oct 20, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Oct 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - Inconsistency on tapping Mark as paid for invoice and expenses
What is the root cause of that problem?
In invoices, the Mark as paid individually is wired with an inline onSelected handler in usePaymentOptions.ts inside usePaymentOptions. This bypasses the SettlementButton/KYCWall flow that performs the validation redirect. For expenses, the selection flows through the parent handler, so the validation redirect is triggered.
App/src/hooks/usePaymentOptions.ts
Lines 190 to 195 in 4d1a0f7
What changes do you think we should make in order to solve the problem?
We should remove the
onSelectedforisIndividualInvoiceRoomUtilhere
App/src/hooks/usePaymentOptions.ts
Lines 190 to 195 in 4d1a0f7
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Oct 27, 2025
@strepanier03 Still overdue 6 days?! Let's take care of this!
strepanier03 commentedon Oct 29, 2025
Haven't been able to test this yet.
truph01 commentedon Oct 31, 2025
We should hold this one as per #71330
hungvu193 commentedon Oct 31, 2025
Let me know if this is still reproducible after #71330 is merged. I will fix it as a part of the Payment Option project.
Thanks!
melvin-bot commentedon Nov 3, 2025
@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Nov 3, 2025
@strepanier03 Huh... This is 4 days overdue. Who can take care of this?
strepanier03 commentedon Nov 5, 2025
Will do! The PR isn't deployed yet so I'll check tomorrow.
1 remaining item
[-]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-][+][WEDNESDAY] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+]strepanier03 commentedon Nov 11, 2025
Retesting now.
[-][WEDNESDAY] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-][+]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+]strepanier03 commentedon Nov 11, 2025
No reproduction for me. I'm going to label to see if someone can repro.
[-]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-][+][Needs Repro] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+]MelvinBot commentedon Nov 11, 2025
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
jponikarchuk commentedon Nov 11, 2025
@strepanier03 This issue is not reproducible
Screenrecorder-2025-11-11-23-03-53-30.mp4
strepanier03 commentedon Nov 13, 2025
Okay, no reproducible any longer so I'm going to close.