Skip to content

[Needs Repro] Expense - Inconsistency on tapping Mark as paid for invoice and expenses #72999

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.2.34-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176671/test-cases/51507176
Email or phone of affected tester (no customers): Slottwo1 fgg55@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

  1. Pre-condition : Use 2 non validated gmail accounts

  2. Login in mweb(user A) and android (user B)

  3. Go to https://staging.new.expensify.com/home

  4. Go to workspace settings

  5. Enable invoice

  6. Send a invoice to user B

  7. Launch app

  8. Open invoice as user B

  9. Pay invoice as individual

  10. Note invoice is paid

Case 2
Pre-condition: Use non validated gmail account

  1. Create few expenses in workspace chat
  2. Submit and approve the expenses
  3. Tap pay dropdown
  4. Select mark as paid
  5. Note prompt to enter mage code is shown

Expected Result:

Inconsistency must not be shown on tapping Mark as paid for invoice and expenses.

Actual Result:

Tapping Mark as paid prompts to enter magic for workspace expenses and paid automatically for invoice. Inconsistency on tapping Mark as paid for invoice and expenses.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
2.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 20, 2025
  2. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Oct 20, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense - Inconsistency on tapping Mark as paid for invoice and expenses

    What is the root cause of that problem?

    In invoices, the Mark as paid individually is wired with an inline onSelected handler in usePaymentOptions.ts inside usePaymentOptions. This bypasses the SettlementButton/KYCWall flow that performs the validation redirect. For expenses, the selection flows through the parent handler, so the validation redirect is triggered.

    {
    text: translate('iou.payElsewhere', {formattedAmount: ''}),
    icon: Expensicons.Cash,
    value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
    onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE),
    },

    What changes do you think we should make in order to solve the problem?

    We should remove the onSelected for isIndividualInvoiceRoomUtil

        onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE),

    here

    {
    text: translate('iou.payElsewhere', {formattedAmount: ''}),
    icon: Expensicons.Cash,
    value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
    onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE),
    },

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    @strepanier03 Still overdue 6 days?! Let's take care of this!

  5. strepanier03 commented on Oct 29, 2025

    @strepanier03
    Contributor

    Haven't been able to test this yet.

  6. truph01 commented on Oct 31, 2025

    @truph01
    Contributor

    We should hold this one as per #71330

  7. hungvu193 commented on Oct 31, 2025

    @hungvu193
    Contributor

    Let me know if this is still reproducible after #71330 is merged. I will fix it as a part of the Payment Option project.

    Thanks!

  8. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    @strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  9. melvin-bot commented on Nov 3, 2025

    @melvin-bot

    @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

  10. strepanier03 commented on Nov 5, 2025

    @strepanier03
    Contributor

    Will do! The PR isn't deployed yet so I'll check tomorrow.

  11. 1 remaining item

  12. changed the title [-]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-] [+][WEDNESDAY] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+] on Nov 5, 2025
  13. strepanier03 commented on Nov 11, 2025

    @strepanier03
    Contributor

    Retesting now.

  14. changed the title [-][WEDNESDAY] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-] [+]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+] on Nov 11, 2025
  15. strepanier03 commented on Nov 11, 2025

    @strepanier03
    Contributor

    No reproduction for me. I'm going to label to see if someone can repro.

  16. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Nov 11, 2025
  17. changed the title [-]Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/-] [+][Needs Repro] Expense - Inconsistency on tapping Mark as paid for invoice and expenses[/+] on Nov 11, 2025
  18. MelvinBot commented on Nov 11, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  19. jponikarchuk commented on Nov 11, 2025

    @jponikarchuk
    Author

    @strepanier03 This issue is not reproducible

    Screenrecorder-2025-11-11-23-03-53-30.mp4
  20. strepanier03 commented on Nov 13, 2025

    @strepanier03
    Contributor

    Okay, no reproducible any longer so I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Needs ReproductionReproducible steps neededretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions