Skip to content

Payment issue for E/App PR#72089 #73036

Closed

Description

@pecanoro

Issue created to compensate the Contributor+ member for their work on #72089
Contributor+ member who reviewed the PR - @abdulrahuman5196

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 20, 2025
  2. melvin-bot commented on Oct 20, 2025

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. VictoriaExpensify commented on Oct 21, 2025

    @VictoriaExpensify
    Contributor

    Hey @pecanoro is this just standard payment of $250?

  4. pecanoro commented on Oct 21, 2025

    @pecanoro
    ContributorAuthor

    @VictoriaExpensify I don't remember what the guidelines say. In this case, it was only a PR review and there was no proposal stage for the issue.

  5. abdulrahuman5196 commented on Oct 27, 2025

    @abdulrahuman5196
    Contributor

    Hey @pecanoro is this just standard payment of $250?

    @pecanoro I think usually its the same contribution as a standard issue. Correct me if wrong anyways.

    For example, this issue also same case - 70315, with standard payment.

  6. abdulrahuman5196 commented on Oct 27, 2025

    @abdulrahuman5196
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA. not a regression but a continued fix

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Create a new account.
    2. Reload the app with this account.
    3. Log out of the app (close it completely).
    4. There should be no navigation-related errors appearing in the console.

    Do we agree 👍 or 👎

  7. abdulrahuman5196 commented on Oct 27, 2025

    @abdulrahuman5196
    Contributor

    @VictoriaExpensify Added the checklist as well. Could you kindly add the payment summary. The fix is in production for more than 7 days and has no regression.

  8. VictoriaExpensify commented on Oct 28, 2025

    @VictoriaExpensify
    Contributor

    Payment summary:
    C+: @abdulrahuman5196 owed $250 via NewDot

    Thanks @abdulrahuman5196 !

  9. trjExpensify commented on Oct 31, 2025

    @trjExpensify
    Contributor

    approved $250 for @abdulrahuman5196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions