Skip to content

[Due for payment 2025-11-12] Workspace - Delete modal persist displayed despite the Workspace is deleted #73083

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.35.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13177080/test-cases/41237957
Email or phone of affected tester (no customers): na
Issue reported by: Applause Internal Team
Device used: Win11/Chrome, Hybird IOS and OS
App Component: Workspace Settings

Action Performed:

Precondition: user have several workspace

  1. Open the link www.staging.new.expensify.com
  2. User logged in Owner workspace
  3. Navigate to Workspaces
  4. Tap on 3 dot next to any Workspace
  5. Select "Delete" button (observed that the WS is deleted , but the modal still displayed)

Expected Result:

After user clicked Delete button, the Delete modal should be disappeared

Actual Result:

After user clicked the delete button, the WS is disappeared, but the modal still displayed.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6980450_1761039599057.Recording__2279.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2025
  2. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. francoisl commented on Oct 21, 2025

    @francoisl
    Contributor

    Investigating this. I can repro locally on tag v9.2.34-2 with main Web-E code, so I'm wondering if it's a backend issue 🤔 Reviewing recent checklists now.

  7. francoisl commented on Oct 21, 2025

    @francoisl
    Contributor

    This is a weird one, I can still repro locally on Web-E's production branch, NewDot's 9.2.34-2 production tag, and on an 7-day commit from Auth. I think it's some sort of race condition. Also can't reproduce on staging with a fresh account:

    Screen.Recording.2025-10-21.at.10.57.50.mov

    Looking into older suspicious PRs that are already on production, starting with 64015.

  8. francoisl commented on Oct 21, 2025

    @francoisl
    Contributor

    Going to demote this for now, I can't repro anymore at all on staging v9.2.35-3.

  9. 29 remaining items

  10. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.44-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-12. 🎊

    For reference, here are some details about the assignees on this issue:

    • @situchan requires payment (Needs manual offer from BZ)
    • @dominictb requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    @situchan / @dominictb @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. shubham1206agra commented on Nov 6, 2025

    @shubham1206agra
    Contributor

    Only @situchan requires payment here

  14. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@RachCHopkins)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. RachCHopkins commented on Nov 13, 2025

    @RachCHopkins
    Contributor

    Do we need a regression test here?

  16. situchan commented on Nov 13, 2025

    @situchan
    Contributor
  17. RachCHopkins commented on Nov 13, 2025

    @RachCHopkins
    Contributor

    Thanks @situchan - I've just sent you an offer via Upwork!

  18. RachCHopkins commented on Nov 18, 2025

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions