Skip to content

[$250] Concierge as author is absent in LHN #73084

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.35-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #70535
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: MacOS Monterey 12.7.4 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Set priority to most recents
  3. Create expense in any workspace
  4. Ask concierge to change description by saying change description to "hello world"
  5. Wait for concierge response

Expected Result:

Now observe LHN where it shows last message and says set the description to "hello world" or changed the description to "hello world".
Author in LHN displays as Concierge (e.g. Concierge: set the description to "hello world")

Actual Result:

Now observe LHN where it shows last message and says set the description to "hello world" or changed the description to "hello world".
Author in LHN isn't displayed as Concierge (set the description to "hello world")

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6980454_1761039864688.Screen_Recording_2025-10-21_at_12.30.45.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021981441486866778474
  • Upwork Job ID: 1981441486866778474
  • Last Price Increase: 2025-10-23
  • Automatic offers:
    • samranahm | Contributor | 109236017
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2025
  2. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. abzokhattab commented on Oct 21, 2025

    @abzokhattab
    Contributor

    Looks to be a backend issue with the last actor being returned as the current account, not the concierge

  4. samranahm commented on Oct 21, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Concierge as author is absent in LHN

    What is the root cause of that problem?

    shouldShowLastActorDisplayName hides the actor name when the last action is IOU. On transaction threads, the “last action” can be IOU from the parent expense, so the prefix is suppressed even when the visible message is a Concierge modification.

    here

    function shouldShowLastActorDisplayName(report: OnyxEntry<Report>, lastActorDetails: Partial<PersonalDetails> | null, lastAction: OnyxEntry<ReportAction>) {
    if (
    !lastActorDetails ||
    reportUtilsIsSelfDM(report) ||
    (isDM(report) && lastActorDetails.accountID !== currentUserAccountID) ||
    lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ||
    (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW &&
    Object.keys(report?.participants ?? {})?.some((participantID) => participantID === CONST.ACCOUNT_ID.MANAGER_MCTEST.toString()))
    ) {
    return false;

    we should only suppress actor name for IOU if last actor is not CONCIERGE

    (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && lastActorDetails.accountID !== CONST.ACCOUNT_ID.CONCIERGE) ||

    here

    lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ||

    What changes do you think we should make in order to solve the problem?

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 23, 2025
  6. changed the title [-]Concierge as author is absent in LHN[/-] [+][$250] Concierge as author is absent in LHN[/+] on Oct 23, 2025
  7. melvin-bot commented on Oct 23, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 23, 2025
  9. melvin-bot commented on Oct 23, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  10. Ollyws commented on Oct 24, 2025

    @Ollyws
    Contributor

    @samranahm's proposal LGTM.

    🎀👀🎀 C+ reviewed

  11. 36 remaining items

  12. Ollyws commented on Dec 9, 2025

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/60307/files#r2603955868

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

      Test 01
        
        1. As admin open/draft an expense to workspace chat
        2. Open expense report
        3. Verify alternate text in LHN is "No activity yet"
        4. Trigger concierge modification with comment "change category to "Car"
        5. After concierge modification verify alternate text in LHN have concierge as last actor
        6. "Concierge: changed the category to "Car" (previously "Equipment")"
      
      Test 02
      Precondition: Invite a member to workspace
      
        1. Invite a member to workspace
        2. As member open/draft an expense to workspace chat
        3. Member open expense chat and verify the LHN text is "This chat is with Admin" no last actor
        4. Admin comment on the expense
        5. Submitter verify alternate text in LHN have Admin name as last actor "Admin: comment"
    

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-fe78-a5dd-b855-54031a824084
  13. mallenexpensify commented on Dec 12, 2025

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @samranahm paid $250 via Upwork
    Contributor+: @Ollyws due $250 via NewDot

    Test case created.

    Thx!

  14. m-natarajan commented on Dec 13, 2025

    @m-natarajan

    @Ollyws
    This is regarding Regression test proposal:
    For Test:01, I am not seeing the alternate text No activity in LHN after opening the report. The thread is not displayed in LHN until a comment is made. Is this a new change or potential issue?

    Recording.2071.mp4
  15. Ollyws commented on Dec 17, 2025

    @Ollyws
    Contributor

    @m-natarajan Ah maybe we should change that step, generally what it means is that is shows the opening message such as in your case "This is where Mnata.utest....."

  16. m-natarajan commented on Dec 23, 2025

    @m-natarajan

    @Ollyws Thanks, Can you please update the regression test proposal accordingly.

  17. Ollyws commented on Dec 24, 2025

    @Ollyws
    Contributor

    @m-natarajan Here you go:

    Test 01
      
      1. As admin open/draft an expense to workspace chat
      2. Open expense report
      3. Verify alternate text in LHN matches the welcome message in chat
      4. Trigger concierge modification with comment "change category to "Car"
      5. After concierge modification verify alternate text in LHN have concierge as last actor
      6. "Concierge: changed the category to "Car" (previously "Equipment")"
    
    Test 02
    Precondition: Invite a member to workspace
    
      1. Invite a member to workspace
      2. As member open/draft an expense to workspace chat
      3. Member open expense chat and verify the LHN text is "This chat is with Admin" no last actor
      4. Admin comment on the expense
      5. Submitter verify alternate text in LHN have Admin name as last actor "Admin: comment"
    
  18. m-natarajan commented on Dec 29, 2025

    @m-natarajan

    @Ollyws Sorry for the back and forth messages, Still the steps are not clear.

    For Test 01:
    Verify alternate text in LHN matches the welcome message in chat is displayed only for a workspace chat without any draft report. When admin creates an report the LHN is updated accordingly. Same with test 02 as well

    Recording.2128.mp4
  19. Ollyws commented on Dec 30, 2025

    @Ollyws
    Contributor

    @m-natarajan Ah well that part is not really relevant to the issue anyway so I think we can just have:

    Test 01

    1. As admin open/draft an expense to workspace chat
    2. Open expense report
    3. Trigger concierge modification with comment "change category to "Car"
    4. After concierge modification verify alternate text in LHN have concierge as last actor
    5. "Concierge: changed the category to "Car" (previously "Equipment")"
    

    Test 02
    Precondition: Invite a member to workspace

    1. Invite a member to workspace
    2. As member open/draft an expense to workspace chat
    3. Member open expense chat and verify the LHN text is "This chat is with Admin" no last actor
    4. Admin comment on the expense
    5. Submitter verify alternate text in LHN have Admin name as last actor "Admin: comment"
    
  20. Ollyws commented on Apr 8, 2026

    @Ollyws
    Contributor

    Seems I forgot to request this one...
    Requested on ND.

  21. JmillsExpensify commented on Apr 9, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions