Skip to content

Expense - Negative expense does not appear in unreported expense list in workspace report #73125

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.35-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #72552
Email or phone of affected tester (no customers): jsdonisodjsosjos11@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Account has self DM and workspace
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create an empty report
  4. Go to self DM
  5. Create an expense with negative amount
  6. Open the expense
  7. Click Report
  8. Select the empty report from Step 3
    → Negative expense can be added to workspace report
  9. Go to self DM
  10. Create an expense with negative amount
  11. Go to workspace chat
  12. Create an empty report
  13. On the empty report, click Add expense > Add unreported expense

Expected Result:

Negative expense should appear in the list of unreported expense when it is opened from workspace report, because it can be added to workspace report from Report field without error (Step 8)

Actual Result:

Negative expense does not appear in the list of unreported expense when it is opened from workspace report

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6980690_1761059510417.Screen_Recording_2025-10-21_at_23.09.10.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2025
  2. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 21, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 21, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. lanitochka17 commented on Oct 21, 2025

    @lanitochka17
    Author

    Production:

    Recording.4020.mp4
  7. ikevin127 commented on Oct 22, 2025

    @ikevin127
    Contributor

    🔄 I ran Vector1 on this deploy blocker issue and here are the top 3 possible offending PRs based on semantic similarity2 and reranking:

    • #72552: Fix: Don't show negative transactions on Add unreported expense screen
    • #72697: Fix/Dont allow merging transactions with negative amount
    • #72749: fix: blank row appears after creating a new report field in IOS

    Please drop a 👍 (correct) or 👎 (incorrect) as feedback regarding the results (will use to fine-tune the reranking model).

    Note

    PR # and name added as text only to avoid triggering regression automation on the issues which the above PRs are addressing in case the finding is incorrect.

    Footnotes

    1. Vector is currently a local-only prototype stage app that uses AI embeddings to find offending PRs for a given deploy blocker issue. Because of the early stage of the app, results must be taken with with a grain of🧂. How it works: grab deploy blocker issue's OP data (title, steps, expected / actual result) and embed -> grab all deploy checklist issue PRs data (title, explanation of change, tests, changed files, AI diff summary) and embed -> calculate cosine similarity of issue embedding to each PRs embedding -> get results -> perform reranking -> get final results. ↩

    2. Semantic similarity, when applied to embeddings, measures the similarity in meaning between different pieces of text by comparing their vector representations in a high-dimensional "semantic space". Texts with similar meanings are mapped to vectors that are close together, and this "closeness" is quantified using metrics like cosine similarity. This technology enables search engines and chatbots to find relevant information even without exact keyword matches, providing more accurate and contextualized results. ↩

  8. clarajones-expensify commented on Oct 27, 2025

    @clarajones-expensify
    Contributor

    Is there any further action needed here? @stitesExpensify

  9. stitesExpensify commented on Oct 27, 2025

    @stitesExpensify
    Contributor

    I don't believe so, I think this is the intended functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions