You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-18] [$250] Report-Wrong currency at company spend after add unreported different currency with wp #73192
Version Number: v9.2.36-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-1425/folder/13176730/41237114/965872675 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Win 11/Chrome App Component: Money Requests
Action Performed:
Precondition:
In self DM create 2 manual expenses with local currency (different USD)
Create a workspace, set currency is USD and go to this workspace create a manual expense
However, the unreported expense has a different currency and we still add it to the report total, but when the API request is done, BE returns the correct total amount, which in turns causes the out-of-pocket amount to be negative. From the OP example, the expense report has a $ currency, a total of $1. Then adds VND 5 of unreported expenses to the report.
The report total is optimistically updated to $6 and the nonReimbursableTotal is updated to $5.
Out-of-pocket spend = total - nonReimbursableTotal = $1
changed the title [-]Report-Wrong currency at company spend after add unreported different currency with wp[/-][+][$250] Report-Wrong currency at company spend after add unreported different currency with wp[/+]on Oct 24, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.48-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jayeshmangwani / @bernhardoj The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Preconditions:
- In self DM create a manual expenses with local currency (different than USD)
- Create a workspace, set currency to USD, go to this workspace chat, and create a manual expense
Steps
Open the expense report
Press More at the header > Add expense > Add unreported expense
Add the unreported expense
Verify the unreported expense amount is not added to the report total (it'll only be added after the conversion done by the BE)
Activity
melvin-bot commentedon Oct 22, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Oct 22, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The money request spend breakdown shows wrong amount information when adding unreported expense with different currency.
What is the root cause of that problem?
When we add an unreported expense, it will be added to the
nonReimbursableTotalandtotalwhich will show the spend breakdown.App/src/libs/actions/Transaction.ts
Lines 902 to 909 in 815c92f
However, the unreported expense has a different currency and we still add it to the report total, but when the API request is done, BE returns the correct total amount, which in turns causes the out-of-pocket amount to be negative. From the OP example, the expense report has a $ currency, a
totalof $1. Then adds VND 5 of unreported expenses to the report.The report
totalis optimistically updated to $6 and thenonReimbursableTotalis updated to $5.Out-of-pocket spend = total - nonReimbursableTotal = $1
App/src/libs/ReportUtils.ts
Line 4048 in 815c92f
When the API success, BE updates the total back to $1.
Out-of-pocket spend = total - nonReimbursableTotal = $-4
What changes do you think we should make in order to solve the problem?
We need to optimistically calculate the report total only if the currency is the same, just like we did when requesting money in a normal way.
App/src/libs/actions/IOU.ts
Lines 3455 to 3467 in 815c92f
We need to fix this for both the old and new report.
App/src/libs/actions/Transaction.ts
Lines 893 to 905 in 815c92f
[-]Report-Wrong currency at company spend after add unreported different currency with wp[/-][+][$250] Report-Wrong currency at company spend after add unreported different currency with wp[/+]melvin-bot commentedon Oct 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021981781505850640746
melvin-bot commentedon Oct 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)jayeshmangwani commentedon Oct 27, 2025
@bernhardoj 's proposal #73192 (comment) makes sense and works well - let’s go with it.
🎀 👀 🎀 C+ reviewed
13 remaining items
melvin-bot commentedon Nov 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.48-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 11, 2025
@jayeshmangwani / @bernhardoj The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Nov 17, 2025
PAYMENT SUMMARY FOR NOV 18
please complete checklist
bernhardoj commentedon Nov 18, 2025
Requested in ND.
abekkala commentedon Nov 18, 2025
@jayeshmangwani can you complete the checklist so we can close this one out? Thanks!
jayeshmangwani commentedon Nov 20, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: feat: reimbursable features #68581 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Preconditions:
- In self DM create a manual expenses with local currency (different than USD)
- Create a workspace, set currency to USD, go to this workspace chat, and create a manual expense
Steps
Do we agree 👍 or 👎
jayeshmangwani commentedon Nov 20, 2025
Apologies for the delay @abekkala , I’ve completed the checklist.
garrettmknight commentedon Nov 21, 2025
$250 approved for @bernhardoj
abekkala commentedon Nov 21, 2025
posting summary once more for easier visibility:
PAYMENT SUMMARY FOR NOV 18
trjExpensify commentedon Dec 3, 2025
approved $250 for @jayeshmangwani