Skip to content

[Due for payment 2025-11-17] [$250] Incorrect singular copy when holding multiple expenses #73381

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.37-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Select multiple expenses on the report screen
  2. Click Hold
  3. Observe the copy in the hold reason prompt

Expected Result:

If multiple expenses are selected, the copy should reflect plural, e.g.:
"Explain why you're holding these expenses."

Actual Result:

The message says: "Explain why you're holding this expense."
— The text uses singular wording even though multiple expenses were selected.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.1803.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021981729302377040234
  • Upwork Job ID: 1981729302377040234
  • Last Price Increase: 2025-10-24
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 23, 2025
  2. melvin-bot commented on Oct 23, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mukhrr commented on Oct 24, 2025

    @mukhrr
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Incorrect singular copy when holding multiple expenses

    What is the root cause of that problem?

    always showing singular here

    <Text style={styles.mb6}>{translate('iou.explainHold')}</Text>

    What changes do you think we should make in order to solve the problem?

    we should pass expenseCount to HoldReasonFormView.tsx and need to give count to translation

    <Text style={styles.mb6}>{translate('iou.explainHold', {count: expenseCount})}</Text>

    And in SearchHoldReasonPage:

        const expenseCount = route.name === SCREENS.SEARCH.MONEY_REQUEST_REPORT_HOLD_TRANSACTIONS 
                ? context.selectedTransactionIDs.length 
            : Object.keys(context.selectedTransactions).length;
    
        return (
            <HoldReasonFormView
                onSubmit={onSubmit}
                validate={validate}
                backTo={backTo}
                expenseCount={expenseCount}
            />
        );

    And we also need to change language files.

          explainHold: () => ({
                one: "Explain why you're holding this expense.",
                other: "Explain why you're holding these expenses.",
            }),
    

    What alternative solutions did you explore? (Optional)

  4. self-assigned this
    on Oct 24, 2025
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 24, 2025
  6. changed the title [-]Incorrect singular copy when holding multiple expenses[/-] [+][$250] Incorrect singular copy when holding multiple expenses[/+] on Oct 24, 2025
  7. melvin-bot commented on Oct 24, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 24, 2025
  9. melvin-bot commented on Oct 24, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

  10. lorretheboy commented on Oct 24, 2025

    @lorretheboy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Incorrect singular copy when holding multiple expenses

    What is the root cause of that problem?

    We only support singular copy here

    explainHold: "Explain why you're holding this expense.",

    What changes do you think we should make in order to solve the problem?

    1. Update translations to support both cases
            explainHold: () => ({
                one: "Explain why you're holding this expense.",
                other: "Explain why you're holding these expenses.",
            }),
    1. Update text to use new translations (Need to add new param transactionCount in HoldReasonFormView
                    <Text style={styles.mb6}>{translate('iou.explainHold', {count: transactionCount})}</Text>

    <Text style={styles.mb6}>{translate('iou.explainHold')}</Text>

    1. Calculate transaction count based on this context, we don't need to calculate them based on current screen, can just use context.selectedTransactionIDs with fallback context.selectedTransactions
      /**
      * Note: `selectedTransactionIDs` and `selectedTransactions` are two separate properties.
      * Setting or clearing one of them does not influence the other.
      * IDs should be used if transaction details are not required.
      */
       const transactionCount = context.selectedTransactionIDs.length || Object.keys(context.selectedTransactions).length;

    Then pass the value here

    <HoldReasonFormView
    onSubmit={onSubmit}
    validate={validate}
    backTo={backTo}
    />

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  11. Krishna2323 commented on Oct 25, 2025

    @Krishna2323
    Contributor

    @lorretheboy do you think keeping the route check could cause any issues? I feel your proposal is very similar to this one; the difference isn’t significant, and the route check would likely have been discussed in the PR and removed if necessary. Thanks!

  12. 31 remaining items

  13. mukhrr commented on Nov 19, 2025

    @mukhrr
    Contributor

    @muttmuure @puneetlath could you pls help on payment here?! Thanks

  14. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 24, 2025
  15. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 24, 2025
  16. melvin-bot commented on Nov 24, 2025

    @melvin-bot

    Current assignee @Krishna2323 is eligible for the External assigner, not assigning anyone new.

  17. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 24, 2025
  18. muttmuure commented on Nov 24, 2025

    @muttmuure
    Contributor
  19. muttmuure commented on Nov 24, 2025

    @muttmuure
    Contributor

    Payment Summary

    Contributor: @mukhrr paid $250 via Upwork
    Contributor+: @Krishna2323 due $250 via NewDot

  20. muttmuure commented on Nov 24, 2025

    @muttmuure
    Contributor

    Paid

  21. Krishna2323 commented on Dec 6, 2025

    @Krishna2323
    Contributor

    Requested in ND.

  22. quinthar commented on Dec 8, 2025

    @quinthar
    Contributor

    Approved $250 to @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions