Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.37-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
- Select multiple expenses on the report screen
- Click Hold
- Observe the copy in the hold reason prompt
Expected Result:
If multiple expenses are selected, the copy should reflect plural, e.g.:
"Explain why you're holding these expenses."
Actual Result:
The message says: "Explain why you're holding this expense."
— The text uses singular wording even though multiple expenses were selected.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Recording.1803.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021981729302377040234
- Upwork Job ID: 1981729302377040234
- Last Price Increase: 2025-10-24
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Oct 23, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mukhrr commentedon Oct 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect singular copy when holding multiple expenses
What is the root cause of that problem?
always showing singular here
App/src/pages/iou/HoldReasonFormView.tsx
Line 53 in 80f1e3b
What changes do you think we should make in order to solve the problem?
we should pass
expenseCounttoHoldReasonFormView.tsxand need to give count to translationAnd in
SearchHoldReasonPage:And we also need to change language files.
What alternative solutions did you explore? (Optional)
[-]Incorrect singular copy when holding multiple expenses[/-][+][$250] Incorrect singular copy when holding multiple expenses[/+]melvin-bot commentedon Oct 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021981729302377040234
melvin-bot commentedon Oct 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (
External)lorretheboy commentedon Oct 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Incorrect singular copy when holding multiple expenses
What is the root cause of that problem?
We only support singular copy here
App/src/languages/en.ts
Line 1343 in 8e8adfe
What changes do you think we should make in order to solve the problem?
transactionCountinHoldReasonFormViewApp/src/pages/iou/HoldReasonFormView.tsx
Line 53 in 2e0c58b
context.selectedTransactionIDswith fallbackcontext.selectedTransactionsApp/src/components/Search/SearchContext.tsx
Lines 235 to 239 in 525cddf
Then pass the value here
App/src/pages/Search/SearchHoldReasonPage.tsx
Lines 59 to 63 in 456b668
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Krishna2323 commentedon Oct 25, 2025
@lorretheboy do you think keeping the route check could cause any issues? I feel your proposal is very similar to this one; the difference isn’t significant, and the route check would likely have been discussed in the PR and removed if necessary. Thanks!
31 remaining items
mukhrr commentedon Nov 19, 2025
@muttmuure @puneetlath could you pls help on payment here?! Thanks
melvin-bot commentedon Nov 24, 2025
Current assignee @Krishna2323 is eligible for the External assigner, not assigning anyone new.
muttmuure commentedon Nov 24, 2025
@mukhrr please can you apply here: https://www.upwork.com/jobs/~021992921941091783368
muttmuure commentedon Nov 24, 2025
Payment Summary
Contributor: @mukhrr paid $250 via Upwork
Contributor+: @Krishna2323 due $250 via NewDot
muttmuure commentedon Nov 24, 2025
Paid
Krishna2323 commentedon Dec 6, 2025
Requested in ND.
quinthar commentedon Dec 8, 2025
Approved $250 to @Krishna2323