Skip to content

[Due for payment 2025-11-17] [$250] Tack distance-Upgrade add rate expense, recipient add as Admin briefly display and disappear #73483

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.38-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1469/folder/18717689/49855697/972471661
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Money Requests

Action Performed:

Precondition: Login with Expensifail account and the user does not have workspace

  1. Open https://staging.new.expensify.com
  2. Click on FAB, select "Track Distance", and go to the "Manual" tab
  3. Enter a valid distance and click "Next"
  4. Select a different user's email as the recipient
  5. Click the "Rate" option row and click "Upgrade"
  6. Set a custom distance rate and click "Save"
  7. Click "Create expense"
  8. Navigate to the new workspace's members

Expected Result:

Navigate to the new workspace's members and verify that the recipient has been added as Admin

Actual Result:

The recipient has been added as Admin briefly display and disappear

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6983941_1761374061181.Recording__1388.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021983901283290527319
  • Upwork Job ID: 1983901283290527319
  • Last Price Increase: 2025-10-30
  • Automatic offers:
    • dominictb | Contributor | 109301345
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 25, 2025
  2. melvin-bot commented on Oct 25, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 25, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 25, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 25, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. abbasifaizan70 commented on Oct 25, 2025

    @abbasifaizan70
    Contributor

    Bug: CreateWorkspace API Ignores memberData Field

    Summary

    When creating a distance expense with a recipient who doesn't have a workspace, the CreateWorkspace API receives recipient data in the memberData field but completely ignores it, causing recipients to disappear from the workspace.

    Root Cause

    The CreateWorkspace API receives the correct payload with recipient information in memberData but returns an incorrect response that excludes the recipient from the workspace.

    API Payload

    memberData:  
    {"accountID":20780824,"email":"abbasi.faizan70+1@gmail.com","workspaceChatReportID":"497461016954865","workspaceChatCreatedReportActionID":"3346657098164075283","role":"admin"}

    API Response

     "employeeList": {
                        "abbasi.faizan1997+00@gmail.com": {
                            "email": "abbasi.faizan1997+00@gmail.com",
                            "forwardsTo": "",
                            "role": "admin",
                            "submitsTo": "abbasi.faizan1997+00@gmail.com"
                        }
                    },

    The api is not returning correct data. it only returns the current workspace owner.

    Proposed Solution

    The CreateWorkspace API should be fixed to return the correct response that includes the recipient in the employeeList when the payload contains valid memberData.

    Implementation

    The `CreateWorkspace` API will update to handle `employeeList`  list correctly.
    

    Files Affected

    • Backend: CreateWorkspace API implementation
    • Frontend: No changes needed (working correctly)
  7. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. 37 remaining items

  9. neil-marcellini commented on Nov 6, 2025

    @neil-marcellini
    Contributor

    I got a PR up for review. This was a frontend problem and could have been fixed externally @dominictb. You mentioned there was a problem with OpenWorkspaceMembersPage not returning the proper data, but if a read command is returning the wrong data then usually there's a problem with a preceding write command, as was the case here.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 10, 2025
  11. changed the title [-][$250] Tack distance-Upgrade add rate expense, recipient add as Admin briefly display and disappear[/-] [+][Due for payment 2025-11-17] [$250] Tack distance-Upgrade add rate expense, recipient add as Admin briefly display and disappear[/+] on Nov 10, 2025
  12. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.47-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-17. 🎊

  14. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    @neil-marcellini @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. sakluger commented on Nov 17, 2025

    @sakluger
    Contributor

    No payment is required since this was handled internally.

  16. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions