Skip to content

[Due for payment 2025-11-04] Expense - Unable to hold expense as Approver, error displayed #73510

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.38-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1473/folder/13176872/41237334/972475010
Email or phone of affected tester (no customers): hohovemgo+manager81@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max/iOS 26.0.1, Pixel 6/Android 16, Macbook Pro 15" 2019/Sequoia 15.7.1, Mac/Chrome, iPhone 15 Pro Max/Safari
App Component: Money Requests

Action Performed:

Preconditions:

  1. Create three public (gmail) accounts to be used as:
  • Owner
  • Approver
  • Employee
  1. Sign in as Owner and create a workspace
  2. Invite Employee and Approver to the workspace
  3. Navigate to Workspace > Workflows and set Approver account as Approver
  4. Sign in as Employee on and submit two expenses in the workspace chat

Steps:

  1. Open the app.
  2. Sign in as Approver
  3. Navigate to the workspace chat where an expense report was submitted by an employee.
  4. Tap the report preview.
  5. Tap any unheld expense listed in the report.
  6. Tap the More button.
  7. Tap Hold.
  8. Enter any reason and tap the confirmation button.

Expected Result:

The expense should be successfully put on hold

Actual Result:

Expense was not put on hold, and the error message “This request is being modified by another member” was displayed.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 27, 2025
  2. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Oct 27, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 27, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. inimaga commented on Oct 27, 2025

    @inimaga
    Contributor

    I'm able to reproduce this issue in staging. Oddly, it doesn't happen when the approver is set to a member of the workspace. It only happens when the approver is also a member of the workspace. Front-End blocker for now.

    Investigating...

  7. inimaga commented on Oct 27, 2025

    @inimaga
    Contributor

    Likely caused by this PR: #72366

    cc: @luacmartins @JS00001

  8. puneetlath commented on Oct 27, 2025

    @puneetlath
    Contributor

    it doesn't happen when the approver is set to a member of the workspace. It only happens when the approver is also a member of the workspace

    Did you mean that it doesn't happen when it is set to an admin?

  9. 4 remaining items

  10. luacmartins commented on Oct 27, 2025

    @luacmartins
    Contributor

    Hmm I'm also unable to repro on staging. @inimaga was there anything special you had to do to repro this issue? The steps in the OP don't do it for me.

  11. inimaga commented on Oct 27, 2025

    @inimaga
    Contributor

    Does reverting that PR locally fix the issue?

    Yes. Just confirmed.

    Hmm I'm also unable to repro on staging.

    @luacmartins Let me add your account as a member to my workspace. Messaging you on NewDot.

  12. puneetlath commented on Oct 27, 2025

    @puneetlath
    Contributor

    I see it on staging.

    Image
  13. puneetlath commented on Oct 27, 2025

    @puneetlath
    Contributor

    Confirmed the fix worked.

  14. added and removed on Oct 27, 2025
  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 28, 2025
  16. changed the title [-]Expense - Unable to hold expense as Approver, error displayed[/-] [+][Due for payment 2025-11-04] Expense - Unable to hold expense as Approver, error displayed[/+] on Oct 28, 2025
  17. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions