Skip to content

[Due for payment 2026-03-13] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Report.ts #73648

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Oct 28, 2025
  2. tgolen commented on Oct 28, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2025
  4. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Oct 28, 2025
  6. melvin-bot commented on Nov 11, 2025

    @melvin-bot

    @tgolen @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. 106 remaining items

  8. parasharrajat commented on Mar 6, 2026

    @parasharrajat
    Member

    Can you review the compensation for this @tgolen ?

  9. zanyrenney commented on Mar 6, 2026

    @zanyrenney
    Contributor

    Hey @parasharrajat can you clarify what you mean by review the compensation? Let me know if it's something I can help with. Or @tgolen let me know what the amount to pay should be, please!

  10. parasharrajat commented on Mar 6, 2026

    @parasharrajat
    Member

    Yeah, review the amount you will pay @zanyrenney 😄

  11. tgolen commented on Mar 6, 2026

    @tgolen
    ContributorAuthor

    I went through them all, and $250 is fine for each one. So a total of $2,500 please @zanyrenney

  12. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  13. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. parasharrajat commented on Mar 14, 2026

    @parasharrajat
    Member

    No checklist here. It is ready to be paid and closed @mallenexpensify

  15. changed the title [-][Due for payment 2026-03-13] [Due for payment 2026-01-29] [Due for payment 2026-01-28] [Due for payment 2026-01-27] [Due for payment 2026-01-23] [Due for payment 2026-01-21] Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `src/libs/actions/Report.ts`[/-] [+][Due for payment 2026-03-13] Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `src/libs/actions/Report.ts`[/+] on Mar 16, 2026
  16. mallenexpensify commented on Mar 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @linhvovan29546 paid $2500 via Upwork
    Contributor+: @parasharrajat due $2500 via NewDot

    @linhvovan29546 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022033684084535165905

  17. linhvovan29546 commented on Mar 17, 2026

    @linhvovan29546
    Contributor

    @mallenexpensify I've accepted

  18. mallenexpensify commented on Mar 18, 2026

    @mallenexpensify
    Contributor

    @linhvovan29546 paid, summary updated above.
    Thx

  19. parasharrajat commented on Mar 19, 2026

    @parasharrajat
    Member

    Payment requested as per #73648 (comment)

  20. twisterdotcom commented on Mar 19, 2026

    @twisterdotcom
    Contributor

    @parasharrajat has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-b803-ac36-b6c1-a8492fb15f64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions