Skip to content

[Due for payment 2026-09-16] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_ACTIONS in src/libs/actions/Report.ts #73651

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

  • Module: src/libs/actions/Report.ts
  • Onyx Key: ONYXKEYS.COLLECTION.REPORT_ACTIONS
  • Reference: Line 313: ONYXKEYS.COLLECTION.REPORT_ACTIONS

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Oct 28, 2025
  2. tgolen commented on Oct 28, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2025
  4. melvin-bot commented on Oct 28, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. added and removed on Oct 28, 2025
  6. melvin-bot commented on Nov 11, 2025

    @melvin-bot

    @tgolen @trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  7. 196 remaining items

  8. melvin-bot commented on Sep 16, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. mallenexpensify commented on Sep 16, 2026

    @mallenexpensify
    Contributor

    @tgolen can you review the list of PRs and propose a price to pay? Thx

  10. removed
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Sep 16, 2026
  11. tgolen commented on Sep 16, 2026

    @tgolen
    ContributorAuthor

    I approve Total: $3,125

    These two PRs I felt were only $125, the rest were $250
    #95796
    #95881

  12. eVoloshchak commented on Sep 17, 2026

    @eVoloshchak
    Contributor

    I approve Total: $3,125
    These two PRs I felt were only $125, the rest were $250
    #95796
    #95881

    Shouldn't it be $3,250?
    12 * 250 + (2 * 125) = 3250

  13. tgolen commented on Sep 17, 2026

    @tgolen
    ContributorAuthor

    Oops, yes. You are right. $3250!

  14. mallenexpensify commented on Sep 19, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @eVoloshchak due $3250 via NewDot
    Contributor+: @bernhardoj due $3250 via NewDot

    Thx!

  15. flaviadefaria commented on Sep 22, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $3250 via NewDot

  16. JmillsExpensify commented on Sep 29, 2026

    @JmillsExpensify
    Contributor

    $3,250 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions