Repository navigation
[Partial Payment] Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/actions/Report.ts #73656
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/actions/Report.ts
- Onyx Key:
ONYXKEYS.PERSONAL_DETAILS_LIST - Reference:
Line 351: ONYXKEYS.PERSONAL_DETAILS_LIST
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Activity
tgolen commentedon Oct 28, 2025
Warning
DO NOT POST PROPOSALS ON THIS ISSUE!!
Bug-Zero Instructions
src/libs/actions/Report.tsto removeOnyx.connect()references #73647melvin-bot commentedon Oct 28, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lorretheboy commentedon Oct 28, 2025
I would happy to help if it opens for external
tgolen commentedon Oct 28, 2025
@lorretheboy I'll extend to you the same option I did over here, and just copy my comment:
Historically, this project has been for a closed group of contributors. However, I would be open to seeing what your proposal would be for this one. If it works out and you are solid and know what you're doing with few instuctions, then perhaps you can work on more of these for us. Can you post a quick proposal for this one, please?
265 remaining items
refactor: require personal details in openReport (part 9)
melvin-bot commentedon Nov 7, 2026
@parasharrajat
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.33-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
lorretheboy commentedon Nov 10, 2026
Part 10 can be opened for review this by tomorrow
rlinoz commentedon Nov 10, 2026
I am going on extended leave soon, and since you are already assigned here I will leave the rest of this one to you @tgolen 🙇