Skip to content

[Due for payment 2025-11-12] [BACK BUTTON] [HOLD on #59245] Expense - User is redirected to the workspace selector instead of the initial screen #73720

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.40-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72756
Email or phone of affected tester (no customers): agexptest+pr2810b2@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 15
App Component: Money Requests

Action Performed:

Preconditions: User has at least two workspaces, none of them set as default.
User has self-DM.

  1. Go to staging.new.expensify.com
  2. Tap on the Create button > Create expense
  3. Enter amount
  4. Choose your account on the Choose recipient step
  5. Tap on the Category field
  6. Select any workspace
  7. Select any category
  8. Tap three times on the back button at the top left

Expected Result:

The user is redirected to the initial screen of the flow (Inbox, Reports, Workspaces, or Account).

Actual Result:

The user is redirected to the workspace selector, followed by the confirmation screen, the 'Choose recipient' screen, and finally the 'Enter amount' screen.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 29, 2025
  2. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    Triggered auto assignment to @Valforte (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 29, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Eskalifer1 commented on Oct 29, 2025

    @Eskalifer1
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense - User is redirected to the workspace selector instead of the initial screen

    What is the root cause of that problem?

    I think the problem here is that we have a transition between different navigators, since the entire flow is focused on MoneyRequest, but SET_DEFAULT_WORKSPACE has its own navigator, which causes this bug.

    What changes do you think we should make in order to solve the problem?

    We need to move this screen:

    [SCREENS.RIGHT_MODAL.SET_DEFAULT_WORKSPACE]: {
    screens: {
    [SCREENS.SET_DEFAULT_WORKSPACE.ROOT]: ROUTES.SET_DEFAULT_WORKSPACE.route,
    },
    },

    Here:

    [SCREENS.RIGHT_MODAL.MONEY_REQUEST]: {
    screens: {

    It will look like this:

    [SCREENS.SET_DEFAULT_WORKSPACE.ROOT]: ROUTES.SET_DEFAULT_WORKSPACE.route,

    And then we need to move this to another stackNavigator from here:

    const SetDefaultWorkspaceModalStackNavigator = createModalStackNavigator<SetDefaultWorkspaceNavigatorParamList>({
    [SCREENS.SET_DEFAULT_WORKSPACE.ROOT]: () => require<ReactComponentModule>('../../../../pages/SetDefaultWorkspacePage').default,
    });

    To here:

    [SCREENS.MONEY_REQUEST.STEP_DISTANCE_MANUAL]: () => require<ReactComponentModule>('../../../../pages/iou/request/step/IOURequestStepDistanceManual').default,

    PS: we can totally remove this navigator after this

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

    2025-10-29.11.17.42.mov
  7. 6 remaining items

  8. cristipaval commented on Oct 29, 2025

    @cristipaval
    Contributor

    Demoting, given that it is a corner case (see the preconditions). We're working on it, fixing it for the next deploy, to avoid CPs

  9. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 31, 2025
  10. changed the title [-][BACK BUTTON] [HOLD on #59245] Expense - User is redirected to the workspace selector instead of the initial screen[/-] [+][Due for payment 2025-11-12] [BACK BUTTON] [HOLD on #59245] Expense - User is redirected to the workspace selector instead of the initial screen[/+] on Nov 5, 2025
  11. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.44-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-12. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    @parasharrajat @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. cristipaval commented on Nov 5, 2025

    @cristipaval
    Contributor

    this was a regression. Closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions