Skip to content

[Due for payment 2025-11-18] [$250] Update error handling in Onyx to prevent unnecessary data eviction #73779

Closed

Description

@mountiny

Coming from this proposal

Proposal: Update error handling in Onyx to prevent unnecessary data eviction

Background

For the last 7 days, about 7+ million logs with [Onyx] Failed to save to storage ... were reported from different users. Currently, for all errors triggered by Onyx.set, Onyx.multiSet, and Onyx.mergeCollection, the evictStorageAndRetry function is invoked.

Problem

When evictStorageAndRetry runs without verifying whether the error is storage-capacity related, it always tries to evict user data, causing loss of important information and degraded UI performance (e.g., Hidden items in the LHN when a parent report action is evicted)

Solution

Update evictStorageAndRetry function to evict storage only if the error is storage capacity related.
Draft PR: https://github.com/Expensify/react-native-onyx/pull/694/files

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021983595890962023765
  • Upwork Job ID: 1983595890962023765
  • Last Price Increase: 2025-10-29
  • Automatic offers:
    • abzokhattab | Reviewer | 109523935
Issue OwnerCurrent Issue Owner: @twisterdotcom
Issue OwnerCurrent Issue Owner: @VickyStash

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 29, 2025
  2. changed the title [-]Update error handling in Onyx to prevent unnecessary data eviction[/-] [+][$250] Update error handling in Onyx to prevent unnecessary data eviction[/+] on Oct 29, 2025
  3. melvin-bot commented on Oct 29, 2025

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 29, 2025
  5. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (External)

  6. melvin-bot commented on Oct 29, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 29, 2025
  8. 20 remaining items

  9. mountiny commented on Nov 11, 2025

    @mountiny
    ContributorAuthor

    Onyx update is deployed to production so we should monitor the logs

  10. twisterdotcom commented on Nov 18, 2025

    @twisterdotcom
    Contributor

    Am I paying this one out today? If so, do we need @abzokhattab to complete the checklist on this one or not?

  11. melvin-bot commented on Nov 18, 2025

    @melvin-bot

    📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  12. mountiny commented on Nov 18, 2025

    @mountiny
    ContributorAuthor

    I think no need for checklist on this one

    @Ollyws $250 for the App PR and $125 to @abzokhattab for review of the onyx PR Expensify/react-native-onyx#694 as there was no checklist/ platform testing so I dont think it should be a full payout

  13. mountiny commented on Nov 19, 2025

    @mountiny
    ContributorAuthor

    This is ready to be paid and closed 🙌

  14. moved this from CRITICAL to Done in [#whatsnext] #qualityon Nov 19, 2025
  15. twisterdotcom commented on Nov 19, 2025

    @twisterdotcom
    Contributor

    Payment Summary:

  16. Ollyws commented on Nov 20, 2025

    @Ollyws
    Contributor

    Requested on ND.

  17. twisterdotcom commented on Nov 21, 2025

    @twisterdotcom
    Contributor

    @Ollyws has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-7ab7-a1eb-e700-96336bb23901
  18. twisterdotcom commented on Nov 25, 2025

    @twisterdotcom
    Contributor
  19. JmillsExpensify commented on Nov 25, 2025

    @JmillsExpensify
    Contributor

    Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions