You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-18] [$250] Update error handling in Onyx to prevent unnecessary data eviction #73779
Proposal: Update error handling in Onyx to prevent unnecessary data eviction
Background
For the last 7 days, about 7+ million logs with [Onyx] Failed to save to storage ... were reported from different users. Currently, for all errors triggered by Onyx.set, Onyx.multiSet, and Onyx.mergeCollection, the evictStorageAndRetry function is invoked.
Problem
When evictStorageAndRetry runs without verifying whether the error is storage-capacity related, it always tries to evict user data, causing loss of important information and degraded UI performance (e.g., Hidden items in the LHN when a parent report action is evicted)
changed the title [-]Update error handling in Onyx to prevent unnecessary data eviction[/-][+][$250] Update error handling in Onyx to prevent unnecessary data eviction[/+]on Oct 29, 2025
@JmillsExpensify - as I, @twisterdotcom am already assigned to this issue as BZ, could you also check this box to confirm the Payment Summary above. Note that no single individual can both confirm the payment amounts and approve the payment itself due to SOX.
Activity
[-]Update error handling in Onyx to prevent unnecessary data eviction[/-][+][$250] Update error handling in Onyx to prevent unnecessary data eviction[/+]melvin-bot commentedon Oct 29, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021983595890962023765
melvin-bot commentedon Oct 29, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (
External)melvin-bot commentedon Oct 29, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.20 remaining items
mountiny commentedon Nov 11, 2025
Onyx update is deployed to production so we should monitor the logs
twisterdotcom commentedon Nov 18, 2025
Am I paying this one out today? If so, do we need @abzokhattab to complete the checklist on this one or not?
melvin-bot commentedon Nov 18, 2025
📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
mountiny commentedon Nov 18, 2025
I think no need for checklist on this one
@Ollyws $250 for the App PR and $125 to @abzokhattab for review of the onyx PR Expensify/react-native-onyx#694 as there was no checklist/ platform testing so I dont think it should be a full payout
mountiny commentedon Nov 19, 2025
This is ready to be paid and closed 🙌
twisterdotcom commentedon Nov 19, 2025
Payment Summary:
Ollyws commentedon Nov 20, 2025
Requested on ND.
twisterdotcom commentedon Nov 21, 2025
@Ollyws has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-7ab7-a1eb-e700-96336bb23901twisterdotcom commentedon Nov 25, 2025
Bump @JmillsExpensify pls
JmillsExpensify commentedon Nov 25, 2025
Done