You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment due 2025-12-10] [$250] Expense - App crashes after admin rejects member's expense and member opens Reports #73846
Version Number: 9.2.41-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp #62787 Email or phone of affected tester (no customers):sdoijndoidsjdnoidsj2@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Search
Action Performed:
Precondition:
Submission frequency is set to Instantly.
Admin invites member to the workspace.
Go to staging.new.expensify.com
[Member] Create two expenses in the workspace chat.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - App crashes after admin rejects member's expense and member opens Reports[/-][+][$250] Expense - App crashes after admin rejects member's expense and member opens Reports[/+]on Nov 3, 2025
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Submission frequency is set to Instantly.
Admin has invited a member to the workspace.
Test:
Launch the Expensify app.
As the workspace member, create two expenses in the workspace chat.
As the member, navigate to Reports > Expenses.
As the member, navigate back to Inbox.
As admin, open the member's expense report.
As admin, open any expense thread.
As admin, click More > Reject.
As admin, enter reason and save.
As the member, navigate to Reports.
Verify that the app does not crash after navigating to Reports as the member.
changed the title [-][$250] Expense - App crashes after admin rejects member's expense and member opens Reports[/-][+][Payment due 2025-12-10] [$250] Expense - App crashes after admin rejects member's expense and member opens Reports[/+]on Dec 10, 2025
Activity
melvin-bot commentedon Oct 30, 2025
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Oct 30, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-20 03:51:53 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes.
What is the root cause of that problem?
Here is error message
After the admin rejects the member's expense. Expense is moved to unreported expense => root cause is Onyx data update report id from "" to "0"
it causes useOnyx error here
App/src/components/SelectionListWithSections/Search/TransactionListItem.tsx
Line 65 in 16d7677
What changes do you think we should make in order to solve the problem?
We should use
getNonEmptyStringOnyxIDfunction to wrap the reportID to prevent changing the report ID from "" to "0"App/src/components/SelectionListWithSections/Search/TransactionListItem.tsx
Line 65 in 16d7677
Note: We can use
getNonEmptyStringOnyxIDin other places thatuseOnyxhookWhat alternative solutions did you explore? (Optional)
Or we can skip get the onyx data if report id is
"0"Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Expense - App crashes after admin rejects member's expense and member opens Reports[/-][+][$250] Expense - App crashes after admin rejects member's expense and member opens Reports[/+]melvin-bot commentedon Nov 3, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021985418819527787376
melvin-bot commentedon Nov 3, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)melvin-bot commentedon Nov 10, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
32 remaining items
akinwale commentedon Dec 9, 2025
BugZero Checklist:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[@akinwale] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[@akinwale] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎?
akinwale commentedon Dec 9, 2025
@garrettmknight Automation missed this. The PR was deployed to production on 2025-12-03 making the payment due date 2025-12-10.
[-][$250] Expense - App crashes after admin rejects member's expense and member opens Reports[/-][+][Payment due 2025-12-10] [$250] Expense - App crashes after admin rejects member's expense and member opens Reports[/+]garrettmknight commentedon Dec 10, 2025
Payment Summary
JmillsExpensify commentedon Dec 11, 2025
$250 approved for @akinwale