Repository navigation
Make AddPaymentMenu dynamic #7385
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Login to NewDot on web
- Select profile > payments
- Select add payment method
- Change screen width
Expected Result:
The payment method dropdown should show move along with the rest of the screen
Actual Result:
The payment method dropdown is in a fixed position on the screen.
Platform:
Web
Reproducible in staging?: Yes
Reproducible in production?: Tes
Notes/Photos/Videos:
http://g.recordit.co/PSG52y2iA6.gif
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/191203
Activity
MelvinBot commentedon Jan 25, 2022
Triggered auto assignment to @alexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Jan 25, 2022
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jan 26, 2022
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.30 remaining items
laurenreidexpensify commentedon Feb 9, 2022
@phivh all sorted 👍🏽 hired in upwork
deetergp commentedon Feb 17, 2022
Not overdue, code review is ongoing. Should have added the label to ward off @MelvinBot's passive aggression.
MelvinBot commentedon Mar 14, 2022
This issue has not been updated in over 15 days. @deetergp, @phivh, @rushatgabhane, @laurenreidexpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
rushatgabhane commentedon Mar 14, 2022
PR in staging
phivh commentedon Mar 23, 2022
@laurenreidexpensify do we need to wait for regression on this? it seems deployed to production 8 days.
#7847 (comment)
phivh commentedon Mar 28, 2022
@deetergp @laurenreidexpensify is there anything we need to wait for the payment? It seems we missing around 13 days for this task.
rushatgabhane commentedon Mar 30, 2022
@laurenreidexpensify bump ^^ #7385 (comment)
laurenreidexpensify commentedon Mar 30, 2022
oh weird some of the automation didn'tn take effect on this so I missed it. Looking into it now.
laurenreidexpensify commentedon Mar 30, 2022
Sorry @rushatgabhane @phivh something went really wrong here in the automation alerts for our team. I've paid this now. Thanks for your patience!