You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-13] [$250] “Expense over category daily limit” violation missing in NewDot but visible in OldDot #73922
Version Number: 9.2.41-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@iwiznia Slack conversation (hyperlinked to channel name): #Quality
Action Performed:
Precondition: Enable rules in workspace settings and set flag amounts over for a category (Meals and Entertainment)
Create an expense and allow it to SmartScan
Select the category (Meals and Entertainment)
SmartScan detects an amount lower than the actual total
Manually edit the amount to a higher value
Observe the violations displayed on the report in NewDot
Open the same report in OldDot (expensify.com)
Expected Result:
Both violations —
“Amount greater than scanned receipt”
“Expense over category daily limit”
— should display in NewDot just as they do in OldDot.
Actual Result:
Only “amount greater than scanned receipt” violation appears in NewDot.
The “Expense over category daily limit” violation is missing from the expense and report view, though it appears correctly in OldDot.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
changed the title [-]“Expense over category daily limit” violation missing in NewDot but visible in OldDot[/-][+][$250] “Expense over category daily limit” violation missing in NewDot but visible in OldDot[/+]on Oct 31, 2025
Please re-state the problem that we are trying to solve in this issue.
Only “amount greater than scanned receipt” violation appears in NewDot.
The “Expense over category daily limit” violation is missing from the expense and report view, though it appears correctly in OldDot.
What is the root cause of that problem?
We only display the first violation that affects the field. In this case, we have two violations of the amount field, but only one is displayed.
If we want another format or minor UI change, we can discuss it in the PR. We can also fix other places which have the same problem.
What alternative solutions did you explore? (Optional)
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This was initially implemented to display only the first violation on this PR Use error prop for violations for consistent styling #34303, which has been the behavior for a while. We’re now updating it to align with OD and show all violations.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Enable rules in workspace settings.
Set flag amounts over the limit for the Meals and Entertainment category.
Steps:
Create an expense and allow it to SmartScan.
Select the Meals and Entertainment category.
Ensure SmartScan detects an amount lower than the actual total.
Manually edit the amount to a higher value.
Verify that both of the following violations are displayed:
Activity
MelvinBot commentedon Oct 31, 2025
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
melvin-bot commentedon Oct 31, 2025
Triggered auto assignment to @clarajones-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]“Expense over category daily limit” violation missing in NewDot but visible in OldDot[/-][+][$250] “Expense over category daily limit” violation missing in NewDot but visible in OldDot[/+]melvin-bot commentedon Oct 31, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021984297430326230066
melvin-bot commentedon Oct 31, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)nkdengineer commentedon Oct 31, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Only “amount greater than scanned receipt” violation appears in NewDot.
The “Expense over category daily limit” violation is missing from the expense and report view, though it appears correctly in OldDot.
What is the root cause of that problem?
We only display the first violation that affects the field. In this case, we have two violations of the amount field, but only one is displayed.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 415 to 420 in 33753a9
What changes do you think we should make in order to solve the problem?
We should join and display all violation messages.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 415 to 420 in 33753a9
If we want another format or minor UI change, we can discuss it in the PR. We can also fix other places which have the same problem.
What alternative solutions did you explore? (Optional)
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
25 remaining items
melvin-bot commentedon Nov 6, 2025
@jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
clarajones-expensify commentedon Nov 12, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
clarajones-expensify commentedon Nov 12, 2025
Hi @jayeshmangwani ! would you fill out the above checklist when you can? TY!
And @nkdengineer - would you apply to the job on upwork? TY!
jayeshmangwani commentedon Nov 13, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This was initially implemented to display only the first violation on this PR Use error prop for violations for consistent styling #34303, which has been the behavior for a while. We’re now updating it to align with OD and show all violations.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not that CRITICAL
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Steps:
Do we agree 👍 or 👎
clarajones-expensify commentedon Nov 13, 2025
Payment Summary
Contributor: @nkdengineer due $250 via NewDot
Contributor+: @jayeshmangwani due $250 via NewDot
clarajones-expensify commentedon Nov 17, 2025
bump @nkdengineer - would you apply to the job on upwork? TY!
clarajones-expensify commentedon Nov 18, 2025
nevermind, @nkdengineer is paid via newdot now ^^
trjExpensify commentedon Dec 3, 2025
approved $250 for @jayeshmangwani
twisterdotcom commentedon Mar 11, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-f1ea-a706-afa3-9677643c70b4