Skip to content

Mark as resolved button does not appear for admin when admin rejects for the second time #74273

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.44-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72947
Email or phone of affected tester (no customers): sdjiosdjoidsjso@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Admin invites member to workspace chat.
  • Member has submitted an expense in workspace chat.
  • Perform the steps below as admin:
  1. Go to staging.new.expensify.com
  2. Go to workspace chat with member.
  3. Open expense report.
  4. Click More > Reject.
  5. Enter reason and click Reject expense.
    → Mark as resolved button appears for admin.
  6. Click Mark as resolved.
  7. Click More > Submit.
  8. Click More > Reject.
  9. Enter reason and click Reject expense.

Expected Result:

Mark as resolved button will appear for admin when admin rejects for the second time.

Actual Result:

Mark as resolved button does not appear for admin when admin rejects for the second time.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6994592_1762327423979.9.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Nov 5, 2025
  2. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 5, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 5, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mitarachim commented on Nov 5, 2025

    @mitarachim
    Author

    Issue was found while executing QA for PR #72947

  7. removed
    DeployBlockerIndicates it should block deploying the API
    on Nov 5, 2025
  8. luacmartins commented on Nov 5, 2025

    @luacmartins
    Contributor

    This is fixed. The admin no longer sees the Mark resolved primary action since the PR was reverted. We need to work on v2 to reintroduce that behavior.

  9. m-natarajan commented on Nov 5, 2025

    @m-natarajan

    MacOS Monterey Web v9.2.44-5 Not Reproduce - No Mark as resolved button

    Screen.Recording.2025-11-05.at.21.20.56.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions