[Due for payment 2025-11-13] Investigate workflow job failing on main: test / test (job 1) #74333
Description
🚨 Failure Summary 🚨:
- 📋 Job Name: test / test (job 1)
- 🔧 Failure in Workflow: Process new code merged to main
- 🔗 Triggered by PR: PR Link
- 👤 PR Author: @nkdengineer
- 🤝 Merged by: @inimaga
- 🐛 Error Message:
failure: Process completed with exit code 1.
🛠️ A recent merge appears to have caused a failure in the job named test / test (job 1).
This issue has been automatically created and labeled with Workflow Failure for investigation.
👀 Please look into the following:
- Why the PR caused the job to fail?
- Address any underlying issues.
🐛 We appreciate your help in squashing this bug!
Activity
nkdengineer commentedon Nov 5, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Investigate workflow job failing on main: test / test
What is the root cause of that problem?
isWaitingOnBankAccountis random when creating a report when it'strueApp/tests/utils/collections/reports.ts
Line 18 in 2409bec
App/tests/actions/IOUTest.ts
Lines 6484 to 6489 in 2409bec
The check returns false here
App/src/libs/actions/IOU.ts
Line 10130 in 2409bec
What changes do you think we should make in order to solve the problem?
We should override
isWaitingOnBankAccounttofalsefor the expense report hereApp/tests/actions/IOUTest.ts
Lines 6484 to 6489 in 2409bec
What alternative solutions did you explore? (Optional)
We can remove
isWaitingOnBankAccountfrom here then it will not be randomApp/tests/utils/collections/reports.ts
Line 18 in 2409bec
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nkdengineer commentedon Nov 5, 2025
@inimaga It doesn't come from our PR.
inimaga commentedon Nov 5, 2025
You're right. Closing. Thanks for taking a look.
nkdengineer commentedon Nov 5, 2025
@inimaga I proposed a proposal for this? Can you take a look?
inimaga commentedon Nov 5, 2025
@nkdengineer I saw, but this workflow failure was introduced by this PR, and being worked on already by @mukhrr (See here and here).
The convention is to assign the original PR authors to fix their regressions before opening it up to others.
nkdengineer commentedon Nov 5, 2025
Got it.
[-]Investigate workflow job failing on main: test / test (job 1)[/-][+][Due for payment 2025-11-13] Investigate workflow job failing on main: test / test (job 1)[/+]melvin-bot commentedon Nov 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-13. 🎊