You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-02] [$250] WS settings - Rules are not highlighted in workspace setting after enabling the More features #74387
Version Number: 9.2.45-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Sign in to ND
Create a workspace
Open More features, toggle on Rules
Observe the Rules row in the workspace settings
Expected Result:
Rules row is highlighted in the workspace settings after being enabled
Actual Result:
Rules row is not highlighted like any other feature in the workspace settings after being enabled
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6995402_1762377753774.Rules.1.mp4
Please re-state the problem that we are trying to solve in this issue.
WS settings - Rules are not highlighted in workspace setting after enabling the More features
What is the root cause of that problem?
The problem is that pendingFields may have fields that are not included in currentFeatureStates, which may result in a situation like this one, where, when areRulesEnabled is enabled, eReceipt is also added to pendingFields, which is also added to setFeatureStates and set as setHighlightedFeature, even though it should not be in the list at all:
What changes do you think we should make in order to solve the problem?
Add a check to see if the key exists, and if not, do nothing:
if(!(keyincurrentFeatureStates)){return;}
What alternative solutions did you explore? (Optional)
If it is possible that two elements may appear at once after a single action, then we need to convert this from a string to an array of strings and, accordingly, all the places that currently work with it:
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]WS settings - Rules are not highlighted in workspace setting after enabling the More features[/-][+][$250] WS settings - Rules are not highlighted in workspace setting after enabling the More features[/+]on Nov 7, 2025
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 5, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Eskalifer1 commentedon Nov 5, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
WS settings - Rules are not highlighted in workspace setting after enabling the More features
What is the root cause of that problem?
The problem is that pendingFields may have fields that are not included in currentFeatureStates, which may result in a situation like this one, where, when areRulesEnabled is enabled, eReceipt is also added to pendingFields, which is also added to setFeatureStates and set as setHighlightedFeature, even though it should not be in the list at all:
App/src/pages/workspace/WorkspaceInitialPage.tsx
Lines 385 to 409 in 3bb02d9
What changes do you think we should make in order to solve the problem?
Add a check to see if the key exists, and if not, do nothing:
What alternative solutions did you explore? (Optional)
If it is possible that two elements may appear at once after a single action, then we need to convert this from a string to an array of strings and, accordingly, all the places that currently work with it:
App/src/pages/workspace/WorkspaceInitialPage.tsx
Line 192 in 3bb02d9
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]WS settings - Rules are not highlighted in workspace setting after enabling the More features[/-][+][$250] WS settings - Rules are not highlighted in workspace setting after enabling the More features[/+]melvin-bot commentedon Nov 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021986825627306320563
melvin-bot commentedon Nov 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)daledah commentedon Nov 7, 2025
i can't reproduce this bug
lydiabarclay commentedon Nov 7, 2025
I can repro
2025-11-07_08-42-13.mp4
shubham1206agra commentedon Nov 9, 2025
@Eskalifer1's proposal looks good to me.
🎀 👀 🎀 C+ reviewed
18 remaining items
melvin-bot commentedon Dec 9, 2025
This issue has not been updated in over 15 days. @mollfpr, @shubham1206agra, @Eskalifer1, @lydiabarclay eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
lydiabarclay commentedon Dec 12, 2025
Still waiting on bz checklist from @shubham1206agra
shubham1206agra commentedon Dec 15, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/40650/changes#r2618358361
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/579448
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-8e49-a05d-743e-339a33584984garrettmknight commentedon Apr 2, 2026
$250 approved for @shubham1206agra