Skip to content

[Due for payment 2025-12-25] [$250] “Hidden” displayed on confirmation page instead of account email after going online #74439

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.45-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #71330
Email or phone of affected tester (no customers): any new gmail account
Issue reported by: Applause Internal Team
Device used: Mac / Safari
App Component: Other

Action Performed:

  1. Log in with a new account.
  2. Go offline.
  3. Start a chat with any other account.
  4. Click + → Pay.
  5. Enter an amount and click Continue.
  6. Click Pay, then choose Mark as Paid or Personal Bank Account.
  7. Validate that the selected account is displayed.
  8. Go online.
  9. Input the correct magic code.

Expected Result:

The account validation modal should close, the confirmation page should display, and the email of the account to which the payment is intended should be shown.

Actual Result:

The confirmation page displays “Hidden” instead of the account email.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6995718_1762407150384.9_17_PM_2025-11-05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021986477573415920307
  • Upwork Job ID: 1986477573415920307
  • Last Price Increase: 2025-12-04
  • Automatic offers:
    • situchan | Reviewer | 109728505
    • apeyada | Contributor | 109728507
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 6, 2025
  2. melvin-bot commented on Nov 6, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 6, 2025
  4. changed the title [-]“Hidden” displayed on confirmation page instead of account email after going online[/-] [+][$250] “Hidden” displayed on confirmation page instead of account email after going online[/+] on Nov 6, 2025
  5. melvin-bot commented on Nov 6, 2025

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 6, 2025
  7. melvin-bot commented on Nov 6, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  8. moved this to Tracking in #expensify-bugson Nov 6, 2025
  9. moved this from Tracking to Bugs and Follow Up Issues in #expensify-bugson Nov 6, 2025
  10. tuseefahmed786 commented on Nov 7, 2025

    @tuseefahmed786

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    “Hidden” displayed on confirmation page instead of account email after going online.

    What is the root cause of that problem?

    When creating participants from a chat report, getMoneyRequestParticipantsFromReport(): only stores {accountID, selected: true} and does not preserve the login property.

    The login exists in allPersonalDetails (from optimistic personal details created when starting the chat), but it isn't saved in the participant object. Later, when the confirmation page tries to display the participant, it can't find the login and shows "Hidden".

    What changes do you think we should make in order to solve the problem?

    Preserve login and displayName from allPersonalDetails when creating participant objects in getMoneyRequestParticipantsFromReport():

    // Change from:
    participants = chatReportOtherParticipants.map((accountID) => ({accountID, selected: true}));
    
    // To:
    participants = chatReportOtherParticipants.map((accountID) => {
        const personalDetail = allPersonalDetails?.[accountID];
        return {
            accountID,
            login: personalDetail?.login,
            displayName: personalDetail?.displayName,
            selected: true,
        };
    });

    This ensures the login is stored in the transaction participant object and available when the confirmation page displays it.

    Alternative solutions explored

    None. This fix preserves data at creation time, which is the most straightforward solution.

  11. IjaazA commented on Nov 7, 2025

    @IjaazA
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-11-10 03:55:11 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a user starts a payment flow while offline, selects a payment method (Mark as Paid or Personal Bank Account), and then goes online, the confirmation page displays "Hidden" instead of the account email for the recipient.

    What is the root cause of that problem?

    The root cause is in the getParticipantsOption function in src/libs/OptionsListUtils/index.ts. When personal details are not loaded (which happens when going from offline to online), the function attempts to get the display name using getDisplayNameOrDefault. However, when detail (personal details) is undefined and the default value passed to getDisplayNameOrDefault is empty or not properly handled, the function falls back to "Hidden" instead of using the participant.login value that should be available.

    Specific issue:

    In getParticipantsOption (line 360-392 of OptionsListUtils/index.ts):

    • When detail is undefined (personal details not loaded), the function calls getDisplayNameOrDefault(detail, login || participant.text)
    • If login is empty (which shouldn't happen if participant.login exists, but can occur during the transition from offline to online), getDisplayNameOrDefault will return "Hidden" as the fallback
    • The function doesn't properly handle the case where personal details are not yet loaded but participant.login is available

    The issue occurs because:

    1. When offline, the user selects a participant and the transaction is created with participant.login stored
    2. When going online, the participants memo in IOURequestStepConfirmation.tsx is recalculated
    3. At this moment, personal details might not have been fetched yet from the server
    4. getParticipantsOption is called with detail as undefined and tries to get the display name
    5. Since detail is undefined, it falls back to using getDisplayNameOrDefault with the login, but if the login handling isn't correct, it returns "Hidden"

    What changes do you think we should make in order to solve the problem?

    The solution is to modify getParticipantsOption to properly handle the case when personal details are not loaded. When detail is undefined, we should use login (which should be participant.login) directly as the display name, formatted appropriately, before falling back to "Hidden".

    Specific code changes:

    In src/libs/OptionsListUtils/index.ts, modify the displayName calculation in getParticipantsOption:

    Before:

    const displayName = participant?.displayName || formatPhoneNumber(getDisplayNameOrDefault(detail, login || participant.text));

    After:

    const displayName =
        participant?.displayName ||
        (detail
            ? formatPhoneNumber(getDisplayNameOrDefault(detail, login || participant.text))
            : login || participant.text
              ? formatPhoneNumber(login || participant.text || '')
              : formatPhoneNumber(getDisplayNameOrDefault(undefined, '', true)));

    Explanation:

    • If participant.displayName exists, use it (highest priority)
    • If detail exists (personal details are loaded), use the existing logic with getDisplayNameOrDefault
    • If detail is undefined (personal details not loaded), check if login or participant.text exists:
      • If yes, format and use it directly (this ensures the account email is shown)
      • If no, fall back to "Hidden" via getDisplayNameOrDefault

    This ensures that when personal details are not yet loaded but participant.login is available (which should be the case when the transaction was created offline), the account email is displayed instead of "Hidden".

    What alternatives did you explore?

    1. Wait for personal details to load before displaying the confirmation page:
      • We could add a loading state that waits for personal details to be fetched before showing the confirmation page
      • Rejected because: This would create a poor user experience with unnecessary loading delays, and the login information is already available in the participant object
  12. 44 remaining items

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 18, 2025
  14. changed the title [-][$250] “Hidden” displayed on confirmation page instead of account email after going online[/-] [+][Due for payment 2025-12-25] [$250] “Hidden” displayed on confirmation page instead of account email after going online[/+] on Dec 18, 2025
  15. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.81-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-25. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    @situchan @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. sakluger commented on Dec 30, 2025

    @sakluger
    Contributor

    Payment Summary

    Contributor: @apeyada paid $250 via Upwork
    Contributor+: @situchan paid $250 via Upwork

  19. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions