You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-25] [$250] “Hidden” displayed on confirmation page instead of account email after going online #74439
Version Number: v9.2.45-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#71330 Email or phone of affected tester (no customers): any new gmail account Issue reported by: Applause Internal Team Device used: Mac / Safari App Component: Other
Action Performed:
Log in with a new account.
Go offline.
Start a chat with any other account.
Click + → Pay.
Enter an amount and click Continue.
Click Pay, then choose Mark as Paid or Personal Bank Account.
Validate that the selected account is displayed.
Go online.
Input the correct magic code.
Expected Result:
The account validation modal should close, the confirmation page should display, and the email of the account to which the payment is intended should be shown.
Actual Result:
The confirmation page displays “Hidden” instead of the account email.
changed the title [-]“Hidden” displayed on confirmation page instead of account email after going online[/-][+][$250] “Hidden” displayed on confirmation page instead of account email after going online[/+]on Nov 6, 2025
Please re-state the problem that we are trying to solve in this issue.
“Hidden” displayed on confirmation page instead of account email after going online.
What is the root cause of that problem?
When creating participants from a chat report, getMoneyRequestParticipantsFromReport(): only stores {accountID, selected: true} and does not preserve the login property.
The login exists in allPersonalDetails (from optimistic personal details created when starting the chat), but it isn't saved in the participant object. Later, when the confirmation page tries to display the participant, it can't find the login and shows "Hidden".
What changes do you think we should make in order to solve the problem?
🚨 Edited by proposal-police: This proposal was edited at 2025-11-10 03:55:11 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user starts a payment flow while offline, selects a payment method (Mark as Paid or Personal Bank Account), and then goes online, the confirmation page displays "Hidden" instead of the account email for the recipient.
What is the root cause of that problem?
The root cause is in the getParticipantsOption function in src/libs/OptionsListUtils/index.ts. When personal details are not loaded (which happens when going from offline to online), the function attempts to get the display name using getDisplayNameOrDefault. However, when detail (personal details) is undefined and the default value passed to getDisplayNameOrDefault is empty or not properly handled, the function falls back to "Hidden" instead of using the participant.login value that should be available.
Specific issue:
In getParticipantsOption (line 360-392 of OptionsListUtils/index.ts):
When detail is undefined (personal details not loaded), the function calls getDisplayNameOrDefault(detail, login || participant.text)
If login is empty (which shouldn't happen if participant.login exists, but can occur during the transition from offline to online), getDisplayNameOrDefault will return "Hidden" as the fallback
The function doesn't properly handle the case where personal details are not yet loaded but participant.login is available
The issue occurs because:
When offline, the user selects a participant and the transaction is created with participant.login stored
When going online, the participants memo in IOURequestStepConfirmation.tsx is recalculated
At this moment, personal details might not have been fetched yet from the server
getParticipantsOption is called with detail as undefined and tries to get the display name
Since detail is undefined, it falls back to using getDisplayNameOrDefault with the login, but if the login handling isn't correct, it returns "Hidden"
What changes do you think we should make in order to solve the problem?
The solution is to modify getParticipantsOption to properly handle the case when personal details are not loaded. When detail is undefined, we should use login (which should be participant.login) directly as the display name, formatted appropriately, before falling back to "Hidden".
Specific code changes:
In src/libs/OptionsListUtils/index.ts, modify the displayName calculation in getParticipantsOption:
If participant.displayName exists, use it (highest priority)
If detail exists (personal details are loaded), use the existing logic with getDisplayNameOrDefault
If detail is undefined (personal details not loaded), check if login or participant.text exists:
If yes, format and use it directly (this ensures the account email is shown)
If no, fall back to "Hidden" via getDisplayNameOrDefault
This ensures that when personal details are not yet loaded but participant.login is available (which should be the case when the transaction was created offline), the account email is displayed instead of "Hidden".
What alternatives did you explore?
Wait for personal details to load before displaying the confirmation page:
We could add a loading state that waits for personal details to be fetched before showing the confirmation page
Rejected because: This would create a poor user experience with unnecessary loading delays, and the login information is already available in the participant object
changed the title [-][$250] “Hidden” displayed on confirmation page instead of account email after going online[/-][+][Due for payment 2025-12-25] [$250] “Hidden” displayed on confirmation page instead of account email after going online[/+]on Dec 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.81-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@situchan@sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Nov 6, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]“Hidden” displayed on confirmation page instead of account email after going online[/-][+][$250] “Hidden” displayed on confirmation page instead of account email after going online[/+]melvin-bot commentedon Nov 6, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021986477573415920307
melvin-bot commentedon Nov 6, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)tuseefahmed786 commentedon Nov 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
“Hidden” displayed on confirmation page instead of account email after going online.
What is the root cause of that problem?
When creating participants from a chat report, getMoneyRequestParticipantsFromReport(): only stores
{accountID, selected: true}and does not preserve theloginproperty.The login exists in
allPersonalDetails(from optimistic personal details created when starting the chat), but it isn't saved in the participant object. Later, when the confirmation page tries to display the participant, it can't find the login and shows "Hidden".What changes do you think we should make in order to solve the problem?
Preserve
loginanddisplayNamefromallPersonalDetailswhen creating participant objects in getMoneyRequestParticipantsFromReport():This ensures the login is stored in the transaction participant object and available when the confirmation page displays it.
Alternative solutions explored
None. This fix preserves data at creation time, which is the most straightforward solution.
IjaazA commentedon Nov 7, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-10 03:55:11 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user starts a payment flow while offline, selects a payment method (Mark as Paid or Personal Bank Account), and then goes online, the confirmation page displays "Hidden" instead of the account email for the recipient.
What is the root cause of that problem?
The root cause is in the
getParticipantsOptionfunction insrc/libs/OptionsListUtils/index.ts. When personal details are not loaded (which happens when going from offline to online), the function attempts to get the display name usinggetDisplayNameOrDefault. However, whendetail(personal details) isundefinedand the default value passed togetDisplayNameOrDefaultis empty or not properly handled, the function falls back to "Hidden" instead of using theparticipant.loginvalue that should be available.Specific issue:
In
getParticipantsOption(line 360-392 ofOptionsListUtils/index.ts):detailisundefined(personal details not loaded), the function callsgetDisplayNameOrDefault(detail, login || participant.text)loginis empty (which shouldn't happen ifparticipant.loginexists, but can occur during the transition from offline to online),getDisplayNameOrDefaultwill return "Hidden" as the fallbackparticipant.loginis availableThe issue occurs because:
participant.loginstoredparticipantsmemo inIOURequestStepConfirmation.tsxis recalculatedgetParticipantsOptionis called withdetailasundefinedand tries to get the display namedetailisundefined, it falls back to usinggetDisplayNameOrDefaultwith the login, but if the login handling isn't correct, it returns "Hidden"What changes do you think we should make in order to solve the problem?
The solution is to modify
getParticipantsOptionto properly handle the case when personal details are not loaded. Whendetailisundefined, we should uselogin(which should beparticipant.login) directly as the display name, formatted appropriately, before falling back to "Hidden".Specific code changes:
In
src/libs/OptionsListUtils/index.ts, modify thedisplayNamecalculation ingetParticipantsOption:Before:
After:
Explanation:
participant.displayNameexists, use it (highest priority)detailexists (personal details are loaded), use the existing logic withgetDisplayNameOrDefaultdetailisundefined(personal details not loaded), check ifloginorparticipant.textexists:getDisplayNameOrDefaultThis ensures that when personal details are not yet loaded but
participant.loginis available (which should be the case when the transaction was created offline), the account email is displayed instead of "Hidden".What alternatives did you explore?
44 remaining items
[-][$250] “Hidden” displayed on confirmation page instead of account email after going online[/-][+][Due for payment 2025-12-25] [$250] “Hidden” displayed on confirmation page instead of account email after going online[/+]melvin-bot commentedon Dec 18, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.81-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 18, 2025
@situchan @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
sakluger commentedon Dec 30, 2025
Payment Summary
Contributor: @apeyada paid $250 via Upwork
Contributor+: @situchan paid $250 via Upwork