Repository navigation
[HOLD for payment 2022-03-17] [HOLD for payment 2022-03-09] Feature Request: Add image preview placeholder while uploading images/Videos - Reported by @mdneyazahmad #7463
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open app
- Go to chat on slower network
- Upload image and note the loading
Expected Result:
Image preview should display while uploading images
Actual Result:
No Image preview displayed while uploading images
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.33-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @mdneyazahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642530762139600
Activity
MelvinBot commentedon Jan 31, 2022
Triggered auto assignment to @JmillsExpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.[-]Feature Request: Add image preview placeholder while uploading images - Reported by @mdneyazahmad[/-][+]Feature Request: Add image preview placeholder while uploading images/Videos - Reported by @mdneyazahmad[/+]JmillsExpensify commentedon Feb 1, 2022
I agree that from a best practice perspective, we should be providing a local preview of the receipt on upload. That said, I think we want to be careful on how we implement this, so we'll want to make sure any proposals are discussed here and in Slack. I'll go ahead and create a job in the meantime though!
JmillsExpensify commentedon Feb 1, 2022
Job is here: https://www.upwork.com/jobs/~01e1ba3f717ab3ff5d
MelvinBot commentedon Feb 1, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
Exported)56 remaining items
[-][HOLD for payment 2022-03-09] Feature Request: Add image preview placeholder while uploading images/Videos - Reported by @mdneyazahmad[/-][+][HOLD for payment 2022-03-17] [HOLD for payment 2022-03-09] Feature Request: Add image preview placeholder while uploading images/Videos - Reported by @mdneyazahmad[/+]botify commentedon Mar 10, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.41-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-03-17. 🎊
JmillsExpensify commentedon Mar 10, 2022
Ah interesting, it looks like Jules and I aligned payment to the first PR, not the second one.
okansahin commentedon Mar 10, 2022
Ah, may it was my fault. I asked for a regression period from @Julesssss
I thought it was production deploy but now I see it is staging. I'm sorry about that. I follow the issue to fix if any trouble.
@Julesssss I am really sorry to make confused you too.
JmillsExpensify commentedon Mar 11, 2022
No worries! I'm going to go ahead and update the issue with the updated date so that we don't forget. I'll go ahead and close it out if we get through the regression period and no issues.
JmillsExpensify commentedon Mar 23, 2022
Circling back to this issue to formally close us out.
mdneyazahmad commentedon Mar 24, 2022
@JmillsExpensify I noticed that the job for this issue on Upwork is not closed. Thank you
JmillsExpensify commentedon Mar 25, 2022
Sorry can you help clarify?
JmillsExpensify commentedon Mar 25, 2022
Oh I think I see what you mean! Looks like I didn't close out your specific contract, so I've done that now. Sorry for missing earlier.