You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-23] Expense - No message that expense is on hold when split expense offline #74682
Version Number: v9.2.47-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory Email or phone of affected tester (no customers):gocemate+b2155031@gmail.com Issue reported by: Applause Internal Team Device used: Lenovo 80ES / Windows 10 Pro App Component: Chat Report View
Action Performed:
Create expense in workspace chat
Open expense thread
Go offline
Hold the expense
Split the expense
Take a look at expenses
Expected Result:
There should be a system message that expenses are put on hold
Actual Result:
There is no system message that expenses are put on hold on report page
Please re-state the problem that we are trying to solve in this issue.
There is no system message that expenses are put on hold on report page
What is the root cause of that problem?
When holding the expense, we'll add the system message to the transaction thread report, and transaction thread actions are merged with iou report when it's a one transaction thread, so we can see it before splitting.
After splitting, it's not one transaction thread anymore, so we don't see it
What changes do you think we should make in order to solve the problem?
After splitting, we should move the actions from transaction report to iou report in here
Here's the sample code, it can be refactored during PR phase
if (firstIOU?.childReportID && iouReport?.reportID) {
const transactionThreadReport = allReportsList?.[`${ONYXKEYS.COLLECTION.REPORT}${firstIOU.childReportID}`];
const isOneThreadTransaction = isOneTransactionThread(transactionThreadReport ?? undefined, iouReport ?? undefined, firstIOU ?? undefined);
if (isOneThreadTransaction) {
const threadReportActions = getAllReportActions(firstIOU.childReportID);
const iouReportActionsToMove: Record<string, ReportAction> = {};
// Get all reportActions from thread report except the created action
Object.values(threadReportActions).forEach((action) => {
if (action && !isCreatedAction(action)) {
iouReportActionsToMove[action.reportActionID] = action;
}
});
// Move reportActions from thread report to iou report
if (Object.keys(iouReportActionsToMove).length > 0) {
optimisticData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport.reportID}`,
value: iouReportActionsToMove,
});
// Remove reportActions from thread report (except created action)
const threadReportActionsToRemove: Record<string, null> = {};
Object.keys(iouReportActionsToMove).forEach((reportActionID) => {
threadReportActionsToRemove[reportActionID] = null;
});
optimisticData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${firstIOU.childReportID}`,
value: threadReportActionsToRemove,
});
// Add failure data to revert the changes
failureData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport.reportID}`,
value: Object.keys(iouReportActionsToMove).reduce((acc, reportActionID) => {
acc[reportActionID] = null;
return acc;
}, {} as Record<string, null>),
});
failureData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${firstIOU.childReportID}`,
value: iouReportActionsToMove,
});
}
}
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - No message that expense is on hold when split expense offline[/-][+][$250] Expense - No message that expense is on hold when split expense offline[/+]on Nov 18, 2025
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA. I can't link this issue a PR, it's a missing edge case.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
NA
Test:
Open the app
Create expense in workspace chat
Open expense thread
Go offline
Hold the expense
Split the expense
Verify there is a system message that expenses are put on hold in each expense thread
changed the title [-][Due for payment 2026-01-23] [Due for payment 2026-01-20] [Due for payment 2026-01-16] [Due for payment 2026-01-15] [$250] Expense - No message that expense is on hold when split expense offline[/-][+][Due for payment 2026-01-23] Expense - No message that expense is on hold when split expense offline[/+]on Feb 3, 2026
Activity
melvin-bot commentedon Nov 10, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.paulnjs commentedon Nov 10, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no system message that expenses are put on hold on report page
What is the root cause of that problem?
When holding the expense, we'll add the system message to the transaction thread report, and transaction thread actions are merged with iou report when it's a one transaction thread, so we can see it before splitting.
After splitting, it's not one transaction thread anymore, so we don't see it
What changes do you think we should make in order to solve the problem?
After splitting, we should move the actions from transaction report to iou report in here
Here's the sample code, it can be refactored during PR phase
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Expense - No message that expense is on hold when split expense offline[/-][+][$250] Expense - No message that expense is on hold when split expense offline[/+]melvin-bot commentedon Nov 18, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021990613260098691397
melvin-bot commentedon Nov 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (
External)eh2077 commentedon Nov 18, 2025
I'll review this tmr
58 remaining items
eh2077 commentedon Feb 2, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA. I can't link this issue a PR, it's a missing edge case.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
NA
Test:
Do we agree 👍 or 👎
eh2077 commentedon Feb 2, 2026
@bfitzexpensify this is ready for payment, thanks 🙇
note: this first PR was reverted because of BE was not ready, the v2 PR just reapply reverted PR again, so there's no regression happened.
bfitzexpensify commentedon Feb 2, 2026
Payment summary
bfitzexpensify commentedon Feb 2, 2026
I'm heading OOO until Feb 17th - @strepanier03, as the other assignee here, mind creating the Upwork job and completing payment for @paulnjs
[-][Due for payment 2026-01-23] [Due for payment 2026-01-20] [Due for payment 2026-01-16] [Due for payment 2026-01-15] [$250] Expense - No message that expense is on hold when split expense offline[/-][+][Due for payment 2026-01-23] Expense - No message that expense is on hold when split expense offline[/+]strepanier03 commentedon Feb 6, 2026
paid and closed the contract for @paulnjs and the payment summary is above for the newdot request for @eh2077.
JmillsExpensify commentedon Feb 21, 2026
$250 approved for @eh2077