Skip to content

[Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted #74708

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory #72941
Email or phone of affected tester (no customers): sodjnosdjsdosjod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Click Submit.
  5. Create another expense.
  6. Do not click Submit.
  7. Go to Reports > Reports.
  8. Expand both report rows.
  9. Select one of the expenses from submitted report (from Step 4) and select the unsubmitted expense (from Step 6).
  10. Click dropdown button.

Expected Result:

Dropdown menu will not show Submit button because one of the selected expenses is already submitted.

Actual Result:

Dropdown menu still shows Submit button when one of the selected expenses is already submitted.

This issue does not happen if user selects all expenses from both reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2025
  2. melvin-bot commented on Nov 10, 2025

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. samranahm commented on Nov 10, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted

    What is the root cause of that problem?

    The shouldShowSubmitOption logic in SearchPage.tsx is missing the areSelectedTransactionsIncludedInReports check. Without this check, when selecting expenses from different reports (one submitted, one draft/open), the code fails to detect the conflicting states and incorrectly shows the Submit button. The Approve button already has this check, but Submit missing it.

    What changes do you think we should make in order to solve the problem?

    we should check areSelectedTransactionsIncludedInReports && in shouldShowSubmitOption

    like this

    const shouldShowSubmitOption =
        !isOffline &&
        areSelectedTransactionsIncludedInReports &&
        (selectedReports.length
            ? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
            : selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));

    here

    const shouldShowSubmitOption =
    !isOffline &&
    (selectedReports.length
    ? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
    : selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. trjExpensify commented on Nov 10, 2025

    @trjExpensify
    Contributor

    @nkdengineer this is from your PR. Can you address it? CC: @hoangzinh @mjasikowski

  5. nkdengineer commented on Nov 10, 2025

    @nkdengineer
    Contributor

    @trjExpensify please assign me, I will raise the follow up soon.

  6. CortneyOfstad commented on Nov 10, 2025

    @CortneyOfstad
    Contributor

    done!

  7. nkdengineer commented on Nov 11, 2025

    @nkdengineer
    Contributor

    @hoangzinh The PR is ready for review.

  8. hoangzinh commented on Nov 11, 2025

    @hoangzinh
    Contributor

    Thanks. I will try to review it today

  9. melvin-bot commented on Nov 11, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 14, 2025
  11. changed the title [-]Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted[/-] [+][Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted[/+] on Nov 14, 2025
  12. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.58-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-21. 🎊

    For reference, here are some details about the assignees on this issue:

    • @nkdengineer requires payment through NewDot Manual Requests
  14. melvin-bot commented on Nov 14, 2025

    @melvin-bot

    @inimaga @CortneyOfstad @nkdengineer The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. CortneyOfstad commented on Nov 17, 2025

    @CortneyOfstad
    Contributor

    @nkdengineer can you complete the checklist before payment date so there is no delay? Thanks!

  16. hoangzinh commented on Nov 18, 2025

    @hoangzinh
    Contributor

    @CortneyOfstad, we can close this issue as it's a quick follow-up issue of our previous PR

  17. nkdengineer commented on Nov 19, 2025

    @nkdengineer
    Contributor

    Yes, it's a quick follow-up. No need the payment here.

  18. CortneyOfstad commented on Nov 20, 2025

    @CortneyOfstad
    Contributor

    Sounds good! Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions