You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted #74708
Version Number: 9.2.48-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory #72941 Email or phone of affected tester (no customers):sodjnosdjsdosjod@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Click Submit.
Create another expense.
Do not click Submit.
Go to Reports > Reports.
Expand both report rows.
Select one of the expenses from submitted report (from Step 4) and select the unsubmitted expense (from Step 6).
Click dropdown button.
Expected Result:
Dropdown menu will not show Submit button because one of the selected expenses is already submitted.
Actual Result:
Dropdown menu still shows Submit button when one of the selected expenses is already submitted.
This issue does not happen if user selects all expenses from both reports.
Please re-state the problem that we are trying to solve in this issue.
Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted
What is the root cause of that problem?
The shouldShowSubmitOption logic in SearchPage.tsx is missing the areSelectedTransactionsIncludedInReports check. Without this check, when selecting expenses from different reports (one submitted, one draft/open), the code fails to detect the conflicting states and incorrectly shows the Submit button. The Approve button already has this check, but Submit missing it.
What changes do you think we should make in order to solve the problem?
we should check areSelectedTransactionsIncludedInReports && in shouldShowSubmitOption
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted[/-][+][Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted[/+]on Nov 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.58-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@inimaga@CortneyOfstad@nkdengineer The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Nov 10, 2025
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Nov 10, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted
What is the root cause of that problem?
The
shouldShowSubmitOptionlogic inSearchPage.tsxis missing theareSelectedTransactionsIncludedInReportscheck. Without this check, when selecting expenses from different reports (one submitted, one draft/open), the code fails to detect the conflicting states and incorrectly shows the Submit button. The Approve button already has this check, but Submit missing it.What changes do you think we should make in order to solve the problem?
we should check
areSelectedTransactionsIncludedInReports &&inshouldShowSubmitOptionlike this
here
App/src/pages/Search/SearchPage.tsx
Lines 438 to 443 in 23b260f
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
trjExpensify commentedon Nov 10, 2025
@nkdengineer this is from your PR. Can you address it? CC: @hoangzinh @mjasikowski
nkdengineer commentedon Nov 10, 2025
@trjExpensify please assign me, I will raise the follow up soon.
CortneyOfstad commentedon Nov 10, 2025
done!
nkdengineer commentedon Nov 11, 2025
@hoangzinh The PR is ready for review.
hoangzinh commentedon Nov 11, 2025
Thanks. I will try to review it today
melvin-bot commentedon Nov 11, 2025
Triggered auto assignment to @inimaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
[-]Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted[/-][+][Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted[/+]melvin-bot commentedon Nov 14, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 14, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.58-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-11-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 14, 2025
@inimaga @CortneyOfstad @nkdengineer The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
CortneyOfstad commentedon Nov 17, 2025
@nkdengineer can you complete the checklist before payment date so there is no delay? Thanks!
hoangzinh commentedon Nov 18, 2025
@CortneyOfstad, we can close this issue as it's a quick follow-up issue of our previous PR
nkdengineer commentedon Nov 19, 2025
Yes, it's a quick follow-up. No need the payment here.
CortneyOfstad commentedon Nov 20, 2025
Sounds good! Thanks guys!