Repository navigation
[HOLD for payment 2022-02-16] Tooltip text and arrow appears in different positions - reported by @sobitneupane #7481
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Create an account using a very long email address. (pro tip: use an email with a uuid like mylongemail+e66b2bfb-2bd8-4372-93f6-561ad20578ef@gmail.com
- Create two other accounts with short first names
- From a fourth account, create a group chat will all three accounts from the previous two steps.
- Send a message in the group chat.
- Open the search page and search for the group chat.
- Hover over the long email address
Expected Result:
The tooltip and arrow are correctly positioned.
Actual Result:
The tooltip content is misplaced from the arrow.
Workaround:
Yes, this is a design issue.
Platform:
Where is this issue occurring?
- Web
- Desktop App
Version Number: 1.1.33-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643208301483100
Activity
MelvinBot commentedon Jan 31, 2022
Triggered auto assignment to @mountiny (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Jan 31, 2022
Triggered auto assignment to @stephanieelliott (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.sobitneupane commentedon Jan 31, 2022
@mountiny In Actions Performed Section, there are two sets of actions which is bit confusing. The reason for the first set of actions is a bug in src/styles/getTooltipStyles. And the second set of actions is a different design issue. I think it is better to have two different issues for those different set of actions. Just a thought.
mountiny commentedon Jan 31, 2022
@sobitneupane You are right, I have updated it mostly to keep track and potentially merge it with this issue as they both seem quite straightforward. But for the sake of granularity, I will create a new issue for this 👍
sobitneupane commentedon Jan 31, 2022
Reason
Function computeHorizontalShift shifts the element without considering manualShiftHorizontal.
Proposal
Replacing this line
App/src/styles/getTooltipStyles.js
Line 31 in 2cdb7c3
by
stephanieelliott commentedon Jan 31, 2022
@mountiny is this ready to be posted to Upwork, or do we plan to sit on this for a while?
mountiny commentedon Jan 31, 2022
@stephanieelliott This can be Exported. Sorry for the confusion. I have created a separate issue for the other problem to keep them both self-contained! This is good to go, thank you for confirming 😊
stephanieelliott commentedon Jan 31, 2022
Cool, thanks @mountiny!
Posted to Upwork: https://www.upwork.com/jobs/~01c93161a50cdfec48
17 remaining items
stephanieelliott commentedon Feb 8, 2022
PR is on staging!
botify commentedon Feb 9, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.37-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-02-16. 🎊
[-]Tooltip text and arrow appears in different positions - reported by @sobitneupane[/-][+][HOLD for payment 2022-02-16] Tooltip text and arrow appears in different positions - reported by @sobitneupane[/+]sobitneupane commentedon Feb 18, 2022
Waiting for payment.
mountiny commentedon Feb 18, 2022
cc @stephanieelliott. Thank you! 🙇
stephanieelliott commentedon Feb 18, 2022
Oop, thanks for the bump! All paid up 😃
sobitneupane commentedon Feb 19, 2022
@stephanieelliott I am also the reporter of this issue. I am paid for the solution but not for reporting.
mountiny commentedon Feb 19, 2022
Gonna reopen this issue just so we do not lose track. Sorry for any inconvenience @sobitneupane 🙏
stephanieelliott commentedon Feb 21, 2022
Oop, sorry for the wait, reporting bonus paid @sobitneupane!