Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.55-3
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #74407
Email or phone of affected tester (no customers): Slottwo1@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Go to https://staging.new.expensify.com/home
- Open workpace chat
- Create an expense for -₹10
- Tap more - split
- Tap add split - add 2
- Tap split even
- Tap save
- Open one of the split expense
- Tap more - edit split
- Tap add split - add 1
- Enter value 0.01 and save
- Note the above 4 splits
Expected Result:
In edit split of negative amount, after adding an split unexpected error must not be shown in all split expenses
Actual Result:
In edit split of negative amount, after adding an split unexpected error is shown in all split expenses
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug7001884_1762966476260.Screenrecorder-2025-11-12-22-17-11-785.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021988906815775901184
- Upwork Job ID: 1988906815775901184
- Last Price Increase: 2025-11-20
- Automatic offers:
- QichenZhu | Reviewer | 109554834
Issue Owner
Current Issue Owner: @QichenZhuMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Nov 12, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 12, 2025
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 12, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 12, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
11 remaining items
Gonals commentedon Nov 18, 2025
I think we should fix it in the frontend so we only allow splits that "make sense" (properly add up).
trjExpensify commentedon Nov 18, 2025
CC'ing @garrettmknight @lakchote @ikevin127 for vis as they're working on split evenly and the like.
lakchote commentedon Nov 19, 2025
In my opinion, we should reject it in the FE.
I do agree with @Gonals, I also think we should fix it in the frontend. cc @ikevin127
ikevin127 commentedon Nov 19, 2025
ℹ️ Just reproduced the issue and I have to note that it isn't caused by my recent
Make splits evenPR, it only surfaced / was found because testing was done around the PRs logic.This issue is caused by the
Edit splitsflow which is uncoupled from theMake splits evenlogic on purpose, see issue OP description mentioning:instead the issue is reproducible even without the action of
Make splits even, here's the video proof:MacOS: Chrome
Screen.Recording.2025-11-19.at.13.40.28.mov
🔄 Because of this, it definitely shouldn't count as a regression of the
Make splits evenPR, but instead an issue which existed before the PR, an edge case missed probably during theEdit splitsimplementation with negative amounts.Now, I'd be happy to raise a PR and fix the issue for the $250 bounty, but I'm also cool with opening it up for proposals if you feel that's fair, please let me know! 🙌
Important
Also I must note that regardless of who's going to work on this - we should clarify that dismissing the error via ❌ button only actually removes the extra split, for the previously existing splits the error is removed and they remain 👈 maybe we want to make sure we only pass the error to the extra split (which will be removed when error dismissed) - this could be part of the scope even if we're going to block the creation of the extra split.
QichenZhu commentedon Nov 20, 2025
Yeah, I wouldn't consider this a regression from that PR.
Sounds good to me.
It's been open for proposals for a week, but no takers so far.
melvin-bot commentedon Nov 20, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
lakchote commentedon Nov 21, 2025
cc @ZhenjaHorbach could you please fix it? This is an edge case coming from the Edit Splits feature.
melvin-bot commentedon Nov 21, 2025
📣 @QichenZhu 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
ZhenjaHorbach commentedon Nov 21, 2025
We already have a PR for supporting negative amounts in split flow
So we can just add HOLD here
#74189
Or we can close this issue
Since we already fixed this in the PR
trjExpensify commentedon Nov 24, 2025
I'm going to close it, no need to have two.