Skip to content

[$250] Expense - In edit split of negative amount, after adding an split unexpected error #74972

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.55-3
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #74407
Email or phone of affected tester (no customers): Slottwo1@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Open workpace chat
  3. Create an expense for -₹10
  4. Tap more - split
  5. Tap add split - add 2
  6. Tap split even
  7. Tap save
  8. Open one of the split expense
  9. Tap more - edit split
  10. Tap add split - add 1
  11. Enter value 0.01 and save
  12. Note the above 4 splits

Expected Result:

In edit split of negative amount, after adding an split unexpected error must not be shown in all split expenses

Actual Result:

In edit split of negative amount, after adding an split unexpected error is shown in all split expenses

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7001884_1762966476260.Screenrecorder-2025-11-12-22-17-11-785.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021988906815775901184
  • Upwork Job ID: 1988906815775901184
  • Last Price Increase: 2025-11-20
  • Automatic offers:
    • QichenZhu | Reviewer | 109554834
Issue OwnerCurrent Issue Owner: @QichenZhu

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 12, 2025
  2. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 12, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 13, 2025
  7. 11 remaining items

  8. Gonals commented on Nov 18, 2025

    @Gonals
    Contributor

    I think we should fix it in the frontend so we only allow splits that "make sense" (properly add up).

  9. trjExpensify commented on Nov 18, 2025

    @trjExpensify
    Contributor

    CC'ing @garrettmknight @lakchote @ikevin127 for vis as they're working on split evenly and the like.

  10. lakchote commented on Nov 19, 2025

    @lakchote
    Contributor

    Should we reject it on the FE like we do for positive splits, or should we allow it on the BE?

    In my opinion, we should reject it in the FE.

    I do agree with @Gonals, I also think we should fix it in the frontend. cc @ikevin127

  11. ikevin127 commented on Nov 19, 2025

    @ikevin127
    Contributor

    ℹ️ Just reproduced the issue and I have to note that it isn't caused by my recent Make splits even PR, it only surfaced / was found because testing was done around the PRs logic.

    This issue is caused by the Edit splits flow which is uncoupled from the Make splits even logic on purpose, see issue OP description mentioning:

    The 'Split evenly' button will not be available when editing splits to avoid adding more logic to start

    instead the issue is reproducible even without the action of Make splits even, here's the video proof:

    MacOS: Chrome
    Screen.Recording.2025-11-19.at.13.40.28.mov

    🔄 Because of this, it definitely shouldn't count as a regression of the Make splits even PR, but instead an issue which existed before the PR, an edge case missed probably during the Edit splits implementation with negative amounts.

    Now, I'd be happy to raise a PR and fix the issue for the $250 bounty, but I'm also cool with opening it up for proposals if you feel that's fair, please let me know! 🙌

    Important

    Also I must note that regardless of who's going to work on this - we should clarify that dismissing the error via ❌ button only actually removes the extra split, for the previously existing splits the error is removed and they remain 👈 maybe we want to make sure we only pass the error to the extra split (which will be removed when error dismissed) - this could be part of the scope even if we're going to block the creation of the extra split.

  12. QichenZhu commented on Nov 20, 2025

    @QichenZhu
    Contributor

    ℹ️ Just reproduced the issue and I have to note that it isn't caused by my recent Make splits even PR, it only surfaced / was found because testing was done around the PRs logic.

    Yeah, I wouldn't consider this a regression from that PR.

    Now, I'd be happy to raise a PR and fix the issue for the $250 bounty,

    Sounds good to me.

    but I'm also cool with opening it up for proposals if you feel that's fair, please let me know! 🙌

    It's been open for proposals for a week, but no takers so far.

  13. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  14. lakchote commented on Nov 21, 2025

    @lakchote
    Contributor

    ℹ️ Just reproduced the issue and I have to note that it isn't caused by my recent Make splits even PR, it only surfaced / was found because testing was done around the PRs logic.

    This issue is caused by the Edit splits flow which is uncoupled from the Make splits even logic on purpose, see issue OP description mentioning:

    The 'Split evenly' button will not be available when editing splits to avoid adding more logic to start

    instead the issue is reproducible even without the action of Make splits even, here's the video proof:

    MacOS: Chrome
    Screen.Recording.2025-11-19.at.13.40.28.mov
    🔄 Because of this, it definitely shouldn't count as a regression of the Make splits even PR, but instead an issue which existed before the PR, an edge case missed probably during the Edit splits implementation with negative amounts.

    Now, I'd be happy to raise a PR and fix the issue for the $250 bounty, but I'm also cool with opening it up for proposals if you feel that's fair, please let me know! 🙌

    Important

    Also I must note that regardless of who's going to work on this - we should clarify that dismissing the error via ❌ button only actually removes the extra split, for the previously existing splits the error is removed and they remain 👈 maybe we want to make sure we only pass the error to the extra split (which will be removed when error dismissed) - this could be part of the scope even if we're going to block the creation of the extra split.

    cc @ZhenjaHorbach could you please fix it? This is an edge case coming from the Edit Splits feature.

  15. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 21, 2025
  16. melvin-bot commented on Nov 21, 2025

    @melvin-bot

    📣 @QichenZhu 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  17. ZhenjaHorbach commented on Nov 21, 2025

    @ZhenjaHorbach
    Contributor

    We already have a PR for supporting negative amounts in split flow
    So we can just add HOLD here
    #74189

    Or we can close this issue
    Since we already fixed this in the PR

    Image
  18. trjExpensify commented on Nov 24, 2025

    @trjExpensify
    Contributor

    I'm going to close it, no need to have two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions