Skip to content

[Due for payment 2025-11-20] Split - "Please enter a valid amount before continuing." error message persist #74975

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.55-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #74407
Email or phone of affected tester (no customers): gocemate+b2155178@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Create an expense for $10
  2. Select 'Split' from the 'More' menu for the expense
  3. Tap 'Add split' to create a 3rd split
  4. Tap 'Add split' to create a 4th split
  5. Click Save
  6. Verify error message is displayed
  7. Tap 'Make splits even'
  8. Verify the amounts of the split expenses are all $2.50

Expected Result:

The error message should disappear

Actual Result:

"Please enter a valid amount before continuing." error message persist even split amounts are equal

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7001908_1762967611181.Recording__6762.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 12, 2025
  2. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 12, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 12, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. samranahm commented on Nov 12, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Split - "Please enter a valid amount before continuing." error message persist

    What is the root cause of that problem?

    The error clearing useEffect in SplitExpensePage only monitored two dependencies

    • sumOfSplitExpenses - the total sum
    • draftTransaction?.comment?.splitExpenses?.length - the number of splits

    When "Make splits even" redistributes amounts evenly across existing splits, neither the sum nor the count changes.

    useEffect(() => {
    setErrorMessage('');
    }, [sumOfSplitExpenses, draftTransaction?.comment?.splitExpenses?.length]);

    What changes do you think we should make in order to solve the problem?

    We should include splitExpenses in deps array

    useEffect(() => {
        setErrorMessage('');
    }, [sumOfSplitExpenses, splitExpenses]);

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. 1 remaining item

  8. lakchote commented on Nov 13, 2025

    @lakchote
    Contributor

    @samranahm I've used your proposal here. I've raised a PR to save time and solve this with urgency.

  9. samranahm commented on Nov 13, 2025

    @samranahm
    Contributor

    @lakchote All good, glad my proposal helped fix the issue!

  10. lakchote commented on Nov 13, 2025

    @lakchote
    Contributor
  11. m-natarajan commented on Nov 13, 2025

    @m-natarajan

    Not reproduce, MacOS Monterey / Chrome, Web v9.2.57-3

    Screen.Recording.2025-11-13.at.15.08.38.mp4
  12. lakchote commented on Nov 13, 2025

    @lakchote
    Contributor

    Not reproducible, closing the issue.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 13, 2025
  14. changed the title [-]Split - "Please enter a valid amount before continuing." error message persist[/-] [+][Due for payment 2025-11-20] Split - "Please enter a valid amount before continuing." error message persist[/+] on Nov 13, 2025
  15. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.57-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-11-20. 🎊

  17. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    @lakchote @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions