Skip to content

[$250] Workspace - Admin becomes approver when dismiss error message for deleting approver #75020

Open

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.57-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check in Prod becourse of KI
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74710
Email or phone of affected tester (no customers): gocemate+b2155186@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. As an admin, create a workspace and invite user A
  3. Enable approval and change approver to user A
  4. Create and submit a manual expense as an admin in workspace chat
  5. Remove user A
  6. Dismiss the error message
  7. Go to Workflow> Add approvals

Expected Result:

After dismissing the error message Approver A should still be approver

Actual Result:

Admin becomes approver when dismiss error message for deleting approver member

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021989068132134821633
  • Upwork Job ID: 1989068132134821633
  • Last Price Increase: 2026-01-28
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @emkhalid

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 13, 2025
  2. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 13, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 13, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 13, 2025
  7. 181 remaining items

  8. emkhalid commented on Aug 4, 2026

    @emkhalid
    Contributor

    @Gonals Can you please check above comment, thanks

  9. emkhalid commented on Aug 6, 2026

    @emkhalid
    Contributor

    @Gonals kindly bump on this, thanks!

  10. emkhalid commented on Aug 11, 2026

    @emkhalid
    Contributor

    @Gonals Kindly bump, Thanks!

  11. emkhalid commented on Aug 17, 2026

    @emkhalid
    Contributor

    @Gonals friendly bump on this, thanks!

  12. Gonals commented on Aug 24, 2026

    @Gonals
    Contributor

    @brunovjk @Gonals I tested the frontend change locally.

    The frontend now sends the approval fallback data in DeleteMembersFromWorkspace instead of sending separate workflow update requests before deleting the member.

    However, the API still succeeds and applies the fallback even in the blocked case. That means the missing part is backend-side validation/order of operations.

    DeleteMembersFromWorkspace should first check whether any member being removed is still required as the approver for submitted/pending expense reports. If so, it should fail the delete and leave the workspace approver, employee approval chain, and report approver unchanged.

    Only after member removal is allowed should the API apply the fallback approver/employee updates atomically with the deletion.

    Makes sense. I'll try to get to the backend fix when I have some time

  13. brunovjk commented on Sep 2, 2026

    @brunovjk
    Contributor

    No rush @Gonals, but do you have any updates for us? Thanks.

  14. Gonals commented on Sep 2, 2026

    @Gonals
    Contributor

    I have not. It is honestly going to be a while before I can get to this one 😬

  15. melvin-bot commented on Sep 9, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @Gonals, @brunovjk, @emkhalid eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  16. emkhalid commented on Sep 10, 2026

    @emkhalid
    Contributor

    Not overdue, waiting for @Gonals to get the chance to fix the BE.

  17. brunovjk commented on Sep 16, 2026

    @brunovjk
    Contributor

    No rush @Gonals, but do you have any updates for us? Thanks.

  18. emkhalid commented on Oct 1, 2026

    @emkhalid
    Contributor

    @Gonals Can you please help us on this and check if there is a BE issue to fix the BE section of this issue, thanks!

  19. brunovjk commented on Oct 14, 2026

    @brunovjk
    Contributor

    Frindly bump @Gonals

  20. emkhalid commented on Oct 23, 2026

    @emkhalid
    Contributor

    Still reproducible:

    Screencast.From.2026-10-20.16-14-02.webm

    @Gonals any updates from BE please, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions