You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-13] [Due for payment 2025-12-17] [$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB #75046
Version Number: 9.2.57-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#72714 Email or phone of affected tester (no customers):sjidonjdsoisdjsod2@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Open primary receipt scan button.
Close the RHP.
Open FAB.
Click Create expense under Quick action.
Enter amount > Next.
Expected Result:
Confirm page will not load infinitely.
Actual Result:
Confirm page shows Scan confirm page when it is a manual expense and it loads infinitely.
we calculate newIOUType here. When shouldUseTab is true and when the previously selected tab is not perdiem we assign selectedTab (previously visited tab) to newIOUType which is scan
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
so the transaction iouRequestType will be set to scan and when we reach the confirmation screen we will see loading because it is understood as scan request type transaction without receipt
What changes do you think we should make in order to solve the problem?
The effect is suppose to run when there is a change of reportID but in our case it runs because the transaction data is still loading from onxy so we can avoid the effect here when the transaction data is still loading from onyx
const isLoadingTransaction = isLoadingOnyxValue(transactionResult);
// Clear out the temporary expense if the reportID in the URL has changed from the transaction's reportID.
useFocusEffect(
useCallback(() => {
// The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
if (transaction?.reportID === reportID || isLoadingTransaction || isLoadingSelectedTab || !transactionRequestType || prevTransactionReportID !== transaction?.reportID) {
return;
}
resetIOUTypeIfChanged(transactionRequestType);
}, [transaction?.reportID, reportID, resetIOUTypeIfChanged, isLoadingTransaction, transactionRequestType, isLoadingSelectedTab, prevTransactionReportID]),
);
Alternatively, just like we did here for the quick scan flow to solve a similar bug
changed the title [-]Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/-][+][$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/+]on Nov 25, 2025
changed the title [-][Due for payment 2025-12-17] [$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/-][+][Due for payment 2026-01-13] [Due for payment 2025-12-17] [$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/+]on Jan 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hoangzinh@RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No offending PR. It's a new edge case that we haven't covered before
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 13, 2025
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.etCoderDysto commentedon Nov 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB
What is the root cause of that problem?
We show FullScreenLoadingIndicator when the draft transaction type is scan and when there is no receipt file
App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Line 1244 in 7a03967
We initialize draft transaction with the new newIOUType
App/src/pages/iou/request/IOURequestStartPage.tsx
Lines 161 to 171 in 7a03967
we calculate newIOUType here. When shouldUseTab is true and when the previously selected tab is not perdiem we assign selectedTab (previously visited tab) to newIOUType which is scan
App/src/pages/iou/request/IOURequestStartPage.tsx
Lines 109 to 121 in 7a03967
What changes do you think we should make in order to solve the problem?
We should make shouldUseTab false if the iouType type is sbumit
App/src/pages/iou/request/IOURequestStartPage.tsx
Line 66 in 7a03967
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
FitseTLT commentedon Nov 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB
What is the root cause of that problem?
When selectedTab was
scanand we use QAB withmanualrequest type set the selectedTab is updated from the current routeApp/src/libs/Navigation/OnyxTabNavigator.tsx
Line 197 in 7a03967
but it happens too slow and this effect here is run with the
transactionRequestTypecalculated from the old selectedTab which wasscanApp/src/pages/iou/request/IOURequestStartPage.tsx
Lines 189 to 195 in 7a03967
so the transaction iouRequestType will be set to scan and when we reach the confirmation screen we will see loading because it is understood as scan request type transaction without receipt
App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Line 1244 in 7a03967
What changes do you think we should make in order to solve the problem?
The effect is suppose to run when there is a change of reportID but in our case it runs because the
transactiondata is still loading from onxy so we can avoid the effect here when the transaction data is still loading from onyxApp/src/pages/iou/request/IOURequestStartPage.tsx
Lines 189 to 195 in 7a03967
Alternatively, just like we did here for the quick scan flow to solve a similar bug
App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
Line 307 in 7a03967
we will need to set the tab here
App/src/libs/actions/QuickActionNavigation.ts
Line 42 in 7a03967
so that the selected tab data is ready when we reach start page
What alternative solutions did you explore? (Optional)
[-]Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/-][+][$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/+]melvin-bot commentedon Nov 25, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021993335218775137514
melvin-bot commentedon Nov 25, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)42 remaining items
[-][Due for payment 2025-12-17] [$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/-][+][Due for payment 2026-01-13] [Due for payment 2025-12-17] [$250] Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB[/+]melvin-bot commentedon Jan 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 6, 2026
@hoangzinh @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
RachCHopkins commentedon Jan 12, 2026
Checklist please @hoangzinh
hoangzinh commentedon Jan 12, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No offending PR. It's a new edge case that we haven't covered before
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/588168
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-fccd-afba-a9cc-ab90410c5ba4RachCHopkins commentedon Jan 14, 2026
Payment Summary:
Upwork job here
RachCHopkins commentedon Jan 14, 2026
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.
🟢 to @hoangzinh to request payment via newdot.
garrettmknight commentedon Jan 21, 2026
$250 approved for @hoangzinh