Skip to content

[$250] Chat - You is displayed on chat header, and LHN when opening resolved duplicate messsage #75233

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

\1. Go to workspace chat
2. Create two duplicate manual expense
3. Open the expense thread > Review duplicate.> Keep all
4. Open one of the expenses > Right click on 'resolved the duplicate' message > Reply in thread

Expected Result:

'resolved the duplicate' should be displayed on LHN title, and report header

Actual Result:

'You' is displayed on LHN title, and report header

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7004274_1763152533188.Screen_Recording_2025-11-14_at_11.27.40_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021990961159543969561
  • Upwork Job ID: 1990961159543969561
  • Last Price Increase: 2025-11-19
  • Automatic offers:
    • etCoderDysto | Contributor | 109582889
Issue OwnerCurrent Issue Owner: @mollfpr

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 15, 2025
  2. melvin-bot commented on Nov 15, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. etCoderDysto commented on Nov 15, 2025

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat - You is displayed on chat header, and LHN when opening resolved duplicate messsage

    What is the root cause of that problem?

    We are not handling CONST.REPORT.ACTIONS.TYPE.DISMISSED_VIOLATION action type in getReportName

    App/src/libs/ReportUtils.ts

    Lines 5724 to 5726 in ca4289f

    if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_CARD_FRAUD_ALERT) && getOriginalMessage(parentReportAction)?.resolution) {
    return getActionableCardFraudAlertResolutionMessage(parentReportAction);
    }

    What changes do you think we should make in order to solve the problem?

    We should handle CONST.REPORT.ACTIONS.TYPE.DISMISSED_VIOLATION action type in getReportName as we are doing for PureReportActionItem

    } else if (isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.DISMISSED_VIOLATION)) {
    children = <ReportActionItemBasicMessage message={getDismissedViolationMessageText(getOriginalMessage(action))} />;

     if (isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.DISMISSED_VIOLATION)) {
            return getDismissedViolationMessageText(getOriginalMessage(parentReportAction))
        }

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 19, 2025
  5. changed the title [-]Chat - You is displayed on chat header, and LHN when opening resolved duplicate messsage[/-] [+][$250] Chat - You is displayed on chat header, and LHN when opening resolved duplicate messsage[/+] on Nov 19, 2025
  6. melvin-bot commented on Nov 19, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 19, 2025
  8. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

  9. DylanDylann commented on Nov 20, 2025

    @DylanDylann
    Contributor

    @etCoderDysto's proposal looks good to me

    🎀👀🎀 C+ reviewed

  10. 10 remaining items

  11. etCoderDysto commented on Nov 26, 2025

    @etCoderDysto
    Contributor

    @DylanDylann PR is ready for review

  12. melvin-bot commented on Dec 20, 2025

    @melvin-bot

    This issue has not been updated in over 15 days. @NicMendonca, @mollfpr, @DylanDylann, @etCoderDysto eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  13. etCoderDysto commented on Dec 20, 2025

    @etCoderDysto
    Contributor

    @NicMendonca PR has been deployed to production 3 weeks ago. The issue is ready for payment ;)

  14. DylanDylann commented on Dec 20, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: I don't think it is a regression. It looks like a case that hasn't been considered before

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Go to workspace chat
    2. Create two duplicate manual expense
    3. Open the expense thread > Review duplicate.> Keep all
    4. Open one of the expenses > Right click on 'resolved the duplicate' message > Reply in thread
    5. Verify that you see resolved the duplicate message on report header, LHN title
    6. Click on the report header
    7. Verify that you see resolved the duplicate message on report details page

    Do we agree 👍 or 👎

  15. DylanDylann commented on Jan 5, 2026

    @DylanDylann
    Contributor

    @NicMendonca Could you please handle the payment?

  16. NicMendonca commented on Jan 14, 2026

    @NicMendonca
    Contributor

    Payment Summary

    Contributor: @etCoderDysto paid $250 via Upwork
    Contributor+: @DylanDylann due $250 via NewDot

  17. JmillsExpensify commented on Jan 20, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions