Repository navigation
[HOLD for payment 2022-05-20][$1000] - Audit forms and fix inconsistencies with modifying user input #7524
Description
We should audit all our forms and fix any inconsistencies with modifying user input. The expected behavior is as follows:
- User input should not be modified as they type.
- User input that may include optional characters (e.g.
(, ), -in a phone number) and should never be restricted on input, nor be modified or formatted on blur. - Instead we will format and clean the user input internally before using the value (e.g. making an API request where the user will never see this transformation happen)
- Additionally, users should always be able to copy/paste whatever characters they want into fields.
To give a slightly more detailed example of how this would work with phone numbers we should:
- Allow any character to be entered in the field.
- On blur, strip all non-number characters (with the exception of + if the API accepts it) and validate the result against the E.164 regex pattern we use for a valid phone. Stripping characters should happen internally and result in NO UI change to the user.
- On submit, repeat validation and submit with the clean value.
Here's a list of forms to be audited:
- AddPlaidBankAccount.js
- ACHContractStep.js
- BankAccountStep.js
- CompanyStep.js
- RequestorStep.js
- ValidationStep.js
- Workspace - Invite new members
- Workspace - General settings
- IOU flow
- KYC flow
- New Room screen
- Add Debit card flow
- Add Personal Bank account flow
- Settings - Change Password
- Settings - Profile
- Login form
- Password form
- Set password
- New password form
- Request a Call modal
Activity
MelvinBot commentedon Feb 2, 2022
Triggered auto assignment to @SofiedeVreese (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.luacmartins commentedon Feb 2, 2022
Actually, we might use Applause to do this audit for us. Removing the External label.
MelvinBot commentedon Feb 15, 2022
12 days overdue now... This issue's end is nigh!
MelvinBot commentedon Feb 15, 2022
12 days overdue. Walking. Toward. The. Light...
luacmartins commentedon Feb 15, 2022
Nvm my previous comment, this can be handled by contributors! Adding External label.
99 remaining items
luacmartins commentedon May 2, 2022
@JmillsExpensify as per this comment, there should be 4x $250 milestones for this job, for a total of $1000. As of now, 3/4 milestones have been completed ($750).
@eVoloshchak when do you think you can complete the last 4 audits?
eVoloshchak commentedon May 2, 2022
I already did that, both PR's are merged, the latest one will soon be deployed to production
luacmartins commentedon May 2, 2022
Ah nice! Thanks for linking that last PR!
Ok, so 3 milestones are complete and should be paid. The last one is waiting on this PR being deployed and the 7 day regression period.
mallenexpensify commentedon May 4, 2022
@eVoloshchak paid 3 milestones totaling $750 (I'm not sure if the one's finished are aligned with the ones paid in Upwork but the total amounts will wash out).
cc @JmillsExpensify since you'll likely be the one issuing the final $250 payment 7 days after #8764 hits production (if no regressions)
JmillsExpensify commentedon May 5, 2022
Awesome, thanks! Looks like we're still waiting on that last PR to hit production (and confirm no regressions).
JmillsExpensify commentedon May 10, 2022
PR hit staging yesterday.
[-][$1000] - Audit forms and fix inconsistencies with modifying user input[/-][+][HOLD for payment 2022-05-20][$1000] - Audit forms and fix inconsistencies with modifying user input[/+]JmillsExpensify commentedon May 17, 2022
A couple more days left on the 7-day hold for that last PR.
JmillsExpensify commentedon May 23, 2022
Jumping in to process this one now and pay outstanding contributors.
JmillsExpensify commentedon May 23, 2022
Got a little confused on the payments, but after re-adding the above I'll be issuing the final $250 payment. @rushatgabhane I've also closed out your C+ contract.
@luacmartins Can we also close out this ensure issue now?
luacmartins commentedon May 23, 2022
@JmillsExpensify Yes! This was the last payment so I believe that all milestones have been paid out. Thanks for working on this!
parasharrajat commentedon May 24, 2022
Shouldn't this be convered as part of this issue?
luacmartins commentedon May 24, 2022
Hmm that seems to be out of scope for this issue.