You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment due asap] [$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow #75479
Version Number: v9.2.60-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory Email or phone of affected tester (no customers):kiatest.80+ck111425@gmail.com Issue reported by: Applause Internal Team Device used: Windows 11/Chrome, iPhone 16/iOS 18.3.1, Pixel 8a/Android 16 App Component: Money Requests
Action Performed:
Navigate to staging.new.expensify.com
Go to workspace chat
Create 2 manual track expenses
Go to report details page
Click Add expense button present below the expenses
Again tap Add expense button >> Track distance >> select start waypoint
Expected Result:
User able to select start waypoint to create distance expense via Add expense button in report details page. Hmm.not here page should not be displayed when selecting waypoints from second time onwards via Add expense button
Actual Result:
If the report contains manual track expenses, user cannot select waypoints to create distance expense via Add expense button present within the report details page. Hmm..not here page opens from second time onwards whenever user try to select start or stop waypoints
Please re-state the problem that we are trying to solve in this issue.
If the report contains manual track expenses, user cannot select waypoints to create distance expense via Add expense button present within the report details page. Hmm..not here page opens from second time onwards whenever user try to select start or stop waypoints
What is the root cause of that problem?
When creating a new expense (isEditing = false), the useShowNotFoundPageInIOUStep hook still tried to fetch a reportAction using report?.parentReportActionID || reportActionID, which could contain stale values from previous transactions.
What changes do you think we should make in order to solve the problem?
Updated getReportActionSelector to return undefined immediately when reportActionsReportID is falsy to ensures the "not found" page only shows when appropriate and doesn't appear when creating new distance expenses from the report details page.
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Not here page when selecting waypoints second time onwards via Add expense CTA flow[/-][+][$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow[/+]on Nov 19, 2025
Please re-state the problem that we are trying to solve in this issue.
If the report contains manual track expenses, user cannot select waypoints to create distance expense via Add expense button present within the report details page. Hmm..not here page opens from second time onwards whenever user try to select start or stop waypoints
What is the root cause of that problem?
When get the dropdown options, we triggers getAddExpenseDropdownOptions but didn’t pass lastDistanceExpenseType like what we did in other places like AttachmentPickerWithMenuItems
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow[/-][+][Payment due asap] [$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow[/+]on Dec 11, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 18, 2025
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Nov 18, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
If the report contains manual track expenses, user cannot select waypoints to create distance expense via Add expense button present within the report details page. Hmm..not here page opens from second time onwards whenever user try to select start or stop waypoints
What is the root cause of that problem?
When creating a new expense (isEditing = false), the
useShowNotFoundPageInIOUStephook still tried to fetch a reportAction usingreport?.parentReportActionID || reportActionID, which could contain stale values from previous transactions.App/src/hooks/useShowNotFoundPageInIOUStep.ts
Lines 28 to 34 in 9d3daec
App/src/hooks/useShowNotFoundPageInIOUStep.ts
Lines 44 to 52 in 9d3daec
What changes do you think we should make in order to solve the problem?
Updated getReportActionSelector to return undefined immediately when reportActionsReportID is falsy to ensures the "not found" page only shows when appropriate and doesn't appear when creating new distance expenses from the report details page.
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Not here page when selecting waypoints second time onwards via Add expense CTA flow[/-][+][$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow[/+]melvin-bot commentedon Nov 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021990955474131343129
melvin-bot commentedon Nov 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)paulnjs commentedon Nov 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
If the report contains manual track expenses, user cannot select waypoints to create distance expense via Add expense button present within the report details page. Hmm..not here page opens from second time onwards whenever user try to select start or stop waypoints
What is the root cause of that problem?
When get the dropdown options, we triggers
getAddExpenseDropdownOptionsbut didn’t passlastDistanceExpenseTypelike what we did in other places like AttachmentPickerWithMenuItemsApp/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Line 178 in bf35a10
So we didn’t init the waypoints
What changes do you think we should make in order to solve the problem?
Update this line:
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Line 178 in bf35a10
To
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
dukenv0307 commentedon Nov 20, 2025
Thanks for your proposals. @paulnjs, your RCA is correct, and the solution works well.
Link to selected proposal
🎀👀🎀 C+ reviewed
8 remaining items
JS00001 commentedon Dec 9, 2025
Hmm yeah thats strange. @dukenv0307 Could you please fill this out?
[-][$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow[/-][+][Payment due asap] [$250] Not here page when selecting waypoints second time onwards via Add expense CTA flow[/+]dukenv0307 commentedon Dec 11, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/71267/files#r2609072011
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/577576
Regression Test Proposal
Test:
Do we agree 👍 or 👎
dukenv0307 commentedon Dec 11, 2025
@brianlee-expensify I completed the checklist. Thanks
brianlee-expensify commentedon Dec 11, 2025
@JS00001 @dukenv0307 is it because @paulnjs did not accept the Upwork job?
i'd usually see the "End contract" button to pay out the Contributor, but Paul hasn't been assigned the contract.
JS00001 commentedon Dec 11, 2025
Hmm, I'm not sure, would you be able to ask in bugzero? I've not seen this issue before
brianlee-expensify commentedon Dec 16, 2025
asking in bugzero on slack
brianlee-expensify commentedon Dec 16, 2025
@paulnjs can you accept this Upwork job so that i can send over payment accordingly?
paulnjs commentedon Dec 17, 2025
@brianlee-expensify I accepted. Thank you!
brianlee-expensify commentedon Dec 17, 2025
Payment Summary
Contributor: @paulnjs paid $250 via Upwork
Contributor+: @dukenv0307 due $250 via NewDot
quinthar commentedon Dec 19, 2025
Approved $250 to @dukenv0307