Skip to content

[Due for payment 2025-12-17] [$250] Login - Refreshing Stay organized with workspace page user lands to what's your name page #75605

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #75072
Email or phone of affected tester (no customers): Bshd@tstsg.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Login with new @tstsg.com account
  3. Click on "Join"
  4. Add your name and click on "Continue"
  5. Tap skip
  6. Select Track expense
  7. Refresh the stay organized with workspace page
  8. Note user landed in what's your name page instead staying in same page
  9. Tap continue
  10. What do you want to do page is skipped and user directly landed to stay organized with workspace page

Expected Result:

Refreshing Stay organized with workspace page user must remain in same page

Actual Result:

Refreshing Stay organized with workspace page user lands to what's your name page.
If in default it has to land on what's your name page, tapping next must show all pages and musn't skip What do you want to do

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7008557_1763574547060.Screenrecorder-2025-11-19-23-07-06-863.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021991704231610378735
  • Upwork Job ID: 1991704231610378735
  • Last Price Increase: 2025-12-05
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 19, 2025
  2. melvin-bot commented on Nov 19, 2025

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. twilight2294 commented on Nov 19, 2025

    @twilight2294
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refreshing Stay organized with workspace page user lands to what's your name page

    What is the root cause of that problem?

    When the screen is refreshed, we get navigated to the personal details screen because of the following condition:

    if (!isUserFromPublicDomain && hasAccessiblePolicies) {
    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {
    return onboardingInitialPath;
    }
    return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`;
    }

    It doesn't return onboardingInitialPath if the route path is onboarding/create-workspace

    What changes do you think we should make in order to solve the problem?

    We should return onboardingInitialPath if the route path is onboarding/create-workspace:

        if (!isUserFromPublicDomain && hasAccessiblePolicies) {
            if ([ROUTES.ONBOARDING_PRIVATE_DOMAIN.route, ROUTES.ONBOARDING_PERSONAL_DETAILS.route, ROUTES.ONBOARDING_WORKSPACE.route].some(route => onboardingInitialPath.includes(route))) {
                return onboardingInitialPath;
            }
            return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`;
        }

    if (!isUserFromPublicDomain && hasAccessiblePolicies) {
    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {
    return onboardingInitialPath;
    }
    return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`;
    }

    What alternative solutions did you explore? (Optional)

    N/A

  4. lorretheboy commented on Nov 20, 2025

    @lorretheboy
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refreshing Stay organized with workspace page user lands to what's your name page

    What is the root cause of that problem?

    The issue occurs specifically for users with private domain AND accessible policies. When such users refresh the workspace page:

    • The condition !isUserFromPublicDomain && hasAccessiblePolicies evaluates to true
    • The onboardingInitialPath is /onboarding/create-workspace
    • The original code only checked for ONBOARDING_PRIVATE_DOMAIN or ONBOARDING_PERSONAL_DETAILS routes
    • Since the workspace route didn't match, it fell through to the default: return /${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}

    This, user was incorrectly redirected to "What's your name" page

    if (!isUserFromPublicDomain && hasAccessiblePolicies) {
    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {
    return onboardingInitialPath;
    }
    return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`;
    }

    What changes do you think we should make in order to solve the problem?

    We need to modify the condition inside the private domain block to include workspace-related routes in the list of routes that should be preserved

        if (!isUserFromPublicDomain && hasAccessiblePolicies) {
            if (
                [
                    ROUTES.ONBOARDING_PRIVATE_DOMAIN.route,
                    ROUTES.ONBOARDING_PERSONAL_DETAILS.route,
                    ROUTES.ONBOARDING_WORKSPACE.route,
                    ROUTES.ONBOARDING_WORKSPACE_CONFIRMATION.route,
                    ROUTES.ONBOARDING_WORKSPACE_INVITE.route,
                ].some((route) => onboardingInitialPath.includes(route))
            ) {
                return onboardingInitialPath;
            }
            return `/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}`;
        }

    Note: We should check all 5 routes above, otherwise it still have the issue in the next step /onboarding/workspace-invite, /onboarding/workspace-confirmation,... route (Not a new flow, they are still in the same flow as described in OP)

    Note 2: If can check and fix other similar flows if needed in PR

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. twilight2294 commented on Nov 20, 2025

    @twilight2294
    Contributor

    Note

    Note for future C+ that above proposal is unique and different, it adds check for extra urls :), so i think according to the proposal template my proposal is valid here

  6. nkdengineer commented on Nov 20, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refreshing Stay organized with workspace page user lands to what's your name page

    What is the root cause of that problem?

    For the private domain, we only navigate to the onboardingInitialPath page if it's the private domain step or personal detail step

    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {

    What changes do you think we should make in order to solve the problem?

    We should always navigate to the onboardingInitialPath if it exists

    if (onboardingInitialPath) {
                return onboardingInitialPath;
            }
    

    if (onboardingInitialPath.includes(ROUTES.ONBOARDING_PRIVATE_DOMAIN.route) || onboardingInitialPath.includes(ROUTES.ONBOARDING_PERSONAL_DETAILS.route)) {

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 21, 2025
  8. changed the title [-]Login - Refreshing Stay organized with workspace page user lands to what's your name page[/-] [+][$250] Login - Refreshing Stay organized with workspace page user lands to what's your name page[/+] on Nov 21, 2025
  9. melvin-bot commented on Nov 21, 2025

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 21, 2025
  11. strepanier03 commented on Nov 21, 2025

    @strepanier03
    Contributor

    Able to repro, moving forward.

  12. melvin-bot commented on Nov 21, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  13. 36 remaining items

  14. melvin-bot commented on Dec 10, 2025

    @melvin-bot

    @hoangzinh @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@strepanier03)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1991704231610378735/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. strepanier03 commented on Dec 18, 2025

    @strepanier03
    Contributor

    Payment Summary

    HOLD C+ PAYMENT FOR CHECKLIST

    • $250 - @hoangzinh requires payment through NewDot Manual Requests
    • $250 - @nkdengineer requires payment through NewDot Manual Requests
  17. strepanier03 commented on Dec 18, 2025

    @strepanier03
    Contributor

    HEADS UP

    I am OoO starting 12-19 and will return on 12-29.

    If this GH needs attention or action during that time period, please reapply the BugZero label to assign someone to help out, but leave me assigned as well. Alternatively, you can post in Slack for a BZ buddy to take action.

    Otherwise, I will catch up on issues that need attention when I get back.

  18. hoangzinh commented on Dec 19, 2025

    @hoangzinh
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No offending PR. We just want to extend the same behavior for the rest of the onboarding URL

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/582795

    Regression Test Proposal

    Test:

    1. Login with a new account
    2. Click on "Join"
    3. Add your name and click on "Continue"
    4. Tap skip
    5. Select Track expense
    6. Refresh the stay organized with workspace page
    7. Verify that the user stays on stay organized with workspace page

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-072a-afd7-c370-d8474bf48d44
  19. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

  20. melvin-bot commented on Dec 25, 2025

    @melvin-bot

    @strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  21. garrettmknight commented on Dec 29, 2025

    @garrettmknight
    Contributor

    $250 approved for @hoangzinh

  22. strepanier03 commented on Dec 30, 2025

    @strepanier03
    Contributor

    Reg test made, closing out. Thanks @hoangzinh for the reg test steps.

  23. twisterdotcom commented on Dec 30, 2025

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-a6c6-a988-a583-a254fc89c574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions