You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-17] [$250] Login - Refreshing Stay organized with workspace page user lands to what's your name page #75605
Version Number: 9.2.61-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:#75072 Email or phone of affected tester (no customers):Bshd@tstsg.com Issue reported by: Applause - Internal Team
Note user landed in what's your name page instead staying in same page
Tap continue
What do you want to do page is skipped and user directly landed to stay organized with workspace page
Expected Result:
Refreshing Stay organized with workspace page user must remain in same page
Actual Result:
Refreshing Stay organized with workspace page user lands to what's your name page.
If in default it has to land on what's your name page, tapping next must show all pages and musn't skip What do you want to do
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug7008557_1763574547060.Screenrecorder-2025-11-19-23-07-06-863.mp4
Note: We should check all 5 routes above, otherwise it still have the issue in the next step /onboarding/workspace-invite, /onboarding/workspace-confirmation,... route (Not a new flow, they are still in the same flow as described in OP)
Note 2: If can check and fix other similar flows if needed in PR
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Note for future C+ that above proposal is unique and different, it adds check for extra urls :), so i think according to the proposal template my proposal is valid here
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Login - Refreshing Stay organized with workspace page user lands to what's your name page[/-][+][$250] Login - Refreshing Stay organized with workspace page user lands to what's your name page[/+]on Nov 21, 2025
@hoangzinh@strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
If this GH needs attention or action during that time period, please reapply the BugZero label to assign someone to help out, but leave me assigned as well. Alternatively, you can post in Slack for a BZ buddy to take action.
Otherwise, I will catch up on issues that need attention when I get back.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No offending PR. We just want to extend the same behavior for the rest of the onboarding URL
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 19, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.twilight2294 commentedon Nov 19, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refreshing Stay organized with workspace page user lands to what's your name page
What is the root cause of that problem?
When the screen is refreshed, we get navigated to the personal details screen because of the following condition:
App/src/libs/actions/Welcome/OnboardingFlow.ts
Lines 124 to 129 in 2890dc2
It doesn't return
onboardingInitialPathif the route path isonboarding/create-workspaceWhat changes do you think we should make in order to solve the problem?
We should return
onboardingInitialPathif the route path isonboarding/create-workspace:App/src/libs/actions/Welcome/OnboardingFlow.ts
Lines 124 to 129 in 2890dc2
What alternative solutions did you explore? (Optional)
N/A
lorretheboy commentedon Nov 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refreshing Stay organized with workspace page user lands to what's your name page
What is the root cause of that problem?
The issue occurs specifically for users with private domain AND accessible policies. When such users refresh the workspace page:
/${ROUTES.ONBOARDING_PERSONAL_DETAILS.route}This, user was incorrectly redirected to "What's your name" page
App/src/libs/actions/Welcome/OnboardingFlow.ts
Lines 124 to 129 in cae1e1a
What changes do you think we should make in order to solve the problem?
We need to modify the condition inside the private domain block to include workspace-related routes in the list of routes that should be preserved
Note: We should check all 5 routes above, otherwise it still have the issue in the next step /onboarding/workspace-invite, /onboarding/workspace-confirmation,... route (Not a new flow, they are still in the same flow as described in OP)
Note 2: If can check and fix other similar flows if needed in PR
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
twilight2294 commentedon Nov 20, 2025
Note
Note for future C+ that above proposal is unique and different, it adds check for extra urls :), so i think according to the proposal template my proposal is valid here
nkdengineer commentedon Nov 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refreshing Stay organized with workspace page user lands to what's your name page
What is the root cause of that problem?
For the private domain, we only navigate to the
onboardingInitialPathpage if it's the private domain step or personal detail stepApp/src/libs/actions/Welcome/OnboardingFlow.ts
Line 125 in b6a0775
What changes do you think we should make in order to solve the problem?
We should always navigate to the
onboardingInitialPathif it existsApp/src/libs/actions/Welcome/OnboardingFlow.ts
Line 125 in b6a0775
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Login - Refreshing Stay organized with workspace page user lands to what's your name page[/-][+][$250] Login - Refreshing Stay organized with workspace page user lands to what's your name page[/+]melvin-bot commentedon Nov 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021991704231610378735
strepanier03 commentedon Nov 21, 2025
Able to repro, moving forward.
melvin-bot commentedon Nov 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)36 remaining items
melvin-bot commentedon Dec 10, 2025
@hoangzinh @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Dec 17, 2025
Payment Summary
Upwork Job
BugZero Checklist (@strepanier03)
strepanier03 commentedon Dec 18, 2025
Payment Summary
HOLD C+ PAYMENT FOR CHECKLIST
strepanier03 commentedon Dec 18, 2025
HEADS UP
I am OoO starting 12-19 and will return on 12-29.
If this GH needs attention or action during that time period, please reapply the
BugZerolabel to assign someone to help out, but leave me assigned as well. Alternatively, you can post in Slack for a BZ buddy to take action.Otherwise, I will catch up on issues that need attention when I get back.
hoangzinh commentedon Dec 19, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No offending PR. We just want to extend the same behavior for the rest of the onboarding URL
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/582795
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-072a-afd7-c370-d8474bf48d44melvin-bot commentedon Dec 23, 2025
@strepanier03 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Dec 25, 2025
@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
garrettmknight commentedon Dec 29, 2025
$250 approved for @hoangzinh
strepanier03 commentedon Dec 30, 2025
Reg test made, closing out. Thanks @hoangzinh for the reg test steps.
twisterdotcom commentedon Dec 30, 2025
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-a6c6-a988-a583-a254fc89c574