You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD #77425][$250] Chat - Approver is shown on Add Approver list #75608
Version Number: 9.2.61-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):gibethlehem@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Login to an account and Create a workspace with an employee
Create an expenses on the workspace chat
Submit the expense
Go to more > Change Approver
Click on Add Approver > Change Approver (Update if necessary)
Select approver and Save
Go to workspace > members > Try to remove the approver in step 5
With out dismissing the error go to The expense
Go to more > Change Approver > Click on Add Approver
Expected Result:
Approver is not listed on the Add approver page
Actual Result:
Approver is listed on the Add approver page
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug7008566_1763575444345.Screen_Recording_2025-11-18_at_2.38.34_at_night.mp4
So we get this user in the list. We added this because we have this logic of dismiss error:
This means that if there is no pendingAction === ‘delete’, then it is assumed that we are adding the user, not clearing them, which results in us removing them from Onyx completely:
And remove pendingAction when executing the request:
pendingAction: null
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
What changes do you think we should make in order to solve the problem?
We should not filter out pending delete member, instead we only filter out members that are pending deletion without errors (successful deletion). Members with deletion errors should still be included since the deletion failed
Note: We can add new param includeMemberWithPendingDeleteWithError if needed
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@lydiabarclay this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
If removing a workspace member fails (e.g. due to pending approvals), the user is not actually removed from the policy. The pendingAction: DELETE is kept only to display the RBR on the Workspace Members page until the error is dismissed, and must not affect functional behavior elsewhere.
As a result, members with a failed DELETE action should:
Still be treated as valid workspace members
Still appear normally in the Add Approver selector (with correct name/avatar)
Not be filtered out or degraded due to pendingAction: DELETE alone
In short: a pending DELETE with an error should not change approver eligibility or visibility; it only indicates a failed removal attempt.
changed the title [-][$250] Chat - Approver is shown on Add Approver list[/-][+][HOLD #77425][$250] Chat - Approver is shown on Add Approver list[/+]on Dec 22, 2025
Activity
melvin-bot commentedon Nov 19, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Eskalifer1 commentedon Nov 19, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-09 13:35:42 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Approver is shown on Add Approver list
What is the root cause of that problem?
Here we get
allApprovers:App/src/pages/ReportAddApproverPage.tsx
Lines 47 to 83 in be1e9e7
But in this case firs account have
pendingAction === "delete"since we didn’t dismiss the errorWhat changes do you think we should make in order to solve the problem?
We should filter employees with pending action delete:
We actually already have this logic:
App/src/pages/ReportAddApproverPage.tsx
Line 62 in be1e9e7
But this function has 3rd parametr as false so pending delete members is not included:
App/src/pages/ReportAddApproverPage.tsx
Line 52 in be1e9e7
So we can just pass
true:What alternative solutions did you explore? (Optional)
We have preserve pendingAction here:
App/src/libs/actions/Policy/Member.ts
Line 412 in 623dd38
So we get this user in the list. We added this because we have this logic of dismiss error:
This means that if there is no pendingAction === ‘delete’, then it is assumed that we are adding the user, not clearing them, which results in us removing them from Onyx completely:
App/src/pages/workspace/WorkspaceMembersPage.tsx
Lines 336 to 348 in 51f9373
We can add a check for this specific case so that when this error occurs, we execute
clearDeleteMemberError:And remove pendingAction when executing the request:
pendingAction: nullReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
thelullabyy commentedon Nov 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Approver is listed on the Add approver page
What is the root cause of that problem?
We filter pending action delete with error member here
App/src/pages/ReportAddApproverPage.tsx
Lines 64 to 67 in 1afd7d6
App/src/libs/PolicyUtils.ts
Lines 376 to 378 in 6abc35a
What changes do you think we should make in order to solve the problem?
We should not filter out pending delete member, instead we only filter out members that are pending deletion without errors (successful deletion). Members with deletion errors should still be included since the deletion failed
App/src/libs/PolicyUtils.ts
Lines 376 to 378 in 6abc35a
Do similar here
App/src/pages/ReportAddApproverPage.tsx
Lines 64 to 67 in 1afd7d6
Note: We can add new param
includeMemberWithPendingDeleteWithErrorif neededWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
lydiabarclay commentedon Nov 20, 2025
Checking with product
lydiabarclay commentedon Nov 24, 2025
Bumped Slack
lydiabarclay commentedon Nov 26, 2025
Still discussing expected behavior
lydiabarclay commentedon Dec 1, 2025
Bumped thread
melvin-bot commentedon Dec 3, 2025
@lydiabarclay this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
26 remaining items
melvin-bot commentedon Dec 18, 2025
@allroundexperts 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
lydiabarclay commentedon Dec 19, 2025
Summarizing from the discussion here:
@MarioExpensify is this an accurate summary?
MarioExpensify commentedon Dec 22, 2025
Yes, that is correct @lydiabarclay, thank you for the great summary!!
@Eskalifer1 if you want to update your proposal to reflect the behavior as described in the previous message. CC: @allroundexperts
Eskalifer1 commentedon Dec 22, 2025
Hi @MarioExpensify seems like dupe issue already have PR, so we can close this one
[-][$250] Chat - Approver is shown on Add Approver list[/-][+][HOLD #77425][$250] Chat - Approver is shown on Add Approver list[/+]mallenexpensify commentedon Dec 22, 2025
Put on hold pending the below issue, thanks @Eskalifer1 for sharing.
@lydiabarclay if the issue isn't reproducible after the PR hits production, please add
Externalto add a C+. Thxmvtglobally commentedon Dec 27, 2025
Issue not reproducible during KI retests. (First week) (checked before it went on hold)