Skip to content

[$125] Reports - Approve is not the default tab on Reports page when accessed offline #75618

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72034
Email or phone of affected tester (no customers): new needed
Issue reported by: Applause Internal Team
Device used: MacOS Safari and Chrome
App Component: Chat Report View

Action Performed:

  1. Launch new Expensify and Sign up with a new account
  2. Complete onboarding modal selecting "Something Else"
  3. Troubleshoot (CMD+D) > enable Force offline
  4. Create a Workspace
  5. Go to reports
  6. Note that you land on "Submit" by default instead of approve
  7. Troubleshoot (CMD+D) > Disable force offline
  8. Note that you land on "Approve" as expected

Expected Result:

Step 6: According to the PR when the reports page is accessed the default selection should be "Approve" if it is available

Actual Result:

Step 6 : When accessed offline the default tab of Reports is Submit and not "Approve".
Step 8 : The correct tab is shown only when the page is accessed online

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7008677_1763582938833.Recording__1399.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021991306677423867478
  • Upwork Job ID: 1991306677423867478
  • Last Price Increase: 2025-11-27
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2025
  2. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Nov 20, 2025
  4. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Nov 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Nov 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. 13 remaining items

  8. ShridharGoel commented on Nov 20, 2025

    @ShridharGoel
    Contributor

    isOffline check is needed, we shouldn't be removing it.
    #72034 (comment)

  9. roryabraham commented on Nov 20, 2025

    @roryabraham
    Contributor

    hmmmm can you take a more careful look @ZhenjaHorbach ?

  10. nkdengineer commented on Nov 21, 2025

    @nkdengineer
    Contributor

    The original PR was reverted.

  11. twisterdotcom commented on Nov 25, 2025

    @twisterdotcom
    Contributor

    Bump here @ZhenjaHorbach.

  12. ZhenjaHorbach commented on Nov 25, 2025

    @ZhenjaHorbach
    Contributor

    The original PR was reverted.

    @nkdengineer
    Do you mean this PR?
    #75650

  13. nkdengineer commented on Nov 25, 2025

    @nkdengineer
    Contributor

    Yes.

  14. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. melvin-bot commented on Nov 29, 2025

    @melvin-bot

    @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    @ZhenjaHorbach Huh... This is 4 days overdue. Who can take care of this?

  17. ZhenjaHorbach commented on Dec 1, 2025

    @ZhenjaHorbach
    Contributor

    Looks like this PR was merged
    #75704

    And the issue was fixed
    So let's close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions