You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-13] [$250] Expense - Old merchant shown on the expense row in the report when edited in Reports #76329
Version Number: 9.2.66-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176922/test-cases/41237504 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iPhone 15 iOS 26.1 App Component: Money Requests
Action Performed:
Sign in to ND
Create two expenses in one report in the workspace chat
Navigate to the Reports tab/ Expenses
Select one of the just created expenses and change the merchant
Navigate to the workspace chat, open the report
Observe the merchant on the expense, where the merchant was edited
Expected Result:
Merchant is updated on the expense row in the expenses list in the report
Actual Result:
Merchant is not updated on the expense row in the expenses list in the report, when the merchant was edited in the Reports tab
So props like formattedMerchant is also merged to Onyx.
When updating merchant this value is not updated, so the old value is still displayed.
TransactionItemRow is used in both Report page and Search page, but we don't see the same issue in Reports > Expenses page, this is because transaction.formattedMerchant was recalculated in Search page:
What changes do you think we should make in order to solve the problem?
Since the values created by getTransactionItemCommonFormattedProperties is only used temporarily and calculated on-the-go, we don't need those values stored. So we should exclude props created by getTransactionItemCommonFormattedProperties when merging here.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Old merchant shown on the expense row in the report when edited in Reports[/-][+][$250] Expense - Old merchant shown on the expense row in the report when edited in Reports[/+]on Dec 3, 2025
changed the title [-][$250] Expense - Old merchant shown on the expense row in the report when edited in Reports[/-][+][Due for payment 2026-01-13] [$250] Expense - Old merchant shown on the expense row in the report when edited in Reports[/+]on Jan 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mollfpr@lydiabarclay@FitseTLT / @mkzie2 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 29, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Nov 30, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-11 11:44:53 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Merchant is not updated on the expense row in the expenses list in the report, when the merchant was edited in the Reports tab
What is the root cause of that problem?
We use
transaction.formattedMerchantfor primary merchant calculation inTransactionItemRow:App/src/components/TransactionItemRow/index.tsx
Line 119 in f82a8db
formattedMerchantis calculated in FE to better display in search page:App/src/libs/SearchUIUtils.ts
Lines 654 to 688 in 7e199a6
When user selects the transaction, we call
createAndOpenSearchTransactionThreadApp/src/components/Search/index.tsx
Line 717 in 7e199a6
Calling this merges the transaction item to Onyx storage, this includes props created above
App/src/libs/SearchUIUtils.ts
Line 1422 in 7e199a6
App/src/libs/actions/Search.ts
Lines 1156 to 1160 in 7e199a6
So props like
formattedMerchantis also merged to Onyx.When updating merchant this value is not updated, so the old value is still displayed.
TransactionItemRowis used in both Report page and Search page, but we don't see the same issue in Reports > Expenses page, this is becausetransaction.formattedMerchantwas recalculated in Search page:App/src/components/Search/index.tsx
Lines 417 to 429 in f82a8db
App/src/libs/SearchUIUtils.ts
Line 1817 in f82a8db
App/src/libs/SearchUIUtils.ts
Lines 1099 to 1106 in f82a8db
What changes do you think we should make in order to solve the problem?
Since the values created by
getTransactionItemCommonFormattedPropertiesis only used temporarily and calculated on-the-go, we don't need those values stored. So we should exclude props created bygetTransactionItemCommonFormattedPropertieswhen merging here.App/src/libs/actions/Search.ts
Lines 1156 to 1160 in 7e199a6
What alternative solutions did you explore? (Optional)
These alternate solutions can be implemented together with main solution.
Alternate 1:
We can use the same logics in
SearchUIUtilsto recalculate merchant inMoneyRequestReportTransactionListApp/src/libs/SearchUIUtils.ts
Lines 661 to 662 in f82a8db
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Lines 261 to 264 in f82a8db
Alternate 2:
Looking at
formattedMerchantdescription:App/src/components/TransactionItemRow/index.tsx
Lines 69 to 70 in f82a8db
We see that this value is only used in
Report > Expensespage, so we can limit its usage here:App/src/components/TransactionItemRow/index.tsx
Line 119 in f82a8db
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Dec 3, 2025
@lydiabarclay Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Expense - Old merchant shown on the expense row in the report when edited in Reports[/-][+][$250] Expense - Old merchant shown on the expense row in the report when edited in Reports[/+]melvin-bot commentedon Dec 3, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021996035559289729199
melvin-bot commentedon Dec 3, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @FitseTLT (
External)20 remaining items
[-][$250] Expense - Old merchant shown on the expense row in the report when edited in Reports[/-][+][Due for payment 2026-01-13] [$250] Expense - Old merchant shown on the expense row in the report when edited in Reports[/+]melvin-bot commentedon Jan 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.93-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 6, 2026
@mollfpr @lydiabarclay @FitseTLT / @mkzie2 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
lydiabarclay commentedon Jan 12, 2026
@FitseTLT can you fill out the bz checklist here ahead of the payment date tomorrow?
FitseTLT commentedon Jan 13, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/72001/changes#r2686878250
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/587942
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-378e-a621-b0bb-2f05dd469444lydiabarclay commentedon Jan 13, 2026
Payment Summary
Contributor: @mkzie2 paid $250 via Upwork
Contributor+: @FitseTLT paid $250 via Upwork
✅ Regression test filed