[Due for payment 2025-12-17] [$250] Reports - Select All and Uncategorized are not greyed out when creating a report in offline mode

@jliexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.2.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Bug found around #70534
Email or phone of affected tester (no customers): agexptest+pr281125@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 16, iPhone 13 Mini/ iOS 26.1
App Component: Money Requests

Action Performed:

Go to staging.new.expensify.com
Go offline
Create a report with two manual expenses and any category (Uncategorized appears when there is no category in workspace settings > Categories)
Go to the report thread
Resize the window until the "Select all" label appears (only on Web)

Expected Result:

Select All and Uncategorized are greyed out.

Actual Result:

Select All and Uncategorized are not greyed out as all other IU components.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021995419000651655992
Upwork Job ID: 1995419000651655992
Last Price Increase: 2025-12-01
Automatic offers:

linhvovan29546 | Reviewer | 109693296
nyomanjyotisa | Contributor | 109693300

Issue Owner

Current Issue Owner: @jliexpensify

@jliexpensify

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dominictb

@dominictb / @dmkt9 - is this a regression from your PR?

Proposal

Please re-state the problem that we are trying to solve in this issue.

Select All and Uncategorized are not greyed out when creating a report in offline mode

What is the root cause of that problem?

"Select All" and "Uncategorized" section is rendered without checking offline status

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 452 to 465 in fbed79d

    
           <View style={[styles.dFlex, styles.flexRow, styles.pv2, styles.pr4, StyleUtils.getPaddingLeft(variables.w12)]}> 
        
               <Checkbox 
        
                   onPress={() => { 
        
                       if (selectedTransactionIDs.length !== 0) { 
        
                           clearSelectedTransactions(true); 
        
                       } else { 
        
                           setSelectedTransactions(transactionsWithoutPendingDelete.map((t) => t.transactionID)); 
        
                       } 
        
                   }} 
        
                   accessibilityLabel={CONST.ROLE.CHECKBOX} 
        
                   isIndeterminate={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length !== transactionsWithoutPendingDelete.length} 
        
                   isChecked={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length === transactionsWithoutPendingDelete.length} 
        
               /> 
        
               {isMediumScreenWidth && <Text style={[styles.textStrong, styles.ph3]}>{translate('workspace.people.selectAll')}</Text>}

App/src/components/MoneyRequestReportView/MoneyRequestReportGroupHeader.tsx

Lines 80 to 98 in fbed79d

    
           return ( 
        
               <View style={[styles.reportLayoutGroupHeader, conditionalHeight, style]}> 
        
                   <View style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]}> 
        
                       {shouldShowCheckbox && ( 
        
                           <Checkbox 
        
                               isChecked={isSelected} 
        
                               isIndeterminate={isIndeterminate} 
        
                               onPress={handleToggleSelection} 
        
                               accessibilityLabel={translate('reportLayout.selectGroup', {groupName: displayName})} 
        
                               style={styles.mr2} 
        
                           /> 
        
                       )} 
        
                       <Text 
        
                           style={[styles.textBold, textStyle, styles.flexShrink1, shouldShowCheckbox && styles.ml2]} 
        
                           shouldUseDefaultLineHeight={false} 
        
                           numberOfLines={1} 
        
                       > 
        
                           {displayName} 
        
                       </Text>

What changes do you think we should make in order to solve the problem?

We can apply styles.buttonOpacityDisabled or styles.opacitySemiTransparent style to grey out the "Select All" and "Uncategorized" sections

<View style={[styles.dFlex, styles.flexRow, styles.pv2, styles.pr4, StyleUtils.getPaddingLeft(variables.w12), isOffline && styles.buttonOpacityDisabled]}>
    ...
</View>

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 452 to 465 in fbed79d

    
           <View style={[styles.dFlex, styles.flexRow, styles.pv2, styles.pr4, StyleUtils.getPaddingLeft(variables.w12)]}> 
        
               <Checkbox 
        
                   onPress={() => { 
        
                       if (selectedTransactionIDs.length !== 0) { 
        
                           clearSelectedTransactions(true); 
        
                       } else { 
        
                           setSelectedTransactions(transactionsWithoutPendingDelete.map((t) => t.transactionID)); 
        
                       } 
        
                   }} 
        
                   accessibilityLabel={CONST.ROLE.CHECKBOX} 
        
                   isIndeterminate={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length !== transactionsWithoutPendingDelete.length} 
        
                   isChecked={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length === transactionsWithoutPendingDelete.length} 
        
               /> 
        
               {isMediumScreenWidth && <Text style={[styles.textStrong, styles.ph3]}>{translate('workspace.people.selectAll')}</Text>}

<View style={[styles.reportLayoutGroupHeader, conditionalHeight, style, isOffline && styles.buttonOpacityDisabled]}>
    ...
</View>

App/src/components/MoneyRequestReportView/MoneyRequestReportGroupHeader.tsx

Lines 80 to 98 in fbed79d

    
           return ( 
        
               <View style={[styles.reportLayoutGroupHeader, conditionalHeight, style]}> 
        
                   <View style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]}> 
        
                       {shouldShowCheckbox && ( 
        
                           <Checkbox 
        
                               isChecked={isSelected} 
        
                               isIndeterminate={isIndeterminate} 
        
                               onPress={handleToggleSelection} 
        
                               accessibilityLabel={translate('reportLayout.selectGroup', {groupName: displayName})} 
        
                               style={styles.mr2} 
        
                           /> 
        
                       )} 
        
                       <Text 
        
                           style={[styles.textBold, textStyle, styles.flexShrink1, shouldShowCheckbox && styles.ml2]} 
        
                           shouldUseDefaultLineHeight={false} 
        
                           numberOfLines={1} 
        
                       > 
        
                           {displayName} 
        
                       </Text>

What alternative solutions did you explore? (Optional)

We can wrap it with OfflineWithFeedback

@dominictb / @dmkt9 - is this a regression from your PR?

My PR isn't in production yet, so I guess not.

Job added to Upwork: https://www.upwork.com/jobs/~021995419000651655992

@linhvovan29546

Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

🚨 Edited by proposal-police: This proposal was edited at 2025-12-03 03:57:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Select All and Uncategorized are not greyed out as all other IU components.

What is the root cause of that problem?

We don't wrap the MoneyRequestReportGroupHeader and the checkbox with OfflineWithFeedback

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 497 in f840efe

<MoneyRequestReportGroupHeader

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 453 in f840efe

<Checkbox

What changes do you think we should make in order to solve the problem?

Since the MoneyRequestReportView already has an OfflineWithFeedback here, we should only add the pending action on MoneyRequestReportTransactionList if we're on the report screen which is not search report screen

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 210 in 92c9780

pendingAction={reportPendingAction}

We should wrap these components with OfflineWithFeedback like the same as add expense button here. We can check for other components like sort table header/ total spend to apply the same fix if needed

const isOnSearchMoneyRequestReport = isOnSearchMoneyRequestReportPage();
<OfflineWithFeedback pendingAction={isOnSearchMoneyRequestReport ? undefined : reportPendingAction}>
  <MoneyRequestReportGroupHeader
      group={group}
      isGroupedByTag={currentGroupBy === CONST.REPORT_LAYOUT.GROUP_BY.TAG}
      isSelectionModeEnabled={isMobileSelectionModeEnabled}
      isSelected={selectionState.isSelected}
      isIndeterminate={selectionState.isIndeterminate}
      onToggleSelection={toggleGroupSelection}
      groupKey={group.groupKey}
  />
</OfflineWithFeedback>

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 497 in f840efe

<MoneyRequestReportGroupHeader

<OfflineWithFeedback pendingAction={isOnSearchMoneyRequestReport ? undefined : reportPendingAction}>    
                            <Checkbox
                                onPress={() => {
                                    if (selectedTransactionIDs.length !== 0) {
                                        clearSelectedTransactions(true);
                                    } else {
                                        setSelectedTransactions(transactionsWithoutPendingDelete.map((t) => t.transactionID));
                                    }
                                }}
                                accessibilityLabel={CONST.ROLE.CHECKBOX}
                                isIndeterminate={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length !== transactionsWithoutPendingDelete.length}
                                isChecked={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length === transactionsWithoutPendingDelete.length}
                            />
                            {isMediumScreenWidth && <Text style={[styles.textStrong, styles.ph3]}>{translate('workspace.people.selectAll')}</Text>}
                        </OfflineWithFeedback>

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 453 in f840efe

<Checkbox

What alternative solutions did you explore? (Optional)

We can update pendingAction here to undefined to fix the double opacity problem and we need to add OfflineWithFeedback to each child component which isn't handled.

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Line 210 in 92c9780

pendingAction={reportPendingAction}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Reviewing label has been removed, please complete the "BugZero Checklist".

@nyomanjyotisa

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.74-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: "Select All" section are not greyed out when creating a report in offline mode #76722

If no regressions arise, payment will be issued on 2025-12-17. 🎊

For reference, here are some details about the assignees on this issue:

@nyomanjyotisa requires payment automatic offer (Contributor)
@linhvovan29546 requires payment automatic offer (Reviewer)

@linhvovan29546

@linhvovan29546 @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@linhvovan29546

Bump @linhvovan29546 for checklist please

BugZero Checklist:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/58360/changes#r2622746221
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

This bug has low impact. So I'm not sure we need to create a regression test, I've written the test steps below in case we decide to create it

Open ND.
Go offline.
Create a report with two manual expenses and any category.
Open the report thread.
In the web, resize the browser window to a medium screen and verify that the 'Select all' section are greyed out.
In the mobile app, repeat steps 1–4.
Long-press any item to enter selection mode.
Verify that the "Select all" section are greyed out on mobile.

Do we agree 👍 or 👎

@linhvovan29546

Bump @linhvovan29546 for checklist please

Thanks. I've created the checklist

@nyomanjyotisa

Payment Summary

C: @nyomanjyotisa $250 (to be paid via Upworks)
C+: @linhvovan29546 $250 (to be paid via Upworks)

Upwork job

Paid and job closed.

Navigation Menu

Repository navigation

[Due for payment 2025-12-17] [$250] Reports - Select All and Uncategorized are not greyed out when creating a report in offline mode #76352

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

21 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<View style={[styles.dFlex, styles.flexRow, styles.pv2, styles.pr4, StyleUtils.getPaddingLeft(variables.w12)]}>
	<Checkbox
	onPress={() => {
	if (selectedTransactionIDs.length !== 0) {
	clearSelectedTransactions(true);
	} else {
	setSelectedTransactions(transactionsWithoutPendingDelete.map((t) => t.transactionID));
	}
	}}
	accessibilityLabel={CONST.ROLE.CHECKBOX}
	isIndeterminate={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length !== transactionsWithoutPendingDelete.length}
	isChecked={selectedTransactionIDs.length > 0 && selectedTransactionIDs.length === transactionsWithoutPendingDelete.length}
	/>
	{isMediumScreenWidth && <Text style={[styles.textStrong, styles.ph3]}>{translate('workspace.people.selectAll')}</Text>}

	return (
	<View style={[styles.reportLayoutGroupHeader, conditionalHeight, style]}>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]}>
	{shouldShowCheckbox && (
	<Checkbox
	isChecked={isSelected}
	isIndeterminate={isIndeterminate}
	onPress={handleToggleSelection}
	accessibilityLabel={translate('reportLayout.selectGroup', {groupName: displayName})}
	style={styles.mr2}
	/>
	)}
	<Text
	style={[styles.textBold, textStyle, styles.flexShrink1, shouldShowCheckbox && styles.ml2]}
	shouldUseDefaultLineHeight={false}
	numberOfLines={1}
	>
	{displayName}
	</Text>

[Due for payment 2025-12-17] [$250] Reports - Select All and Uncategorized are not greyed out when creating a report in offline mode #76352

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 1, 2025

jliexpensify commented on Dec 1, 2025

nyomanjyotisa commented on Dec 1, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dmkt9 commented on Dec 1, 2025

melvin-bot commented on Dec 1, 2025

melvin-bot commented on Dec 1, 2025

nkdengineer commented on Dec 1, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

21 remaining items

melvin-bot commented on Dec 10, 2025

melvin-bot commented on Dec 10, 2025

melvin-bot commented on Dec 10, 2025

jliexpensify commented on Dec 16, 2025

linhvovan29546 commented on Dec 16, 2025

BugZero Checklist:

Regression Test Proposal

Test:

linhvovan29546 commented on Dec 16, 2025

jliexpensify commented on Dec 18, 2025

jliexpensify commented on Dec 18, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions