Skip to content

[Due for payment 2025-12-17] [$250] Onboarding - “Connect your corporate card” task shown when all features are disabled #76353

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/50704757 (related but not same steps)
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11, Chrome | iPhone SE 3rd generation, Tahoe 26.1, Chrome | Samsung A15, Android 15, Chrome
App Component: Other

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Sign up using a Gmail address
  3. Select Manage my team's expenses > 1-10 employees > QBO > disable all features
  4. Click Continue
  5. Skip test drive
  6. (If signed up with Gmail address without + go to #admins, else go to Concierge chat.)

Expected Result:

When all features are disabled, the Concierge should not display “Connect your corporate card” task.

Actual Result:

Connect your corporate card is shown when all features are disabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021995582856044451703
  • Upwork Job ID: 1995582856044451703
  • Last Price Increase: 2025-12-01

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 1, 2025
  2. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Dec 1, 2025

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Connect your corporate card" task shown when all features are disabled

    What is the root cause of that problem?

    When a user signs up and disables all features during onboarding, the selectedInterestedFeatures array is empty ([]). The current filtering logic in prepareOnboardingOnyxData only filters out tasks when selectedInterestedFeatures?.length is truthy (non-empty). When the array is empty, the condition is false, so the task is not filtered out and is displayed

    App/src/libs/ReportUtils.ts

    Lines 11302 to 11305 in fbed79d

    if (engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    if (selectedInterestedFeatures?.length && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
    return false;
    }

    App/src/CONST/index.ts

    Lines 7461 to 7466 in fbed79d

    const TASK_TO_FEATURE: Record<string, string> = {
    [CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES]: CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED,
    [CONST.ONBOARDING_TASK_TYPE.ADD_ACCOUNTING_INTEGRATION]: CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED,
    [CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD]: CONST.POLICY.MORE_FEATURES.ARE_COMPANY_CARDS_ENABLED,
    [CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS]: CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED,
    };

    What changes do you think we should make in order to solve the problem?

    We can remove the selectedInterestedFeatures?.length check

                    if (TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
                        return false;
                    }

    App/src/libs/ReportUtils.ts

    Lines 11302 to 11305 in fbed79d

    if (engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    if (selectedInterestedFeatures?.length && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
    return false;
    }

    What alternative solutions did you explore? (Optional)

    None

  4. nkdengineer commented on Dec 1, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Connect your corporate card is shown when all features are disabled.

    What is the root cause of that problem?

    We have the length selectedInterestedFeatures?.length here which is wrong when the selectedInterestedFeatures is empty array

    if (selectedInterestedFeatures?.length && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {

    What changes do you think we should make in order to solve the problem?

    We should update the check to !!selectedInterestedFeatures to exclude the case selectedInterestedFeatures parameter is undefined instead.

    if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
    

    if (selectedInterestedFeatures?.length && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 1, 2025
  6. changed the title [-]Onboarding - “Connect your corporate card” task shown when all features are disabled[/-] [+][$250] Onboarding - “Connect your corporate card” task shown when all features are disabled[/+] on Dec 1, 2025
  7. melvin-bot commented on Dec 1, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 1, 2025
  9. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  10. abbasifaizan70 commented on Dec 1, 2025

    @abbasifaizan70
    Contributor

    🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

  11. github-actions commented on Dec 1, 2025

    @github-actions
    Contributor

    ⚠️ @abbasifaizan70 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

  12. 17 remaining items

  13. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@heyjennahay)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1995582856044451703/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. heyjennahay commented on Dec 18, 2025

    @heyjennahay
    Contributor

    @mananjadhav can you please complete the BZ checklist when you have a moment, then I can complete the payment summary

  15. mananjadhav commented on Dec 18, 2025

    @mananjadhav
    Collaborator

    I'll be doing that in next 30 mins.

  16. mananjadhav commented on Dec 18, 2025

    @mananjadhav
    Collaborator

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: I couldn't pinpoint an exact PR for the root cause.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    I think we should add a regression to avoid any confusion for the Concierge related test.

    Regression Test Proposal

    Test:

    1. Sign up a new account
    2. Select Manage my team's expenses > 1-10 employees > QBO > disable all features
    3. Click Continue
    4. Skip test drive
    5. Notice the onboarding task
    6. Verify that the setup feature task doesn't appear

    Do we agree 👍 or 👎

  17. mananjadhav commented on Dec 18, 2025

    @mananjadhav
    Collaborator

    @heyjennahay Here you go ^

  18. heyjennahay commented on Dec 22, 2025

    @heyjennahay
    Contributor

    Thank you @mananjadhav !

  19. heyjennahay commented on Dec 22, 2025

    @heyjennahay
    Contributor

    Payment summary:

    Please note that payment approvals may take a little longer than usual due to the holidays

    Upwork job closed https://www.upwork.com/jobs/~021995582856044451703

    Thanks everyone for your work!

  20. trjExpensify commented on Dec 23, 2025

    @trjExpensify
    Contributor

    approved $250 for @mananjadhav

  21. twisterdotcom commented on Dec 30, 2025

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-5332-a8ff-81b5-91bec53897e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions