You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-17] [$250] Onboarding - “Connect your corporate card” task shown when all features are disabled #76353
Version Number: v9.2.66-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/50704757 (related but not same steps) Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Windows 11, Chrome | iPhone SE 3rd generation, Tahoe 26.1, Chrome | Samsung A15, Android 15, Chrome App Component: Other
Please re-state the problem that we are trying to solve in this issue.
"Connect your corporate card" task shown when all features are disabled
What is the root cause of that problem?
When a user signs up and disables all features during onboarding, the selectedInterestedFeatures array is empty ([]). The current filtering logic in prepareOnboardingOnyxData only filters out tasks when selectedInterestedFeatures?.length is truthy (non-empty). When the array is empty, the condition is false, so the task is not filtered out and is displayed
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Onboarding - “Connect your corporate card” task shown when all features are disabled[/-][+][$250] Onboarding - “Connect your corporate card” task shown when all features are disabled[/+]on Dec 1, 2025
⚠️@abbasifaizan70 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I couldn't pinpoint an exact PR for the root cause.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I think we should add a regression to avoid any confusion for the Concierge related test.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Dec 1, 2025
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Dec 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Connect your corporate card" task shown when all features are disabled
What is the root cause of that problem?
When a user signs up and disables all features during onboarding, the
selectedInterestedFeaturesarray is empty ([]). The current filtering logic inprepareOnboardingOnyxDataonly filters out tasks whenselectedInterestedFeatures?.lengthis truthy (non-empty). When the array is empty, the condition isfalse, so the task is not filtered out and is displayedApp/src/libs/ReportUtils.ts
Lines 11302 to 11305 in fbed79d
App/src/CONST/index.ts
Lines 7461 to 7466 in fbed79d
What changes do you think we should make in order to solve the problem?
We can remove the
selectedInterestedFeatures?.lengthcheckApp/src/libs/ReportUtils.ts
Lines 11302 to 11305 in fbed79d
What alternative solutions did you explore? (Optional)
None
nkdengineer commentedon Dec 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Connect your corporate card is shown when all features are disabled.
What is the root cause of that problem?
We have the length
selectedInterestedFeatures?.lengthhere which is wrong when theselectedInterestedFeaturesis empty arrayApp/src/libs/ReportUtils.ts
Line 11303 in fbed79d
What changes do you think we should make in order to solve the problem?
We should update the check to
!!selectedInterestedFeaturesto exclude the caseselectedInterestedFeaturesparameter isundefinedinstead.App/src/libs/ReportUtils.ts
Line 11303 in fbed79d
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Onboarding - “Connect your corporate card” task shown when all features are disabled[/-][+][$250] Onboarding - “Connect your corporate card” task shown when all features are disabled[/+]melvin-bot commentedon Dec 1, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021995582856044451703
melvin-bot commentedon Dec 1, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)abbasifaizan70 commentedon Dec 1, 2025
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Dec 1, 2025
17 remaining items
melvin-bot commentedon Dec 17, 2025
Payment Summary
Upwork Job
BugZero Checklist (@heyjennahay)
heyjennahay commentedon Dec 18, 2025
@mananjadhav can you please complete the BZ checklist when you have a moment, then I can complete the payment summary
mananjadhav commentedon Dec 18, 2025
I'll be doing that in next 30 mins.
mananjadhav commentedon Dec 18, 2025
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I couldn't pinpoint an exact PR for the root cause.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I think we should add a regression to avoid any confusion for the Concierge related test.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/581561
Regression Test Proposal
Test:
Do we agree 👍 or 👎
mananjadhav commentedon Dec 18, 2025
@heyjennahay Here you go ^
heyjennahay commentedon Dec 22, 2025
Thank you @mananjadhav !
heyjennahay commentedon Dec 22, 2025
Payment summary:
Please note that payment approvals may take a little longer than usual due to the holidays
Upwork job closed https://www.upwork.com/jobs/~021995582856044451703
Thanks everyone for your work!
trjExpensify commentedon Dec 23, 2025
approved $250 for @mananjadhav
twisterdotcom commentedon Dec 30, 2025
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-5332-a8ff-81b5-91bec53897e4