Skip to content

[Due for payment 2025-12-26] [Due for payment 2025-12-18] [AI Reviewer] PERF-5 eslint rewrite #76362

Closed

Description

@kacper-mikolajczak

Intro

PERF-5 rule seems to be straightforward enough to be implemented as an eslint rule instead of AI reviewer rule. We can take advantage of that.

Eslint PR: Expensify/eslint-config-expensify#171
App PR: #76364

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. kacper-mikolajczak commented on Dec 1, 2025

    @kacper-mikolajczak
    ContributorAuthor

    Hi @abbasifaizan70, I think you posted your proposal here by mistake.

  2. kacper-mikolajczak commented on Dec 1, 2025

    @kacper-mikolajczak
    ContributorAuthor

    @mountiny can we add this to AI reviewer improvements parent ticket? Thanks!

  3. added
    ReviewingHas a PR in review
    and removed on Dec 1, 2025
  4. kacper-mikolajczak commented on Dec 17, 2025

    @kacper-mikolajczak
    ContributorAuthor

    This one is done, can be closed 👍

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 17, 2025
  6. changed the title [-][AI Reviewer] PERF-5 eslint rewrite[/-] [+][Due for payment 2025-12-18] [AI Reviewer] PERF-5 eslint rewrite[/+] on Dec 17, 2025
  7. 1 remaining item

  8. mountiny commented on Dec 17, 2025

    @mountiny
    Contributor

    Thanks!

    $250 to @brunovjk for their review on the PR please, no checklist required on this one as its CI change

  9. melvin-bot commented on Dec 18, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@garrettmknight)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. garrettmknight commented on Dec 19, 2025

    @garrettmknight
    Contributor

    @brunovjk request when you're ready!

  11. changed the title [-][Due for payment 2025-12-18] [AI Reviewer] PERF-5 eslint rewrite[/-] [+][Due for payment 2025-12-26] [Due for payment 2025-12-18] [AI Reviewer] PERF-5 eslint rewrite[/+] on Dec 19, 2025
  12. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.84-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-26. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    @brunovjk @garrettmknight The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. brunovjk commented on Dec 19, 2025

    @brunovjk
    Contributor

    Requested in ND. Thanks

  16. twisterdotcom commented on Dec 20, 2025

    @twisterdotcom
    Contributor

    @brunovjk has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-f413-a9fa-033f-d243de57b9b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions