Skip to content

[Due for payment 2026-08-19] [$250] Remove unnecessary types from translations #76429

Closed

Description

@iwiznia

In this PR #73672 we allowed translations to not need a new type per translation.

What we want to do now is:

  • Remove all existing types that are only used in translations
  • Ensure we always pass the params as standalone params instead of inside an object (like we did in this comment)
Issue OwnerCurrent Issue Owner: @QichenZhu

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 1, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 1, 2025
  3. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

  4. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. self-assigned this
    on Dec 1, 2025
  6. zainAwan9175 commented on Dec 1, 2025

    @zainAwan9175
    Contributor

    Would like to work on this.

  7. blazejkustra commented on Dec 1, 2025

    @blazejkustra
    Contributor

    As discussed here, @mrejdak is going to work on this, sorry!

  8. iwiznia commented on Dec 1, 2025

    @iwiznia
    ContributorAuthor

    @mrejdak can't assign you till you comment

  9. mrejdak commented on Dec 2, 2025

    @mrejdak
    Contributor

    Hey! I'm Michał Rejdak from Software Mansion, an expert agency, and I'm commenting for assignment!

  10. melvin-bot commented on Dec 2, 2025

    @melvin-bot

    📣 @mrejdak! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. mrejdak commented on Dec 2, 2025

    @mrejdak
    Contributor

    Hi @iwiznia, I'll start by replacing all types containing a single parameter. (like the type AddressLineParams below)

    type AddressLineParams = {
        lineNumber: number;
    }
    
    # addressLine: ({lineNumber}: AddressLineParams) => `Address line ${lineNumber}`,
    # replaced with:
    addressLine: (lineNumber : number) => `Address line ${lineNumber}`,

    Regarding the types defining objects that contain multiple params - should those be replace with standalone parameters as well? (e.g. the CharacterLengthLimitParams type)

    type CharacterLengthLimitParams = {
        limit: number;
        length: number;
    }
    # characterLimitExceedCounter: ({length, limit}: CharacterLengthLimitParams) => `Character limit exceeded (${length}/${limit})`,
    # replaced with:
    characterLimitExceedCounter: (length: number, limit: number) => `Character limit exceeded (${length}/${limit})`,
  12. 220 remaining items

  13. MelvinBot commented on Aug 12, 2026

    @MelvinBot
    Contributor

    Here's the full set of PRs linked to this issue with a suggested payout for each. Total suggested: $2,325 across 15 merged PRs (4 more got $0 — 2 reverted, 2 closed-unmerged).

    A quick note on method: these are all mechanical "remove translation types" batches, so I treated the standard repeat batches as low effort ($125), kept the first-of-pattern / unusually-large / real-logic ones at base ($250), and applied the revert/reapply exceptions. Effort tiers are a judgment call — adjust as you see fit.

    PR Batch Status Effort basis Suggested
    #76721 1 Reverted by #77204 (caused "Address line 1" regression) reverted $0
    #77501 1 (reapply) Merged — reapplies batch 1 + skipCache fix base, −50% (reapply) $125
    #76977 2 Closed, unmerged — superseded by #76995 never landed $0
    #76995 2 Merged low effort (mechanical) $125
    #77512 3 Merged low effort (mechanical) $125
    #77669 4 Merged low effort (mechanical) $125
    #77786 5 Merged low effort (mechanical) $125
    #78268 6 Reverted by #79162 (multi-level tag crash) reverted $0
    #79190 6 (reapply) Merged — reapplies batch 6 + promptKeyParams/importFinalModal fix base, −50% (reapply) $125
    #79195 7 Merged low effort (mechanical) $125
    #79891 8 Merged low effort (mechanical) $125
    #79984 9 Merged low effort (mechanical) $125
    #80342 10 Merged base (large: +862/-1561) $250
    #84118 11 Merged base (large; new author picking up the work) $250
    #84256 12 Merged base (large: +1614/-1182) $250
    #84271 13 Merged low effort (small: 12 files) $125
    #84399 14 Merged super trivial (+72/-148) $75
    #84400 15 Closed, unmerged — superseded by #96605 never landed $0
    #96605 15 Merged base (very large: +1200/-1866, 88 files) $250
    How the exceptions were applied
    • Reverted → $0: #76721 (reverted by #77204) and #78268 (reverted by #79162).
    • Follow-up reapply → 50% less: #77501 reapplied batch 1 and #79190 reapplied batch 6. Both carried a real logic fix (skipCache; promptKeyParams/importFinalModal), so I based them at $250 and halved to $125.
    • Closed, never merged → $0: #76977 and #84400 were superseded duplicates that never landed. Not "reverts" — just no work merged — so no payout.

    Payable subtotal: 10 × $125 ($1,250) + 4 × $250 ($1,000) + 1 × $75 ($75) = $2,325.

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Aug 12, 2026
  15. changed the title [-][$250] Remove unnecessary types from translations[/-] [+][Due for payment 2026-08-12] [$250] Remove unnecessary types from translations[/+] on Aug 12, 2026
  16. melvin-bot commented on Aug 12, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  17. joekaufmanexpensify commented on Aug 12, 2026

    @joekaufmanexpensify
    Contributor

    Nice, thanks for doing that. We are aligning on this internally here.

  18. changed the title [-][Due for payment 2026-08-12] [$250] Remove unnecessary types from translations[/-] [+][Due for payment 2026-08-19] [$250] Remove unnecessary types from translations[/+] on Aug 12, 2026
  19. melvin-bot commented on Aug 12, 2026

    @melvin-bot

    @QichenZhu @mallenexpensify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-19. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  20. mallenexpensify commented on Aug 13, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @QichenZhu due $1200 via NewDot

    @QichenZhu, originally the issue was $250 and it significantly crew. It's generally best practice to not cram a bunch of PRs together, in this instance there were 15 PRs but the amount of work, overall, didn't justify $2,325. We ended up doing 15 x $75 to get an amount we felt was fair.

  21. QichenZhu commented on Aug 14, 2026

    @QichenZhu
    Contributor

    It's generally best practice to not cram a bunch of PRs together

    @mallenexpensify @iwiznia @joekaufmanexpensify I'm fine with whatever you think is fair, but I want to clarify the context around the 15 PRs:

    It was decided to split this work into smaller PRs from the start.

    Image

    I kept the team updated after the 5th and 10th PRs, including the estimated total number of PRs.

    Image Image

    So I don't think we deviated from the requested approach. If there were concerns, it would have been better to know earlier so we could adjust course.

  22. trjExpensify commented on Sep 1, 2026

    @trjExpensify
    Contributor

    approved $1,200 for @QichenZhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions