You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-25] Long suggested categories overflow the view #76437
Then pass it as numberOfLines={isConciergeCategoryOptions(action) || isConciergeDescriptionOptions(action) ? 2 : 1} (We can adjust the value here) for the ActionableItemButtons -> Button
note: ellipsizeMode is a prop of React Native Text component, it doesn't work on web so we can use TextWithMiddleEllipsis component instead
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@daledah Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
Pass down the primaryTextNumberOfLines={isConciergeCategoryOptions(action) || isConciergeDescriptionOptions(action) ? 0 : 1} prop to Button from here. We shouldn't pass the undefined value because it will be fallback to th default value. We should use 0 instead.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
Issue is ready for payment but no BZ is assigned. @brianlee-expensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon Dec 1, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)[-]Long suggested categories overflow[/-][+]Long suggested categories overflow the view[/+]zainAwan9175 commentedon Dec 1, 2025
Would like to work on this.
daledah commentedon Dec 1, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-01 17:56:05 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Long suggested categories overflow the view
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Buttoncomponent likenumberOfLinesand make it default to 1 then pass it hereApp/src/components/Button/index.tsx
Lines 299 to 301 in 96a20e5
numberOfLines={isConciergeCategoryOptions(action) || isConciergeDescriptionOptions(action) ? 2 : 1}(We can adjust the value here) for theActionableItemButtons->ButtonApp/src/pages/home/report/PureReportActionItem.tsx
Lines 1510 to 1523 in 96a20e5
App/src/components/ReportActionItem/ActionableItemButtons.tsx
Lines 29 to 35 in 96a20e5
What alternative solutions did you explore? (Optional)
To cover this expected, we should create a new prop to
ButtoncomponentellipsizeModethen pass it to theprimaryTextApp/src/components/Button/index.tsx
Lines 298 to 301 in 96a20e5
From
PureReportActionItemcomponent passellipsizeModeasmiddle->ActionableItemButtons->Buttonnote:
ellipsizeModeis a prop of React Native Text component, it doesn't work on web so we can useTextWithMiddleEllipsiscomponent insteadReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Dec 1, 2025
melvin-bot commentedon Dec 1, 2025
Triggered auto assignment to @dannymcclain (
Design), see these Stack Overflow questions for more details.nkdengineer commentedon Dec 1, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-01 18:04:51 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Long suggested categories overflow the view
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
primaryTextNumberOfLinesprop forButtoncomponent with the default value is1and use it hereApp/src/components/Button/index.tsx
Lines 299 to 301 in 96a20e5
primaryTextNumberOfLines={isConciergeCategoryOptions(action) || isConciergeDescriptionOptions(action) ? 0 : 1}prop toButtonfrom here. We shouldn't pass theundefinedvalue because it will be fallback to th default value. We should use0instead.App/src/pages/home/report/PureReportActionItem.tsx
Lines 1510 to 1523 in 96a20e5
App/src/components/Button/index.tsx
Lines 299 to 301 in 96a20e5
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Dec 1, 2025
31 remaining items
melvin-bot commentedon Dec 25, 2025
Issue is ready for payment but no BZ is assigned. @brianlee-expensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
mananjadhav commentedon Dec 30, 2025
@brianlee-expensify quick bump on the payout here.
melvin-bot commentedon Jan 2, 2026
@mananjadhav, @dannymcclain, @thienlnam, @nkdengineer, @brianlee-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mananjadhav commentedon Jan 5, 2026
Been waiting for the payout here and regression test creation. Then we can close it.
brianlee-expensify commentedon Jan 5, 2026
Payment Summary
Contributor: @nkdengineer due $250 via NewDot
Contributor+: @mananjadhav due $250 via NewDot
trjExpensify commentedon Jan 5, 2026
approved $250 for @mananjadhav.
twisterdotcom commentedon Jan 12, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-9f26-a016-b041-0ec15242b114