Repository navigation
[HOLD for payment 2022-03-08] The “optional” in the “extension” field gets cut off on smaller phone screens #7645
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- open app
- Navigate to Concierge chat > Click on Request a call
- Check “extension” field
Expected Result:
Background text should be visible
Actual Result:
The “optional” in the “extension” field gets cut off on smaller phone screens
Workaround:
unknown
Platform:
Where is this issue occurring?
- iOS
- Android
- Mobile Web
Version Number: 1.1.37-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643925557729559
Activity
MelvinBot commentedon Feb 9, 2022
Triggered auto assignment to @neil-marcellini (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.neil-marcellini commentedon Feb 9, 2022
I should have caught that when I originally added the phone extension field. It looks like a relatively simple fix.
MelvinBot commentedon Feb 9, 2022
Triggered auto assignment to @MitchExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.thesahindia commentedon Feb 9, 2022
Proposal
I think we can fix this by making the label text shorter ex:-
Ext (optional)orExtensionfor small screen device (Otherwise we will have to increase the height)MitchExpensify commentedon Feb 10, 2022
Upwork Job
18 remaining items
parasharrajat commentedon Feb 15, 2022
I think we can do this for all screens. This page will always open on RHN modals. Also, this issue should be part of responsive fonts and it is an edge case ( I think there are very few users with that screen size). Mostly all smartphones have bigger screens these days.
mountiny commentedon Feb 15, 2022
Alright, let's do it then. @mananjadhav feel free to submit a PR :) Thank you for your proposal!
mananjadhav commentedon Feb 16, 2022
Thanks. Was bit unwell, will have the PR by tonight/tomorrow.
MitchExpensify commentedon Feb 17, 2022
Upwork job invites set to both @mananjadhav and @parasharrajat
[-]The “optional” in the “extension” field gets cut off on smaller phone screens[/-][+][HOLD for payment 2022-03-08] The “optional” in the “extension” field gets cut off on smaller phone screens[/+]botify commentedon Mar 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.40-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-03-08. 🎊
mananjadhav commentedon Mar 9, 2022
@MitchExpensify Payment reminder and I've applied to Upwork but I guess not hired for it.
MitchExpensify commentedon Mar 9, 2022
Thanks for the reminder, @mananjadhav! Offers sent to you and @parasharrajat. Will issue payments once accepted
mananjadhav commentedon Mar 9, 2022
@MitchExpensify Accepted
MitchExpensify commentedon Mar 9, 2022
Paid for both and contracts ended. Nice job everyone! Closing