Repository navigation
FEATURE REQUEST: Change [Comment deleted] display #7646
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Navigate to any chat
- Delete the last comment
- Check LHN
- Observe that [Comment deleted] shows in place of the deleted comment
Expected Result:
Don't display [Comment deleted] - i.e. show the last message in thread that wasn't deleted
Actual Result:
[Comment deleted] displayed
Workaround:
N/A
Platform:
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.37-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644019468856869
Activity
MelvinBot commentedon Feb 9, 2022
Triggered auto assignment to @sophiepintoraetz (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Feb 10, 2022
Triggered auto assignment to @luacmartins (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.luacmartins commentedon Feb 11, 2022
We could do all the cleaning in the front-end, but I think it would be great if we also returned the correct data from the
getSummaryListquery. We could filter the deleted messages by including the condition below to the WHERE clause here:"AND JSON_EXTRACT(ra.message, '$.html') != ''"What are your thoughts @marcaaron (it seems that you implemented this query)?
luacmartins commentedon Feb 14, 2022
Moving this to Weekly since it's a nice to have but not a top priority.
marcaaron commentedon Feb 14, 2022
Ah I think there's not really any cleaning we can do in the front end.
reportSummaryListonly gives the last message and that's what we are using for the sidebar previews IIRC. Probably this should beInternal.MelvinBot commentedon Feb 14, 2022
Triggered auto assignment to @dylanexpensify (
Internal) because issue was reported by a contributor who needs to be compensated if this issue is fixedluacmartins commentedon Feb 14, 2022
Thanks for confirming @marcaaron!
dylanexpensify commentedon Feb 15, 2022
@marcaaron I'm seeing this as reported by DB, so no upwork job needed until/if we apply external, right?
luacmartins commentedon Feb 15, 2022
@dylanexpensify that makes sense! Thanks for checking on that.
marcaaron commentedon Feb 15, 2022
If it has an
Internallabel then it doesn't go to UpworkJulesssss commentedon Feb 16, 2022
If anyone picks this up within the next couple of days and manages to make progress, please close out this external bugfix issue that would become redundant.
I left it open for now as it is not obvious that A) Someone will find time to prioritize this change internally, and B) that it is a simple change to make