[$250] Reports-Expense still shown in Submit section after being submitted offline and going online

@nkdengineer

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.2.67-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176923/test-cases/41237528
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 26.1
App Component: Search

Action Performed:

Sign in to ND
Create two expenses in the workspace chat
Navigate to the Reports tab, select Submit in To-do section
Go offline
Open the report, click Submit button
Click back button - expense is still displayed in the Submit section
Click Approve section - it has an empty state
Open Submit section again and go online

Expected Result:

Expense is not shown in Submit section after being submitted offline and going online

Actual Result:

Expense still shown in Submit section after being submitted offline and going online

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7018170_1764644695901.Expense_stays_in_Submit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021998059595376860907
Upwork Job ID: 1998059595376860907
Last Price Increase: 2025-12-15

Issue Owner

Current Issue Owner: @nkdengineer

@heyjennahay

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Problem Statement

When a user submits an expense report while offline and then goes back online, the report remains stuck in the "Submit" section even though it has already been submitted. The report appears in a ghost state where it shows as submitted but still displays in the Submit to-do list.

Root Cause

When submitting a report offline, the app applies optimistic updates to immediately show the report as submitted in the UI. These updates change several report fields:

statusNum and stateNum to SUBMITTED
managerID to the new approver
lastMessageText and lastMessageHtml to show the submit action
pendingAction flag on the report action

When the device goes back online, if the API request fails, the app should revert all these changes using failureData. However, the current failureData is incomplete - it only reverts the status fields but not the other changed fields like managerID, lastMessageText, and lastMessageHtml.

This partial revert creates an inconsistent state where the report shows conflicting information, causing it to remain visible in the Submit section.

Proposed Solution

Update the failureData in the submitReport function (src/libs/actions/IOU.ts) to revert all optimistically changed fields when submission fails:

const failureData: OnyxUpdate[] = [
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
        value: {
            statusNum: CONST.REPORT.STATUS_NUM.OPEN,
            stateNum: CONST.REPORT.STATE_NUM.OPEN,
            managerID: expenseReport.managerID,              // ✅ Add this
            lastMessageText: expenseReport.lastMessageText,  // ✅ Add this
            lastMessageHtml: expenseReport.lastMessageHtml,  // ✅ Add this
            nextStep: expenseReport.nextStep ?? null,
            pendingFields: {
                nextStep: null,
            },
        },
    },
    // ... existing code ...
];

failureData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${expenseReport.reportID}`,
    value: {
        [optimisticSubmittedReportAction.reportActionID]: {
            errors: getMicroSecondOnyxErrorWithTranslationKey('iou.error.other'),
            pendingAction: null,  // ✅ Add this
        },
    },
});

This ensures when a submission fails after going online, the report returns to its exact pre-submission state.

Alternative Solutions

N/A

@ashu75575

📣 @ashu75575! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: tejveersingh.75575@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01309a71996aa312f4

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense still shown in Submit section after being submitted offline and going online

What is the root cause of that problem?

We only have the logic to filter out the report based on the status. No logic to filter out the report based on the action.

App/src/libs/SearchUIUtils.ts

Line 1557 in 92c9780

let shouldShow = true;

What changes do you think we should make in order to solve the problem?

Update the shouldShow here to filter out the report based on the action. We have two options to do that:

Based on the action from the query, we can check the report status

const actionFilterMapping = {
    [CONST.SEARCH.ACTION_FILTERS.SUBMIT]: expenseStatusActionMapping[CONST.SEARCH.STATUS.EXPENSE.DRAFTS],
    [CONST.SEARCH.ACTION_FILTERS.APPROVE]: expenseStatusActionMapping[CONST.SEARCH.STATUS.EXPENSE.OUTSTANDING],
    [CONST.SEARCH.ACTION_FILTERS.PAY]: expenseStatusActionMapping[CONST.SEARCH.STATUS.EXPENSE.APPROVED],
    [CONST.SEARCH.ACTION_FILTERS.EXPORT]: () => true,
}
function isValidActionFilter(action: unknown): action is ValueOf<typeof CONST.SEARCH.ACTION_FILTERS> {
    return typeof action === 'string' && action in actionFilterMapping;
}
const actionFromQuery = queryJSON?.flatFilters?.find((filter) => filter.key === CONST.SEARCH.SYNTAX_FILTER_KEYS.ACTION)?.filters?.at(0)?.value;

if (actionFromQuery && isValidActionFilter(actionFromQuery)) {
                shouldShow = shouldShow && actionFilterMapping[actionFromQuery](reportItem);
            }

App/src/libs/SearchUIUtils.ts

Line 1557 in 92c9780

let shouldShow = true;

Based on the action from the query, we can check if allActions include this action

if (actionFromQuery === CONST.SEARCH.ACTION_FILTERS.EXPORT || (actionFromQuery && isValidActionFilter(actionFromQuery) && allActions.includes(actionFromQuery))) {
                    reportIDToTransactions[reportKey] = {
                        ...reportItem,
                        action: allActions.at(0) ?? CONST.SEARCH.ACTION_TYPES.VIEW,
                        allActions,
                        keyForList: String(reportItem.reportID),
                        groupedBy: CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT,
                        from: fromDetails,
                        to: toDetails,
                        formattedFrom,
                        formattedTo,
                        formattedStatus,
                        transactions,
                        ...(reportPendingAction ? {pendingAction: reportPendingAction} : {}),
                        shouldShowYear: doesDataContainAPastYearReport,
                        hasVisibleViolations: hasVisibleViolationsForReport,
                    };
                    if (isIOUReport) {
                        reportIDToTransactions[reportKey].reportName = getIOUReportName(data, reportIDToTransactions[reportKey]);
                    }
                }

We can align with the backend filter logic to improve the filter check above.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@heyjennahay

@heyjennahay Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Job added to Upwork: https://www.upwork.com/jobs/~021998059595376860907

Correct

@nkdengineer

@nkdengineer you wanna take another swing?

It's on my list, will raise the PR soon.

Expected Result:
Expense is not shown in Submit section after being submitted offline and going online

Hmm, if we don't want to hide the expense from the list when submitting while offline, then what's the new expected behavior?

@luacmartins

@luacmartins @garrettmknight Can you please check the @bernhardoj 's comment?

Hmm, if we don't want to hide the expense from the list when submitting while offline, then what's the new expected behavior?

I'm not sure I follow, where did someone say we don't want the report not to show in Submit after submitting offline?

I understand that we don't want to do the client-side filtering from these comments
#79714 (comment)
#79132 (comment)

Look like it's fixed now with live data on todo section #79506

I think we can close since it's fixed.

Navigation Menu

Repository navigation

[$250] Reports-Expense still shown in Submit section after being submitted offline and going online #76519

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Problem Statement

Root Cause

Proposed Solution

Alternative Solutions

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Reports-Expense still shown in Submit section after being submitted offline and going online #76519

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 2, 2025

ashu75575 commented on Dec 2, 2025

Proposal

Problem Statement

Root Cause

Proposed Solution

Alternative Solutions

melvin-bot commented on Dec 2, 2025

ashu75575 commented on Dec 2, 2025

melvin-bot commented on Dec 2, 2025

nkdengineer commented on Dec 3, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Dec 6, 2025

melvin-bot commented on Dec 8, 2025

48 remaining items

luacmartins commented on Jan 20, 2026

garrettmknight commented on Jan 21, 2026

nkdengineer commented on Jan 21, 2026

bernhardoj commented on Jan 21, 2026

nkdengineer commented on Jan 25, 2026

garrettmknight commented on Jan 27, 2026

bernhardoj commented on Jan 27, 2026

nkdengineer commented on Jan 27, 2026

garrettmknight commented on Jan 29, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions