You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-07] [$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline #76563
Version Number: 9.2.67-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#75704 Email or phone of affected tester (no customers):ibellicotest+2134@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) App Component: Search
Action Performed:
Prerequisite: Account has at least one workspace.
Prerequisite 2: Delayed submissions and approvals enabled.
Open the Expensify app.
Open any workspace chat.
Create a manual expense.
Tap on "Submit" on expense preview.
Navigate to "Reports" > "Approve"
Turn off internet connection.
Navigate to "Account" > "Troubleshoot"
Tap on "Clear cache and restart"
Select "Refresh and reset"
Return to "Reports" > "Approve"
Turn on internet connection.
Note that when expense reappears, link on preview displays "Chat Report" instead of workspace chat name.
Navigate to link and return.
Note that now, link is displayed correctly again.
Expected Result:
Link on expense preview on "Reports", should display the workspace chat´s name correctly after clearing cache.
Actual Result:
Link on expense preview on "Reports" changes to "Chat Report" after clearing cache while offline and returning online.
changed the title [-]Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/-][+][$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/+]on Dec 4, 2025
Please re-state the problem that we are trying to solve in this issue.
After clearing cache while offline, the expense preview link in the Approve tab incorrectly displays "Chat Report" instead of the workspace chat name, until the user navigates into the report and back.
What is the root cause of that problem?
When cache is cleared offline, the personalDetailsList needed to compute the workspace chat's display name is temporarily unavailable. The existing logic incorrectly falls back to "Chat Report" instead of allowing the value to recompute once data is restored.
This prevents the UI from updating after Onyx syncs back missing participant data.
What changes do you think we should make in order to solve the problem?
Update getPolicyExpenseChatName() to return undefined when participant details are not yet available, so React can correctly recompute the display name once Onyx repopulates.
And When personalDetails is cleared from Onyx, there's no logic to clear previousDisplayNames and previousPersonalDetails.
So when we secondly set personalDetails, we don't recompute report attributes because previousDisplayNames is not cleared and so it's considered same as currentDisplayNames .
changed the title [-][$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/-][+][Due for payment 2026-01-07] [$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/+]on Dec 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@situchan@trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Prerequisite:
Account has at least one workspace.
Delayed submissions and approvals enabled.
Test:
Open any workspace chat.
Create a manual expense.
Tap on "Submit" on expense preview.
Navigate to "Reports" > "Approve".
Observe the "From " hyperlink is correct.
Go to Troubleshoot > Clear Cache and Restart.
Return to "Reports" > "Approve".
Verify that "From " hyperlink is correct. It should be workspace chat's name, not "Chat Report".
Activity
melvin-bot commentedon Dec 2, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Dec 4, 2025
I can repro this on iOS native... the steps can be simplified to this as well btw:
[-]Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/-][+][$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/+]melvin-bot commentedon Dec 4, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021996579616100818321
melvin-bot commentedon Dec 4, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)ahmedelshaikh20 commentedon Dec 6, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
After clearing cache while offline, the expense preview link in the Approve tab incorrectly displays "Chat Report" instead of the workspace chat name, until the user navigates into the report and back.
What is the root cause of that problem?
When cache is cleared offline, the
personalDetailsListneeded to compute the workspace chat's display name is temporarily unavailable. The existing logic incorrectly falls back to"Chat Report"instead of allowing the value to recompute once data is restored.This prevents the UI from updating after Onyx syncs back missing participant data.
Here is the root issue:
App/src/libs/ReportNameUtils.ts
Lines 220 to 233 in d34df44
What changes do you think we should make in order to solve the problem?
Update
getPolicyExpenseChatName()to returnundefinedwhen participant details are not yet available, so React can correctly recompute the display name once Onyx repopulates.This ensures:
IOS: mWeb
Reports_Link_Issue.MP4
What alternative solutions did you explore? (Optional)
NA
apeyada commentedon Dec 8, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reports - Link on expense preview changes to "Chat Report" after clearing cache
What is the root cause of that problem?
This bug came from #70087
App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts
Lines 12 to 13 in 41ad0a9
When we first set
personalDetails, we don't recompute report attributes because of this logic:App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts
Lines 40 to 43 in 41ad0a9
Returning early here sets
displayNamesChangedflag false here and then early returned:App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts
Lines 90 to 92 in 41ad0a9
And When
personalDetailsis cleared from Onyx, there's no logic to clearpreviousDisplayNamesandpreviousPersonalDetails.So when we secondly set
personalDetails, we don't recompute report attributes becausepreviousDisplayNamesis not cleared and so it's considered same ascurrentDisplayNames.App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts
Lines 46 to 49 in 41ad0a9
What changes do you think we should make in order to solve the problem?
displayNamesChangedto true whenpreviousPersonalDetailsdoesn't exist andpersonalDetailsis set in OnyxApp/src/libs/actions/OnyxDerived/configs/reportAttributes.ts
Lines 40 to 43 in 41ad0a9
return
Object.keys(currentDisplayNames).length > 0instead of falsepreviousDisplayNamesandpreviousPersonalDetailswhenpersonalDetailsis cleared from OnyxApp/src/libs/actions/OnyxDerived/configs/reportAttributes.ts
Lines 87 to 93 in 41ad0a9
Add else condition here: (
areAllConnectionsSet=true and sourceValues=undefined=> this means cleared from Onyx)What alternative solutions did you explore? (Optional)
situchan commentedon Dec 8, 2025
@TMisiukiewicz looks like this is regression from your old PR created for performance improvement.
This proposal makes sense to me. What do you think?
22 remaining items
[-][$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/-][+][Due for payment 2026-01-07] [$250] Reports - Link on expense preview changes to "Chat Report" after clearing cache offline[/+]melvin-bot commentedon Dec 31, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 31, 2025
@situchan @trjExpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
trjExpensify commentedon Jan 7, 2026
👋 checklist time here, @situchan.
situchan commentedon Jan 7, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/70087/changes#r2670379584
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Prerequisite:
Test:
Do we agree 👍 or 👎
trjExpensify commentedon Jan 12, 2026
Payment summary as follows:
Thanks, closing!