Skip to content

[Due for payment 2025-12-26] [$125] iOS - Attachment - The You appear to be offline message overlaps the Send button #76653

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2266/folder/13176710/41236949/1054918282?sort=%2Bidentifier
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the app
  2. Navigate to any chat
  3. Go offline
  4. Click the + button in the composer > Add attachment
  5. Select any image

Expected Result:

The send button is not overlapped by the message "You appear to be offline"

Actual Result:

The "You appear to be offline" message overlaps the Send button

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7019808_1764783714530.1ScreenRecording_12-03-2025_12-34-45_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021996618723166363025
  • Upwork Job ID: 1996618723166363025
  • Last Price Increase: 2025-12-04
  • Automatic offers:
    • daledah | Contributor | 109783848
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 3, 2025
  2. melvin-bot commented on Dec 3, 2025

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Dec 3, 2025

    @daledah
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-12-05 07:43:59 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "You appear to be offline" message overlaps the Send button

    What is the root cause of that problem?

    We have both a enableEdgeToEdgeBottomSafeAreaPadding prop here

    <ScreenWrapper
    navigation={navigation}
    testID={`attachment-modal-${testID}`}
    enableEdgeToEdgeBottomSafeAreaPadding
    >

    and safeAreaPaddingBottomStyle here

    <Animated.View
    style={safeAreaPaddingBottomStyle}

    What changes do you think we should make in order to solve the problem?

    We should remove SafeAreaConsumer wrapper the use useBottomSafeSafeAreaPaddingStyle instead (like we did with other components)

        const bottomSafeAreaPaddingStyle = useBottomSafeSafeAreaPaddingStyle({
            addBottomSafeAreaPadding: true,
            addOfflineIndicatorBottomSafeAreaPadding: true,
        });
    
          <LayoutAnimationConfig skipEntering>
                  <Animated.View
                      entering={FadeIn}
                      style={bottomSafeAreaPaddingStyle}
                  >
                     ...
                  </Animated.View>
          </LayoutAnimationConfig>
    

    <SafeAreaConsumer>
    {({safeAreaPaddingBottomStyle}) => (
    <Animated.View
    style={safeAreaPaddingBottomStyle}
    entering={FadeIn}
    >
    <Button
    ref={submitRef ? viewRef(submitRef) : undefined}
    success
    large
    style={[styles.buttonConfirm, shouldUseNarrowLayout ? {} : styles.attachmentButtonBigScreen]}
    textStyles={[styles.buttonConfirmText]}
    text={translate('common.send')}
    onPress={submitAndClose}
    isDisabled={isConfirmButtonDisabled || shouldDisableSendButton}
    pressOnEnter
    />
    </Animated.View>
    )}
    </SafeAreaConsumer>

    What alternative solutions did you explore? (Optional)

    Image

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. samranahm commented on Dec 3, 2025

    @samranahm
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 20:24:29 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    iOS - Attachment - The You appear to be offline message overlaps the Send button

    What is the root cause of that problem?

    The "You appear to be offline" message is displayed by the ScreenWrapper component's OfflineIndicator, which sticks to the bottom of the screen. When we have both, The Send button and The offline indicator
    They were overlapping because they were both trying to occupy the same space at the bottom of the screen. The Send button container already has

    safeAreaPaddingBottomStyle that handles device safe area but we're missing mb5 here

    <Animated.View
    style={safeAreaPaddingBottomStyle}

    What changes do you think we should make in order to solve the problem?

    we should add styles.mb5 to Animated.View

    style={[safeAreaPaddingBottomStyle, isOffline && styles.mb6]}

    here

    <Animated.View
    style={safeAreaPaddingBottomStyle}

    This is the same margin we use throughout the App but we can increase or decrease it as required

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

    Results

    Image
  5. joekaufmanexpensify commented on Dec 4, 2025

    @joekaufmanexpensify
    Contributor

    Reproduced. Reducing price as this is a minor style change.

  6. changed the title [-]iOS - Attachment - The You appear to be offline message overlaps the Send button[/-] [+][$250] iOS - Attachment - The You appear to be offline message overlaps the Send button[/+] on Dec 4, 2025
  7. melvin-bot commented on Dec 4, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 4, 2025
  9. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

  10. changed the title [-][$250] iOS - Attachment - The You appear to be offline message overlaps the Send button[/-] [+][$125] iOS - Attachment - The You appear to be offline message overlaps the Send button[/+] on Dec 4, 2025
  11. 35 remaining items

  12. melvin-bot commented on Jan 1, 2026

    @melvin-bot

    @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. joekaufmanexpensify commented on Jan 2, 2026

    @joekaufmanexpensify
    Contributor

    Bump @alitoshmatov, could you handle the checklist here so we can pay?

  14. joekaufmanexpensify commented on Jan 5, 2026

    @joekaufmanexpensify
    Contributor

    Bumped this again in slack so we can get this closed soon.

  15. alitoshmatov commented on Jan 5, 2026

    @alitoshmatov
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/69523/changes#r2662815687

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: No discussion

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  16. joekaufmanexpensify commented on Jan 6, 2026

    @joekaufmanexpensify
    Contributor

    All set to pay!

  17. joekaufmanexpensify commented on Jan 6, 2026

    @joekaufmanexpensify
    Contributor

    Payment Summary

  18. joekaufmanexpensify commented on Jan 6, 2026

    @joekaufmanexpensify
    Contributor

    @daledah $125 sent and contract ended

  19. joekaufmanexpensify commented on Jan 6, 2026

    @joekaufmanexpensify
    Contributor

    Upwork job closed

  20. joekaufmanexpensify commented on Jan 6, 2026

    @joekaufmanexpensify
    Contributor

    @alitoshmatov Please request payment at your earliest convenience. Closing as this is otherwise all set 👍

  21. JmillsExpensify commented on Jan 19, 2026

    @JmillsExpensify
    Contributor

    $125 approved for @alitoshmatov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions