You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-26] [$125] iOS - Attachment - The You appear to be offline message overlaps the Send button #76653
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 20:24:29 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
iOS - Attachment - The You appear to be offline message overlaps the Send button
What is the root cause of that problem?
The "You appear to be offline" message is displayed by the ScreenWrapper component's OfflineIndicator, which sticks to the bottom of the screen. When we have both, The Send button and The offline indicator
They were overlapping because they were both trying to occupy the same space at the bottom of the screen. The Send button container already has
safeAreaPaddingBottomStyle that handles device safe area but we're missing mb5 here
This is the same margin we use throughout the App but we can increase or decrease it as required
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]iOS - Attachment - The You appear to be offline message overlaps the Send button[/-][+][$250] iOS - Attachment - The You appear to be offline message overlaps the Send button[/+]on Dec 4, 2025
changed the title [-][$250] iOS - Attachment - The You appear to be offline message overlaps the Send button[/-][+][$125] iOS - Attachment - The You appear to be offline message overlaps the Send button[/+]on Dec 4, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Dec 3, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Dec 3, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-05 07:43:59 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "You appear to be offline" message overlaps the Send button
What is the root cause of that problem?
We have both a
enableEdgeToEdgeBottomSafeAreaPaddingprop hereApp/src/pages/media/AttachmentModalScreen/AttachmentModalContainer/index.native.tsx
Lines 55 to 59 in 3d868d7
and
safeAreaPaddingBottomStylehereApp/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx
Lines 330 to 331 in 0134330
What changes do you think we should make in order to solve the problem?
We should remove
SafeAreaConsumerwrapper the useuseBottomSafeSafeAreaPaddingStyleinstead (like we did with other components)App/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx
Lines 328 to 347 in 0134330
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
samranahm commentedon Dec 3, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-04 20:24:29 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
iOS - Attachment - The You appear to be offline message overlaps the Send button
What is the root cause of that problem?
The "You appear to be offline" message is displayed by the
ScreenWrappercomponent's OfflineIndicator, which sticks to the bottom of the screen. When we have both, The Send button and The offline indicatorThey were overlapping because they were both trying to occupy the same space at the bottom of the screen. The Send button container already has
safeAreaPaddingBottomStylethat handles device safe area but we're missingmb5hereApp/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx
Lines 330 to 331 in 0134330
What changes do you think we should make in order to solve the problem?
we should add
styles.mb5toAnimated.Viewhere
App/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx
Lines 330 to 331 in 0134330
This is the same margin we use throughout the App but we can increase or decrease it as required
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Results
joekaufmanexpensify commentedon Dec 4, 2025
Reproduced. Reducing price as this is a minor style change.
[-]iOS - Attachment - The You appear to be offline message overlaps the Send button[/-][+][$250] iOS - Attachment - The You appear to be offline message overlaps the Send button[/+]melvin-bot commentedon Dec 4, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021996618723166363025
melvin-bot commentedon Dec 4, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)[-][$250] iOS - Attachment - The You appear to be offline message overlaps the Send button[/-][+][$125] iOS - Attachment - The You appear to be offline message overlaps the Send button[/+]35 remaining items
melvin-bot commentedon Jan 1, 2026
@joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
joekaufmanexpensify commentedon Jan 2, 2026
Bump @alitoshmatov, could you handle the checklist here so we can pay?
joekaufmanexpensify commentedon Jan 5, 2026
Bumped this again in slack so we can get this closed soon.
alitoshmatov commentedon Jan 5, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/69523/changes#r2662815687
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
joekaufmanexpensify commentedon Jan 6, 2026
All set to pay!
joekaufmanexpensify commentedon Jan 6, 2026
Payment Summary
joekaufmanexpensify commentedon Jan 6, 2026
@daledah $125 sent and contract ended
joekaufmanexpensify commentedon Jan 6, 2026
Upwork job closed
joekaufmanexpensify commentedon Jan 6, 2026
@alitoshmatov Please request payment at your earliest convenience. Closing as this is otherwise all set 👍
JmillsExpensify commentedon Jan 19, 2026
$125 approved for @alitoshmatov